Review Request 114524: Load the kdoctools macro before trying to find the build deps

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114524/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Let's get in release mode!

On Tue, Dec 17, 2013 at 11:47 PM, Martin Klapetek wrote: > On Tue, Dec 17, 2013 at 11:39 AM, David Faure wrote: > >> On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote: >> > Other than apidox, I was also concerned about frameworkintegration, >> > itemmodels, itemviews and dnssd. The rest of

Jenkins build is back to normal : plasma-framework_master_qt5 #972

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #971

See Changes: [sebas] Fix borders in dialog depending on location -- [...truncated 320 lines...]

Re: Review Request 114478: Add kshareddatacache.h include

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Let's get in release mode!

On Tuesday 17 December 2013 Kevin Ottens wrote: > > That's an option. We could also see if we could make inqlude.org job > easier, I guess it uses a similar input format too. Yes, inqlude.org uses a similar meta file, but I would argue it's more simple, and we have full control about it. I was a

Build failed in Jenkins: plasma-framework_master_qt5 #970

See Changes: [sebas] constness++ -- [...truncated 320 lines...] Generating units.moc

Re: Review Request 114521: Rename DNSSD to KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114521/#review45885 --- This review has been submitted with commit 4a5546b1c57126f8e60

Re: Review Request 114522: Rename itemviews to kitemviews

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114522/#review45887 --- This review has been submitted with commit ba5307d1e45baabf235

Re: Review Request 114521: Rename DNSSD to KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114521/#review45884 --- Ship it! Ship It! - Christophe Giboudeaux On Dec. 17, 2013,

Re: Review Request 114522: Rename itemviews to kitemviews

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114522/#review45886 --- Ship it! Ship It! - Christophe Giboudeaux On Dec. 17, 2013,

Re: Review Request 114521: Rename DNSSD to KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114521/ --- (Updated Dec. 17, 2013, 7 p.m.) Status -- This change has been marked

Re: Review Request 114522: Rename itemviews to kitemviews

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114522/ --- (Updated Dec. 17, 2013, 7:21 p.m.) Status -- This change has been mar

Re: Review Request 114521: Rename DNSSD to KDNSSD

> On Dec. 17, 2013, 6:14 p.m., Christophe Giboudeaux wrote: > > tier2/dnssd/src/CMakeLists.txt, line 85 > > > > > > dnssd or kdnssd for headers ? (same thing line 89) > > > > If you choose the later, the c

Re: Review Request 114521: Rename DNSSD to KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114521/ --- (Updated Dec. 17, 2013, 7:11 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 114478: Add kshareddatacache.h include

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Review Request 114521: Rename DNSSD to KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114521/#review45876 --- tier2/dnssd/src/CMakeLists.txt

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/ --- (Updated Dec. 17, 2013, 5:57 p.m.) Status -- This change has been mar

Review Request 114522: Rename itemviews to kitemviews

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114522/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 114521: Rename DNSSD to KDNSSD

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114521/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Let's get in release mode!

On Tuesday 17 December 2013 11:32:46 Aurélien Gâteau wrote: > On Tue, 17 Dec 2013 11:17:35 +0100, Aurélien Gâteau wrote: > > On Mon, 16 Dec 2013 18:17:59 +0100, Kevin Ottens wrote: > >>> Regarding the split: what is going to happen to the frameworks > >>> branch of the > >>> kdelibs repository afte

Re: Review Request 114478: Add kshareddatacache.h include

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Fwd: Tracking bugs in Frameworks

On Monday 16 December 2013 23:30:15 Sebastian Kügler wrote: > On Monday, December 16, 2013 19:30:25 Martin Graesslin wrote: > > On Monday 16 December 2013 19:01:25 David Edmundson wrote: > > > On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin > > > > > > > On Monday 16 December 2013 11:58:35 Davi

Re: framework names (Re: Let's get in release mode!)

On 17/12/13 15:31, Alex Merry wrote: > On 17/12/13 15:26, Aurélien Gâteau wrote: >> On Tue, 17 Dec 2013 14:54:44 +, Alex Merry wrote: >>> On 17/12/13 12:57, Aurélien Gâteau wrote: > I guess the question is - what does this module actually bring. I > assume, a consistent look-n-feel for

Re: framework names (Re: Let's get in release mode!)

On Tue, 17 Dec 2013 14:54:44 +, Alex Merry wrote: On 17/12/13 12:57, Aurélien Gâteau wrote: I guess the question is - what does this module actually bring. I assume, a consistent look-n-feel for KDE-produced api docs, right? Yes. It also goes a bit further by doing things like generating

Re: framework names (Re: Let's get in release mode!)

On 17/12/13 15:26, Aurélien Gâteau wrote: > On Tue, 17 Dec 2013 14:54:44 +, Alex Merry wrote: >> On 17/12/13 12:57, Aurélien Gâteau wrote: I guess the question is - what does this module actually bring. I assume, a consistent look-n-feel for KDE-produced api docs, right? >>> >>> Yes.

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/ --- (Updated Dec. 17, 2013, 4:29 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/#review45872 --- Ship it! - David Faure On Dec. 17, 2013, 3:10 p.m., Aurélien

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/ --- (Updated Dec. 17, 2013, 4:10 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/#review45870 --- tier4/kde4support/KF5KDE4SupportConfig.cmake.in:60 also need a

Re: Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/ --- (Updated Dec. 17, 2013, 4:03 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

On Tuesday 17 December 2013 14:52:56 Alex Merry wrote: > Except I can't, because of Ben's push blocking :-) Aurélien, Kévin and I have superpowers :) Stuff that needs moving between frameworks, or renaming actual frameworks, is a lot easier to handle before splitting, so we're doing that today,

Review Request 114518: Rename the itemmodels frameworks to kitemmodels

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114518/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: migration KIcon to QIcon

Thanks Aleix! The KDE_FULL_SESSION=true fixed the thing:) Would be nice to add it to the list of variables in "Runtime setup" section at http://community.kde.org/Frameworks/Building. I've completely missed it in "Running unit tests" one:) Cheers Michal On Tuesday 17 of December 2013 14:56:46 Al

Re: framework names (Re: Let's get in release mode!)

On 17/12/13 12:57, Aurélien Gâteau wrote: >> I guess the question is - what does this module actually bring. I >> assume, a consistent look-n-feel for KDE-produced api docs, right? > > Yes. It also goes a bit further by doing things like generating menus > in the sidebar and handling cross-doxygen

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

> On Dec. 17, 2013, 2:50 p.m., David Faure wrote: > > Ship It! Except I can't, because of Ben's push blocking :-) - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114512/#review4586

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114512/#review45868 --- This review has been submitted with commit 24f5d19bfd4a622b4cb

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114512/ --- (Updated Dec. 17, 2013, 2:52 p.m.) Status -- This change has been mar

Re: Review Request 114512: Move Qt imageformat .desktop files to kde4support

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114512/#review45866 --- Ship it! Ship It! - David Faure On Dec. 16, 2013, 9:13 p.m.

Re: migration KIcon to QIcon

On Mon, Dec 16, 2013 at 5:18 PM, Michal Humpula wrote: > Hi there, > > have a small glitch with icon loading on frameworks. If I understand > correctly, the migration path for KIcon is QIcon::fromTheme, right? > > Unfortunately this is giving me empty results, which might be caused by > QIcon::the

Re: framework names (Re: Let's get in release mode!)

On Tue, 17 Dec 2013 13:25:02 +0100, David Faure wrote: On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote: Other than apidox, I was also concerned about frameworkintegration, itemmodels, itemviews and dnssd. Let's rename the repos to kitemmodels, kitemviews and kdnssd, this will be in lin

framework names (Re: Let's get in release mode!)

On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote: > Other than apidox, I was also concerned about frameworkintegration, > itemmodels, itemviews and dnssd. Let's rename the repos to kitemmodels, kitemviews and kdnssd, this will be in line with karchive and most others (this doesn't change th

Re: Review Request 114478: Add kshareddatacache.h include

> On Dec. 15, 2013, 9:22 p.m., Kevin Ottens wrote: > > It is in fact intended that way as kguiaddons isn't supposed to include > > stuff coming from kcoreaddons (yeah I know it's slightly convoluted in that > > particular case). > > Albert Astals Cid wrote: > So basically we have a header

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

> On Dec. 17, 2013, 10:35 a.m., Commit Hook wrote: > > This review has been submitted with commit > > dea0dcccb922e528a1c2f2a2bd3a102cf756d3e9 by David Faure on behalf of Alex > > Merry to branch frameworks. Thanks! - Alex --- This is

Re: Let's get in release mode!

On Tue, Dec 17, 2013 at 11:39 AM, David Faure wrote: > On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote: > > Other than apidox, I was also concerned about frameworkintegration, > > itemmodels, itemviews and dnssd. The rest of the names are quite > > descriptive as to what they contain and

Build failed in Jenkins: kdelibs_frameworks_qt5 #1871

See Changes: [agateau] KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS [agateau] Fix line endings -- [...truncated 303 lines...] -- Looking for include file sys/time.h - found -- Looking for i

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/ --- (Updated Dec. 17, 2013, 10:42 a.m.) Status -- This change has been ma

Re: Review Request 114502: KDE4_ENABLE_EXCEPTIONS => KDE_ENABLE_EXCEPTIONS

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114502/#review45854 --- This review has been submitted with commit d18d3cfc5516c9fdc24

Re: Let's get in release mode!

On Tuesday 17 December 2013 23:27:39 Ben Cooksley wrote: > Other than apidox, I was also concerned about frameworkintegration, > itemmodels, itemviews and dnssd. The rest of the names are quite > descriptive as to what they contain and are fine. Yeah, itemmodels and itemviews often come up as not

Build failed in Jenkins: kdelibs_frameworks_qt5 #1870

See Changes: [faure] Rename kdewidgets to kdesignerplugin -- [...truncated 304 lines...] -- Looking for include file sys/time.h - found -- Looking for include file arpa/nameser_compat.h -- Look

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/ --- (Updated Dec. 17, 2013, 10:35 a.m.) Status -- This change has been ma

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45853 --- This review has been submitted with commit dea0dcccb922e528a1c

Re: Let's get in release mode!

On Tue, 17 Dec 2013 11:17:35 +0100, Aurélien Gâteau wrote: On Mon, 16 Dec 2013 18:17:59 +0100, Kevin Ottens wrote: Regarding the split: what is going to happen to the frameworks branch of the kdelibs repository after the split? Is it going to be removed or is it going to stay there with the fra

Re: Let's get in release mode!

On Tue, Dec 17, 2013 at 10:59 PM, David Faure wrote: > On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote: > > On Tue, Dec 17, 2013 at 9:37 PM, David Faure wrote: > > > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: > > > > I do have some reservations as to the name of quite a few

Re: Review Request 114496: Rename kdewidgets to kf5designerplugin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114496/#review45848 --- Ship it! This should go in before the split, since it affects

Re: Let's get in release mode!

On Tue, Dec 17, 2013 at 11:15 PM, Alex Merry wrote: > On 17/12/13 08:37, David Faure wrote: > > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: > >> I do have some reservations as to the name of quite a few of those > >> repositories however as they are very generic - and thus tread on c

Re: karchive bad split

On Tuesday 17 December 2013 22:37:09 Ben Cooksley wrote: > Hi Treeve, > > It seems that I may have mis-pushed this repository. > I have now adjusted it's contents with what is supposed to be the KArchive > repository - can you please check? > > Thanks, > Ben fixed now, and kio also builds against

Re: Let's get in release mode!

On Mon, 16 Dec 2013 18:17:59 +0100, Kevin Ottens wrote: Hello, On Monday 16 December 2013 15:16:42 Aurélien Gâteau wrote: Do you want us to add ourselves as contacts in the table or do you plan to fill it later? If the former, I would assign myself to "Get the dependency graph generator script

Re: Let's get in release mode!

On 17/12/13 08:37, David Faure wrote: > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: >> I do have some reservations as to the name of quite a few of those >> repositories however as they are very generic - and thus tread on common >> namespace. Suggestions are welcome. > > In case anyo

Re: Let's get in release mode!

On Tue, 17 Dec 2013 10:59:45 +0100, David Faure wrote: On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote: On Tue, Dec 17, 2013 at 9:37 PM, David Faure wrote: > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: > > I do have some reservations as to the name of quite a few of those

Re: Let's get in release mode!

On Tuesday 17 December 2013 21:40:48 Ben Cooksley wrote: > On Tue, Dec 17, 2013 at 9:37 PM, David Faure wrote: > > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: > > > I do have some reservations as to the name of quite a few of those > > > repositories however as they are very generic -

Re: karchive bad split

Hi Treeve, It seems that I may have mis-pushed this repository. I have now adjusted it's contents with what is supposed to be the KArchive repository - can you please check? Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

karchive bad split

/karchive contains the itemviews data karchive$ ls autotests CMakeLists.txt COPYING COPYING.LIB KF5ItemViewsConfig.cmake.in Mainpage.dox src tests it installs the following files: /opt/qt5/include/KF5/itemviews_export.h /opt/qt5/include/KF5/itemviews_version.h /opt/qt5/include/KF5/kcate

Re: Where's kf5_add_ui_files ?

> [: Aleix Pol :] > FWIW, how could this have worked before? :/ There was an initial patch, then some weeks of hiatus and discussion, and then it was committed very recently as a stop-gap measure. Probably something got lost in the process. -- Chusslove Illich (Часлав Илић) signature.asc Descr

Re: Let's get in release mode!

On Tue, Dec 17, 2013 at 9:37 PM, David Faure wrote: > On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: > > I do have some reservations as to the name of quite a few of those > > repositories however as they are very generic - and thus tread on common > > namespace. Suggestions are welcome

Re: Let's get in release mode!

On Tuesday 17 December 2013 14:10:56 Ben Cooksley wrote: > I do have some reservations as to the name of quite a few of those > repositories however as they are very generic - and thus tread on common > namespace. Suggestions are welcome. In case anyone wonders, here's the full list of frameworks:

migration KIcon to QIcon

Hi there, have a small glitch with icon loading on frameworks. If I understand correctly, the migration path for KIcon is QIcon::fromTheme, right? Unfortunately this is giving me empty results, which might be caused by QIcon::themeName() giving me empty string. If I configure the theme manually