Re: Review Request 115602: Rename kactivitymanagerd

2014-02-21 Thread Ivan Čukić
On Feb. 21, 2014, 6:29 a.m., Kevin Ottens wrote: I understand Ivan point of view. Now I'm wondering about something: Are we sure the situation will be the same in the future for a 5 to 6 transition? I don't think we can be 100% sure and so we might want to start versioning to be

Re: using KDBusConnectionPool in libraries

2014-02-21 Thread Kevin Krammer
On Friday, 2014-02-21, 08:30:02, Kevin Ottens wrote: Hello, On Thursday 20 February 2014 20:03:20 Aaron J. Seigo wrote: I ran into an interesting situation the other day with libkactivities: it uses KDBusConnectionPool to create connections in a thread-safe manner. KDBusConnectionPool

Re: Review Request 115602: Rename kactivitymanagerd

2014-02-21 Thread Kevin Ottens
On Feb. 21, 2014, 6:29 a.m., Kevin Ottens wrote: I understand Ivan point of view. Now I'm wondering about something: Are we sure the situation will be the same in the future for a 5 to 6 transition? I don't think we can be 100% sure and so we might want to start versioning to be

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

2014-02-21 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50455 --- Ship it! Ship It! - Kevin Ottens On Feb. 21, 2014, 7:35

Re: using KDBusConnectionPool in libraries

2014-02-21 Thread Aaron J. Seigo
On Friday, February 21, 2014 08:30:02 Kevin Ottens wrote: Hello, On Thursday 20 February 2014 20:03:20 Aaron J. Seigo wrote: I ran into an interesting situation the other day with libkactivities: it uses KDBusConnectionPool to create connections in a thread-safe manner.

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

2014-02-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/ --- (Updated Feb. 21, 2014, 10:23 a.m.) Status -- This change has been

Re: Review Request 115827: Add KMainWindow::initialGeometrySet to increase SC

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115827/#review50456 --- This review has been submitted with commit

Re: Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

2014-02-21 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/ --- (Updated Feb. 21, 2014, 10:28 a.m.) Status -- This change has been

Re: Review Request 115908: Remove Ki18n from KCompletion dependencies in cmake.in

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115908/#review50457 --- This review has been submitted with commit

Re: Review Request 115907: Link tests with extra libraries as well

2014-02-21 Thread Alex Merry
On Feb. 20, 2014, 10:46 a.m., Alex Merry wrote: Can you describe the problem this fixes? Are the tests directly using these libraries somehow? Adrián Chaves Fernández wrote: If I build with these steps: mkdir -p build cd build cmake ../kxmlgui-4.96.0 \

Re: Review Request 115742: KParts: Allow compilation on windows

2014-02-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115742/#review50460 --- Ship it! Ship It! - Alex Merry On Feb. 20, 2014, 4:27

Re: Review Request 115775: Defer to CMake's find_dependency macro if it exists

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115775/#review50461 --- This review has been submitted with commit

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/#review50462 --- This review has been submitted with commit

Re: Review Request 115816: Remove strigi libs from kf5-frameworks-build-include

2014-02-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115816/ --- (Updated Feb. 21, 2014, 11:19 a.m.) Status -- This change has been

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50464 --- This review has been submitted with commit

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50465 --- This review has been submitted with commit

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/ --- (Updated Feb. 21, 2014, 11:21 a.m.) Status -- This change has been

Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115896/#review50463 --- This review has been submitted with commit

Figuring out kde-runtime: localization

2014-02-21 Thread Aleix Pol
Hi, Going through the information we have in kde-runtime [1] we found there are two subdirectories related to localization (localization and l10n) that we couldn't find a correct place to move to. Can anybody give us a hand and help us figure those out? - localization: has plenty of information

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-02-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated Feb. 21, 2014, 12:26 p.m.) Review request for KDE Frameworks.

Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository:

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-02-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review50466 --- src/lib/kaboutdata.h

desktoptojson and kservice

2014-02-21 Thread Aaron J. Seigo
Hi ... So, the next fun thing I’ve run into is desktoptojson. Currently in Sprinter I’m just hand writing the json files for the plugins. However, in its TODO file is this: * Metadata * localization/i18n in plugin metadata (name, description) * license * author information (name,

Re: Review Request 115932: Add declarative plugin for KWindowSystem

2014-02-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/#review50468 --- the approach looks good to me, just two small requests: *

Re: desktoptojson and kservice

2014-02-21 Thread Aaron J. Seigo
Aaron J. SeigoOn Friday, February 21, 2014 13:41:29 wrote: What are the plans for i18n in desktoptojson? It currently does not catch any translations in the .desktop file. actually, i think it might be worse than “does not catch any translations”: if it does what i suspect it does, it takes

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/ --- (Updated Feb. 21, 2014, 12:56 p.m.) Status -- This change has been

Re: Review Request 115840: Rename Platform to Frameworks in both about dialogs

2014-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115840/#review50469 --- This review has been submitted with commit

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-02-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated Feb. 21, 2014, 2:03 p.m.) Review request for KDE Frameworks.

Re: desktoptojson and kservice

2014-02-21 Thread Aaron J. Seigo
On Friday, February 21, 2014 13:57:07 Kevin Krammer wrote: If we want to be able to parse .desktop files without KConfig, we need a desktop file parser. valuable to know, indeed. thanks for sharing your experience, saves me some effort. The Razor-Qt and LxQt people might have one already.

Re: Review Request 115909: Remove unused dependency from krunner

2014-02-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115909/#review50475 --- Ship it! Ship It! - Sebastian Kügler On Feb. 20, 2014,

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-02-21 Thread Alexander Richardson
On Feb. 21, 2014, 7:35 a.m., Kevin Ottens wrote: autotests/kconfigtest.cpp, line 219 https://git.reviewboard.kde.org/r/115875/diff/1/?file=244867#file244867line219 Hm we're loosing the test mode for QStandardPaths, I don't think that's desirable. It is done inside

Re: Review Request 115936: Split ki18n ktranscript tests into one using the plugin and one instantiating/destroying the class directly

2014-02-21 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115936/ --- (Updated Feb. 21, 2014, 4:58 p.m.) Review request for KDE Frameworks and