Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-05 Thread Martin Gräßlin
On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: I don't think papering over the X11-ness of kdesu like this is the right approach. Of course, what this framework really needs is a test app; maybe a simple port of the kdesu app from kde-runtime? Kevin Ottens wrote: This kind of

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-05 Thread Stephen Kelly
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the final 3.0 release). -

Review Request 116608: KPasswordDialog: Add method to access the buttonBox

2014-03-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Christoph Feck.

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/ --- (Updated March 5, 2014, 9 a.m.) Status -- This change has been

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52029 --- This review has been submitted with commit

Re: Review Request 116088: Remove FindDBusMenuQt5.cmake

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/#review52032 --- This review has been submitted with commit

Re: Review Request 116088: Remove FindDBusMenuQt5.cmake

2014-03-05 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/ --- (Updated March 5, 2014, 9:10 a.m.) Status -- This change has been

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/ --- (Updated March 5, 2014, 10:11 a.m.) Status -- This change has been

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

2014-03-05 Thread Aurélien Gâteau
On March 4, 2014, 1:06 a.m., Aleix Pol Gonzalez wrote: Ok, I just realized this was being dealt with and I did a different patch: https://git.reviewboard.kde.org/r/116573/ I think that having UI strings on a header file is quite bad TBH, but since I see there's consensus I'll

Re: Review Request 116545: Fix KHTML compilation when using clang.

2014-03-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116545/ --- (Updated March 5, 2014, 9:26 a.m.) Status -- This change has been

Re: Review Request 116542: Fix compilation with clang 3.4.

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116542/#review52036 --- This review has been submitted with commit

Re: Review Request 116544: Fix clang compilation warning:

2014-03-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116544/ --- (Updated March 5, 2014, 9:27 a.m.) Status -- This change has been

Re: Review Request 116541: Fix compiler error when using clang:

2014-03-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116541/ --- (Updated March 5, 2014, 9:27 a.m.) Status -- This change has been

Re: Review Request 116541: Fix compiler error when using clang:

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116541/#review52037 --- This review has been submitted with commit

Re: Review Request 116544: Fix clang compilation warning:

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116544/#review52038 --- This review has been submitted with commit

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-05 Thread Kevin Ottens
On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote: I don't think papering over the X11-ness of kdesu like this is the right approach. Of course, what this framework really needs is a test app; maybe a simple port of the kdesu app from kde-runtime? Kevin Ottens wrote: This kind of

Re: Review Request 116609: Fix all properties flags

2014-03-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/#review52043 --- Ship it! Ship It! - David Edmundson On March 5, 2014,

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

2014-03-05 Thread Kevin Ottens
Hello, On Tuesday 04 March 2014 22:54:42 David Faure wrote: On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote: It wasn't that transparent at all - a number of modules have been re- downloaded in a different location in my local source directory: * plasma-frameworks moved under

Re: KSpeech

2014-03-05 Thread Kevin Ottens
Hello, On Tuesday 04 March 2014 16:43:10 Jeremy Whiting wrote: I've realized a bit ago that kspeech was not included in the kdelibs split (probably because it was in staging at the time and didn't conform to the other framework policies yet). I've cleaned it up a bit and put it in my scratch

Review Request 116610: Use flag types in NETRootInfo

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116610/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 116609: Fix all properties flags

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/ --- (Updated March 5, 2014, 9:51 a.m.) Status -- This change has been

Re: Review Request 116609: Fix all properties flags

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/#review52045 --- This review has been submitted with commit

Jenkins build is back to stable : kdelibs_stable #1027

2014-03-05 Thread KDE CI System
See http://build.kde.org/job/kdelibs_stable/1027/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

2014-03-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52048 --- Ship it! Thanks, this supersedes 116603. - Christoph Feck

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review52049 --- This review has been submitted with commit

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 12:14 p.m.) Review request for KDE Frameworks,

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 11:49 a.m.) Review request for KDE Frameworks.

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 11:49 a.m.) Status -- This change has been

Re: Review Request 116090: Use $TARGET_FILE:... instead of get_target_property(... LOCATION)

2014-03-05 Thread Alex Merry
On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote: The problem with doing this in support code is that it is not strictly source compatible. An example this would break is if you want to embed the value of QT_QMAKE_EXECUTABLE into a C++ executable using something like

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52058 --- This review has been submitted with commit

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review52059 --- This review has been submitted with commit

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated March 5, 2014, 11:55 a.m.) Status -- This change has been

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

2014-03-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 12:04 p.m.) Status -- This change has been

Re: Review Request 116096: Re-enable autotests

2014-03-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/ --- (Updated March 5, 2014, 12:08 p.m.) Review request for KDE Frameworks.

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/#review52065 --- This review has been submitted with commit

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/#review52064 --- This review has been submitted with commit

Re: Review Request 116567: Implement fuzzy image matching in readtest

2014-03-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/ --- (Updated March 5, 2014, 12:11 p.m.) Status -- This change has been

Re: Review Request 116090: Use $TARGET_FILE:... instead of get_target_property(... LOCATION)

2014-03-05 Thread Alex Merry
On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote: The problem with doing this in support code is that it is not strictly source compatible. An example this would break is if you want to embed the value of QT_QMAKE_EXECUTABLE into a C++ executable using something like

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52067 --- Note that find_package(Wayland COMPONENTS Client Egl)

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Alex Merry
On March 5, 2014, 12:31 p.m., Alex Merry wrote: Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). I hadn't realised that about pkg_check_modules(), though. I'll have to update the docs I

Re: Review Request 116598: Check versions for individual components of Wayland

2014-03-05 Thread Aurélien Gâteau
On March 5, 2014, 1:31 p.m., Alex Merry wrote: Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). Alex Merry wrote: I hadn't realised that about pkg_check_modules(), though. I'll have

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52076 --- This review has been submitted with commit

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52077 --- This review has been submitted with commit

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

2014-03-05 Thread Stephen Kelly
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: And I agree with Aurélien, a bug should be filed and Stephen involved in that issue. Stephen Kelly wrote: Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the

Re: Review Request 116561: Drop KWindowEffects::showWindowThumbnails

2014-03-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116561/ --- (Updated March 5, 2014, 1:47 p.m.) Status -- This change has been

Re: Review Request 116561: Drop KWindowEffects::showWindowThumbnails

2014-03-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116561/#review52080 --- This review has been submitted with commit

Review Request 116615: Remove deprecated method languageForEncoding()

2014-03-05 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116615/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens.

Review Request 116616: Remove unused find-modules back to the attic

2014-03-05 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: Review Request 116615: Remove deprecated method languageForEncoding()

2014-03-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116615/#review52086 --- Ship it! This function will be removed before KDE4 is

Re: Review Request 116615: Remove deprecated method languageForEncoding()

2014-03-05 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116615/ --- (Updated March 5, 2014, 3:05 p.m.) Status -- This change has been

Re: Review Request 116616: Remove unused find-modules back to the attic

2014-03-05 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/#review52202 --- Ship it! Ship It! - Kevin Ottens On March 5, 2014, 2:31

Re: KF5 Update Meeting Minutes 2014-w10

2014-03-05 Thread Valentin Rusu
Hello, Catching up with KF5 progress... On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: * Repository merges for kwallet and kdnssd still reported as pending... What's that? Is that about merging 4.xx repository with the KF5 one? * afiestas has kwallet patches in need of review,

Re: KF5 Update Meeting Minutes 2014-w10

2014-03-05 Thread Kevin Ottens
Hello, On Thursday 06 March 2014 02:13:36 Valentin Rusu wrote: Catching up with KF5 progress... On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: * Repository merges for kwallet and kdnssd still reported as pending... What's that? Is that about merging 4.xx repository with the