Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

2014-03-13 Thread Martin Gräßlin
On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: I don't think papering over the X11-ness of kdesu like this is the right approach. Of course, what this framework really needs is a test app; maybe a simple port of the kdesu app from kde-runtime? Kevin Ottens wrote: This kind of

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52874 --- It would have been better to just put a local copy of that

Re: Review Request 116747: Clean up KCompletionBox

2014-03-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52881 --- src/kcompletionbox.cpp

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread Alex Merry
On March 13, 2014, 8:41 a.m., David Faure wrote: It would have been better to just put a local copy of that desktop file into the kservice autotests subdir, so that it's always available to run the test on. Now we depend on konsolerun.desktop which might change in the future, etc.

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/ --- (Updated March 13, 2014, 11:27 a.m.) Status -- This change has been

Review Request 116781: List catalog from all install dirs

2014-03-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 116781: List catalog from all install dirs

2014-03-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/#review52886 --- Ship it! Thank you; I can't test now but it looks sane; as a

Re: Review Request 116781: List catalog from all install dirs

2014-03-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- (Updated March 13, 2014, 1:47 p.m.) Review request for Documentation,

Re: Review Request 116781: List catalog from all install dirs

2014-03-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/#review52890 --- This review has been submitted with commit

Re: Review Request 116781: List catalog from all install dirs

2014-03-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- (Updated March 13, 2014, 1:01 p.m.) Status -- This change has been

Build failed in Jenkins: kdoctools_master_qt5 #38

2014-03-13 Thread KDE CI System
See http://build.kde.org/job/kdoctools_master_qt5/38/changes Changes: [agateau] List catalog from all install dirs -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Review Request 116785: Unbreak bootstrapping

2014-03-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Re: Review Request 116785: Unbreak bootstrapping

2014-03-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/#review52892 --- Ship it! Discussed on IRC - Luigi Toscano On March 13,

Re: Review Request 116785: Unbreak bootstrapping

2014-03-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/#review52893 --- This review has been submitted with commit

Jenkins build is back to normal : kdoctools_master_qt5 #39

2014-03-13 Thread KDE CI System
See http://build.kde.org/job/kdoctools_master_qt5/39/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116785: Unbreak bootstrapping

2014-03-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116785/ --- (Updated March 13, 2014, 2:09 p.m.) Status -- This change has been

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116760/ --- (Updated March 13, 2014, 2:49 p.m.) Status -- This change has been

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-13 Thread Alex Merry
On March 12, 2014, 5:39 p.m., David Faure wrote: well I'm still hoping some sort of migration of the useful config data will happen OK, I'll leave this for now, then. - Alex --- This is an automatically generated e-mail. To

Review Request 116786: Make error handling more consistent and fail earlier

2014-03-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/ --- Review request for Documentation, KDE Frameworks and Luigi Toscano.

Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/ --- Review request for KDE Frameworks, kwin and Martin Gräßlin. Repository:

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52902 --- Looks good, just a few items below: src/core/kconfigini.cpp

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread David Faure
On March 13, 2014, 7:54 p.m., Matthew Dawson wrote: src/core/kconfigini.cpp, lines 86-89 https://git.reviewboard.kde.org/r/116689/diff/1/?file=253150#file253150line86 Is there a reason for these extra debug statements? Argh, that stupid post-review script+alias always grabs local

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/ --- (Updated March 13, 2014, 8:06 p.m.) Review request for KDE Frameworks

Re: Review Request 116786: Make error handling more consistent and fail earlier

2014-03-13 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/#review52907 --- src/meinproc.cpp

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
On March 13, 2014, 3:54 p.m., Matthew Dawson wrote: src/core/kcoreconfigskeleton.cpp, line 990 https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990 Also, can you change the documentation for KCoreConfigSkeleton to reflect this change? Specifically, for

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread David Faure
On March 13, 2014, 7:54 p.m., Matthew Dawson wrote: src/core/kcoreconfigskeleton.cpp, line 990 https://git.reviewboard.kde.org/r/116689/diff/1/?file=253151#file253151line990 Also, can you change the documentation for KCoreConfigSkeleton to reflect this change? Specifically, for

Re: Review Request 116747: Clean up KCompletionBox

2014-03-13 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/ --- (Updated March 13, 2014, 10:13 p.m.) Review request for KDE Frameworks.

Re: Review Request 116689: KCoreConfigSkeleton: delay parsing until the call to readConfig()

2014-03-13 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116689/#review52913 --- Ship it! Ship It! - Matthew Dawson On March 13, 2014,

Re: Review Request 116787: Always create NETEventFilter (a QWidget subclass) in the main application thread

2014-03-13 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52915 --- You'll need a drawable, clients will require XInitThreads if

Review Request 116792: Fix deprecation warning in KComboBox and fix all KDE_NO_DEPRECATED

2014-03-13 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116792/ --- Review request for KDE Frameworks. Repository: kcompletion Description