On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote:
What's the use case? Didn't we have a different way for translating ui
files?
What's the use case?
well as explained in the comment for translating dynamically loaded UI files.
Where is that used? In KWin for the configuration of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/#review59933
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118639/
---
(Updated June 13, 2014, 7:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118612/#review59939
---
Ship it!
src/lib/io/kdirwatch.cpp
On June 13, 2014, 1:06 a.m., Albert Astals Cid wrote:
What's the use case? Didn't we have a different way for translating ui
files?
Martin Gräßlin wrote:
What's the use case?
well as explained in the comment for translating dynamically loaded UI
files. Where is that
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118716/#review59949
---
+9000 for the ever present comments!
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118716/#review59952
---
kcms/translations/kcmtranslations.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118716/#review59954
---
kcms/translations/kcmtranslations.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118723/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118723/#review59962
---
Ship it!
Ship It!
- Marco Martin
On June 13, 2014, 10:44
On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote:
kcms/translations/kcmtranslations.cpp, lines 54-55
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line54
this is a library. One may NEVER use setApplicationDomain in a library,
it would break the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118725/
---
Review request for KDE Frameworks.
Repository: kservice
Description
On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote:
kcms/translations/kcmtranslations.cpp, lines 54-55
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line54
this is a library. One may NEVER use setApplicationDomain in a library,
it would break the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118716/#review59968
---
kcms/translations/CMakeLists.txt
On June 13, 2014, 11:49 a.m., Martin Gräßlin wrote:
kcms/translations/CMakeLists.txt, line 13
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280670#file280670line13
new code shouldn't use kdelibs4support
There doesn't seem to be an equivalent for translation changed. I'll
On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote:
kcms/translations/kcmtranslations.cpp, lines 54-55
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line54
this is a library. One may NEVER use setApplicationDomain in a library,
it would break the
On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote:
kcms/translations/kcmtranslations.cpp, lines 54-55
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line54
this is a library. One may NEVER use setApplicationDomain in a library,
it would break the
On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote:
kcms/translations/kcmtranslations.cpp, lines 54-55
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line54
this is a library. One may NEVER use setApplicationDomain in a library,
it would break the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118723/
---
(Updated June 13, 2014, 12:21 p.m.)
Status
--
This change has been
On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
autotests/CMakeLists.txt, line 53
https://git.reviewboard.kde.org/r/118680/diff/1/?file=280375#file280375line53
Why did you need to create a separate call to ecm_add_test?
If it's for the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118698/#review59997
---
Ship it!
Ship It!
- Aurélien Gâteau
On June 12, 2014, 7
On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
autotests/CMakeLists.txt, line 53
https://git.reviewboard.kde.org/r/118680/diff/1/?file=280375#file280375line53
Why did you need to create a separate call to ecm_add_test?
If it's for the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/
---
(Updated June 13, 2014, 3:03 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review60014
---
Ship it!
Seems good to me.
- Aleix Pol Gonzalez
On June
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review60020
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/
---
(Updated June 13, 2014, 3:29 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118612/#review60050
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118612/#review60049
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118612/
---
(Updated June 13, 2014, 5:57 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118612/
---
(Updated June 13, 2014, 9:57 p.m.)
Status
--
This change has been
See http://build.kde.org/job/kcoreaddons_master_qt5/107/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
On June 13, 2014, 11:53 a.m., Martin Klapetek wrote:
kcms/translations/kcmtranslations.cpp, line 49
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line49
Why are you having John's name translated? ;)
Because he will be ??? in my language.
- Chusslove
On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote:
kcms/translations/kcmtranslations.cpp, lines 54-55
https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line54
this is a library. One may NEVER use setApplicationDomain in a library,
it would break the
33 matches
Mail list logo
