On July 13, 2014, 11:17 a.m., Mark Gaiser wrote:
src/core/udsentry.cpp, line 72
https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72
I'm not sure if this is the correct approach either.
When i'm looking at file.cpp (in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119267/
---
Review request for KDE Frameworks, kwin and Martin Gräßlin.
Repository:
On Sun, Jul 13, 2014 at 11:24 PM, David Gil Oliva davidgilol...@gmail.com
wrote:
Hi!
I'm trying to build KEmoticons and KCompletion with kdesrc-build, but it
fails right from the cmake-git compilation. Its SHA1 ID is
6ac04aee51ab3cb9c05efb6f6195bf34f9609fae .
This is the error that it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119267/#review62275
---
please extend the unit test for both NETWinInfo and
On July 14, 2014, 9:35 a.m., Martin Gräßlin wrote:
src/kwindowsystem_x11.cpp, line 596
https://git.reviewboard.kde.org/r/119267/diff/1/?file=290051#file290051line596
NET::WMDesktop looks wrong to me. This means: please add a unit test.
I guess it can be 0 instead? The setter method
On July 13, 2014, 11:17 a.m., Mark Gaiser wrote:
src/core/udsentry.cpp, line 72
https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72
I'm not sure if this is the correct approach either.
When i'm looking at file.cpp (in
On July 14, 2014, 11:35 a.m., Martin Gräßlin wrote:
src/kwindowsystem_x11.cpp, line 596
https://git.reviewboard.kde.org/r/119267/diff/1/?file=290051#file290051line596
NET::WMDesktop looks wrong to me. This means: please add a unit test.
Ivan Čukić wrote:
I guess it can be 0
On Monday 14 July 2014 12:34:44 Eike Hein wrote:
Hi David,
I'd like to port the ebrowsing KCM and move it to
plasma-desktop or -workspace, since it has plenty
of users outside of Konq (e.g. Konvi, Konsole and
Okular, the first two of which have ports now).
Thoughts?
The whole split
On 07/14/2014 12:46 PM, David Faure wrote:
Given that the kurifilter plugins themselves are in KIO for this same reason,
maybe the ebrowsing and the kio (cookies,proxies,useragent) KCMs should go
into KIO as well?
Sorry, I missed this because it got filtered into k-f-d
due to the CC :). I
On 14 July 2014 11:46, David Faure fa...@kde.org wrote:
On Monday 14 July 2014 12:34:44 Eike Hein wrote:
Hi David,
I'd like to port the ebrowsing KCM and move it to
plasma-desktop or -workspace, since it has plenty
of users outside of Konq (e.g. Konvi, Konsole and
Okular, the first two of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119155/
---
(Updated July 14, 2014, 1:22 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62294
---
autotests/coronatest.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119274/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119247/#review62298
---
Ship it!
Ship It!
- Mark Gaiser
On jul 13, 2014, 8:35
On jul 13, 2014, 11:17 a.m., Mark Gaiser wrote:
src/core/udsentry.cpp, line 72
https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72
I'm not sure if this is the correct approach either.
When i'm looking at file.cpp (in
On July 14, 2014, 1:40 p.m., David Edmundson wrote:
autotests/coronatest.cpp, lines 99-100
https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line99
This will wipe the tester's settings, no?
yep, that's the intention, other tests do that as well:
On July 14, 2014, 1:40 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 70
https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line70
Why?
I thought the overriding the plugin loader was so we don't need real
plugins.
whithout any sycoca
On July 14, 2014, 1:40 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 81
https://git.reviewboard.kde.org/r/119270/diff/1/?file=290064#file290064line81
why is this commented out?
copy and paste, i guess both using it a or not is fine, since it's waiting for
the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/
---
(Updated July 14, 2014, 5:22 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62312
---
Ship it!
autotests/coronatest.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119247/
---
(Updated July 14, 2014, 5:33 p.m.)
Status
--
This change has been
On July 14, 2014, 5:26 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 95
https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95
it might make sense to make all of this in init()/cleanup() rather than
initTestCase()
that way each test gets
On July 14, 2014, 5:26 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 95
https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95
it might make sense to make all of this in init()/cleanup() rather than
initTestCase()
that way each test gets
On July 14, 2014, 5:26 p.m., David Edmundson wrote:
autotests/coronatest.cpp, line 95
https://git.reviewboard.kde.org/r/119270/diff/2/?file=290134#file290134line95
it might make sense to make all of this in init()/cleanup() rather than
initTestCase()
that way each test gets
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119275/
---
Review request for KDE Frameworks, Alex Merry and Michael Pyne.
Hi Ben,
while trying to build libalkimia on the OSX/CI system I noticed that the
framework misses GMP, without pointing it out to the user as a required package!
Though, one notices it later on during the build:
---
...
[ 28%] Built target alkimia_automoc
Scanning dependencies of target
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/
---
(Updated July 14, 2014, 6:57 p.m.)
Status
--
This change has been
On Juli 12, 2014, 6:50 nachm., Alex Merry wrote:
I'm generally in favour of this. Other than the issues noted below, I have
two concerns:
1. Have you looked at some users of plugins and determined that the
particular methods you've added to KPluginLoader are ones that will be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/
---
(Updated July 14, 2014, 8:20 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/
---
(Updated July 14, 2014, 8:22 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/
---
(Updated July 14, 2014, 8:30 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/
---
(Updated July 14, 2014, 8:36 p.m.)
Review request for KDE Frameworks and
On Juli 13, 2014, 1:17 nachm., Mark Gaiser wrote:
src/core/udsentry.cpp, line 72
https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72
I'm not sure if this is the correct approach either.
When i'm looking at file.cpp (in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119284/
---
Review request for KDE Frameworks and Plasma.
Repository:
Hi,
2014-07-14 23:21 GMT+02:00 David Gil Oliva:
Hi!
KConfig build fails with this messages, all of them related to
QBasicAtomicInt. Are they KF5 bugs?
probably this is the same issue that has been discussed in
https://git.reviewboard.kde.org/r/119257/ ? According to David F.,
this might
Hi!
2014-07-15 0:19 GMT+02:00 Frank Reininghaus frank7...@googlemail.com:
Hi,
2014-07-14 23:21 GMT+02:00 David Gil Oliva:
Hi!
KConfig build fails with this messages, all of them related to
QBasicAtomicInt. Are they KF5 bugs?
probably this is the same issue that has been discussed
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119284/#review62355
---
Ship it!
Thanks!
- Aleix Pol Gonzalez
On July 14, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119275/#review62358
---
Is this because of the usage of list(APPEND)? Maybe using
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119274/#review62359
---
Can we get some advertisement about why Atlas is better?
/me
On 15 July 2014 06:49, Marko Käning mk-li...@email.de wrote:
Hi Ben,
Hi Marko,
while trying to build libalkimia on the OSX/CI system I noticed that the
framework misses GMP, without pointing it out to the user as a required
package!
Do you have the CMake output from the earlier build?
On July 15, 2014, 1:01 a.m., Aleix Pol Gonzalez wrote:
Can we get some advertisement about why Atlas is better?
/me wants numbers. Faster? Less memory consumption?
it means we have one texture instead of many and that reduces state changes
which is always a good thing in OpenGL. Tried
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119280/#review62370
---
The code is GPLv2+ - is that allowed in frameworks?
- Martin
43 matches
Mail list logo
