Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

2014-08-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/#review64423 --- I agree that further features should be developed in

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Jonathan Riddell
On July 15, 2014, 5:37 a.m., Martin Gräßlin wrote: The code is GPLv2+ - is that allowed in frameworks? Yes. From licence policy: Source files that are part of a library with a public API which is part of the KDE Platform but a kcm isn't part of a public API - Jonathan

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
On July 15, 2014, 6:27 a.m., Kevin Ottens wrote: Note that as mentioned in the Web Shortcuts KCM thread, I'm very much not in favor of such a code move. kde-frameworks-devel ended up discussing this extensively and in the end things seemed to settle on it's a go -- David, can I get a

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
On July 15, 2014, 5:37 a.m., Martin Gräßlin wrote: The code is GPLv2+ - is that allowed in frameworks? Jonathan Riddell wrote: Yes. From licence policy: Source files that are part of a library with a public API which is part of the KDE Platform but a kcm isn't part of a public

Re: KUnitConversion

2014-08-13 Thread Garret Wassermann
I'm the maintainer for KUnitConversion, you can find the maintainer in the metainfo.yaml file in each Framework repo [aside: perhaps we need to generate a page with this listed?]. I'm also the person looking at KStandards, or KCodes as I'm now calling it. For now KCodes will be sticking to

Re: kcoreaddons fails to build properly on OSX/CI (was OSX/CI: kauth fails to build )

2014-08-13 Thread Aleix Pol
On Wed, Aug 13, 2014 at 7:22 AM, Marko Käning mk-li...@email.de wrote: Hi Aleix, On 13 Aug 2014, at 02:01 , Aleix Pol aleix...@kde.org wrote: Here KCoreAddons installs much more things! http://paste.kde.org/pa4xgdehw well, that list coincides with what I was used up to now... So,

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119280/#review64436 --- src/kcms/webshortcuts/main.cpp

Review Request 119755: Support more number types in haskell highlighting

2014-08-13 Thread Bastian Holst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119755/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
On Aug. 13, 2014, 8:58 a.m., David Faure wrote: So I just realized I screwed up last week-ish and actually pushed this into kio.git already when I pushed the KFPG/KAVA fixes -- I didn't realize I had this on the same branch. I'll do the fixes asked for below and reply with the commit

Re: Review Request 119755: Support more number types in haskell highlighting

2014-08-13 Thread Bastian Holst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119755/ --- (Updated Aug. 13, 2014, 9:18 vorm.) Review request for KDE Frameworks

Re: Breeze widget style for KF5

2014-08-13 Thread Milian Wolff
On Tuesday 12 August 2014 23:34:40 Àlex Fiestas wrote: On Monday 11 August 2014 12:51:21 Milian Wolff wrote: a) what's the advantage of having a native widget style, compared to using QtCurve settings? Are there things missing / not implementable in QtCurve? We did some rought tests and

Re: Review Request 119280: Add the Web Shortcuts KCM from kde-baseapps/konq to the KIO framework

2014-08-13 Thread Eike Hein
On Aug. 13, 2014, 8:58 a.m., David Faure wrote: src/kcms/webshortcuts/main.cpp, line 112 https://git.reviewboard.kde.org/r/119280/diff/2/?file=290236#file290236line112 The indentation seems wrong. Can you run astyle-kdelibs on the whole thing? It will also remove these pesky

Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Denis Steckelmacher
Hi, Yesterday, api.kde.org has been updated so that it displays a bit more information about the frameworks, including code snippets telling the user how to add a framework to his/her CMakeLists.txt or .pro file. In order to display accurate information and because some frameworks have

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #90

2014-08-13 Thread KDE CI System
See http://build.kde.org/job/kwindowsystem_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

New i18n fields in projects.kde.org

2014-08-13 Thread Albert Astals Cid
Hi everybody, projects.kde.org has just got 2 new fields to declare i18n branches, now we have i18n trunk branch (kdelibs4) i18n stable branch (kdelibs4) i18n trunk branch (KF5) i18n stable branch (KF5) Please set those accordingly in your projects to help scripty and other scripts that have

Re: Breeze widget style for KF5

2014-08-13 Thread Hugo Pereira Da Costa
On 08/12/2014 11:34 PM, Àlex Fiestas wrote: On Monday 11 August 2014 12:51:21 Milian Wolff wrote: a) what's the advantage of having a native widget style, compared to using QtCurve settings? Are there things missing / not implementable in QtCurve? We did some rought tests and QtCurve was

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Kevin Ottens
Hello, On Wednesday 13 August 2014 11:30:48 Denis Steckelmacher wrote: Yesterday, api.kde.org has been updated so that it displays a bit more information about the frameworks, including code snippets telling the user how to add a framework to his/her CMakeLists.txt or .pro file. In order to

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Luigi Toscano
On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote: Hi, Yesterday, api.kde.org has been updated so that it displays a bit more information about the frameworks, including code snippets telling the user how to add a framework to his/her CMakeLists.txt or .pro file. How is the

Re: Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

2014-08-13 Thread Andreas Xavier
On Aug. 13, 2014, 7:47 a.m., David Faure wrote: src/lib/io/kautosavefile.h, line 49 https://git.reviewboard.kde.org/r/119530/diff/2/?file=303879#file303879line49 To me kautosavefile was about the KOffice/Calligra use case: saving into a temp file in order to recover the stuff

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Denis Steckelmacher
On 08/13/2014 12:14 PM, Luigi Toscano wrote: On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote: Hi, Yesterday, api.kde.org has been updated so that it displays a bit more information about the frameworks, including code snippets telling the user how to add a framework to

Re: KDE Frameworks 2014 Sprint Dot Article missing

2014-08-13 Thread Jonathan Riddell
¡así! https://dot.kde.org/2014/08/13/kde-frameworks-sprint-how-release-platform Jonathan On 28 July 2014 00:48, Albert Astals Cid aa...@kde.org wrote: Hi guys, please note that the Dot Article of the KDE Frameworks 2014 Sprint is missing. Can someone of the guys that was there write

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Aleix Pol
On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher steckde...@yahoo.fr wrote: On 08/13/2014 12:14 PM, Luigi Toscano wrote: On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote: Hi, Yesterday, api.kde.org has been updated so that it displays a bit more information about the

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Albert Astals Cid
El Dimecres, 13 d'agost de 2014, a les 14:20:58, Aleix Pol va escriure: On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher steckde...@yahoo.fr wrote: On 08/13/2014 12:14 PM, Luigi Toscano wrote: On Wednesday 13 of August 2014 11:30:48 Denis Steckelmacher wrote: Hi, Yesterday,

Re: KUnitConversion

2014-08-13 Thread David Narvaez
On Wed, Aug 13, 2014 at 1:46 AM, Garret Wassermann gwas...@gmail.com wrote: A library that allows one to define new derived units in terms of base units and register them with the library would be really cool. it could be useful for anyone no matter how specialized the field, rather than

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

2014-08-13 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119736/#review64464 --- Ship it! \o/ Thanks Nicolas :) - Rohan Garg On Aug. 12,

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

2014-08-13 Thread Albert Astals Cid
On ago. 13, 2014, 12:54 p.m., Rohan Garg wrote: \o/ Thanks Nicolas :) Is doxygen smart enough to read the .md? - Albert --- This is an automatically generated e-mail. To reply, visit:

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Kevin Ottens
On Wednesday 13 August 2014 14:20:58 Aleix Pol wrote: On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher steckde...@yahoo.fr The e-mail is currently generated by appending @kde.org after the maintainer name. If this is not correct, you can put a full e-mail address in maintainer and it

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

2014-08-13 Thread Rohan Garg
On Aug. 13, 2014, 6:24 p.m., Rohan Garg wrote: \o/ Thanks Nicolas :) Albert Astals Cid wrote: Is doxygen smart enough to read the .md? Yep, atleast the version I have can read .md, @Nicolas does the doxygen version on api.kde.org handle .md files? - Rohan

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Denis Steckelmacher
On 08/13/2014 02:41 PM, Albert Astals Cid wrote: El Dimecres, 13 d'agost de 2014, a les 14:20:58, Aleix Pol va escriure: On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher steckde...@yahoo.fr wrote: On 08/13/2014 12:14 PM, Luigi Toscano wrote: On Wednesday 13 of August 2014 11:30:48 Denis

Re: Review Request 119736: Convert the ki18n programmers' guide to Markdown

2014-08-13 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119736/ --- (Updated Aug. 13, 2014, 4:19 p.m.) Status -- This change has been

Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-08-13 Thread Bastian Holst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119767/ --- Review request for Kate, KDE Frameworks and Christoph Cullmann.

Re: Review Request 119755: Support more number types in haskell highlighting

2014-08-13 Thread Bastian Holst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119755/ --- (Updated Aug. 13, 2014, 4:33 nachm.) Review request for Kate, KDE

Re: Review Request 119767: Add Hamlet and Haskell quasiquotation

2014-08-13 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119767/#review64497 --- src/syntax/data/hamlet.xml

Re: Review Request 119755: Support more number types in haskell highlighting

2014-08-13 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119755/#review64499 --- Ship it! Patch looks good, but please increase the version

Review Request 119773: Launch scripts in autostart-directories

2014-08-13 Thread Martin Yrjölä
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119773/ --- Review request for KDE Frameworks. Bugs: 335878 and 338242

Re: Review Request 119698: Save radio button index in QGroupBox that are composed only by radio buttons

2014-08-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119698/ --- (Updated Aug. 13, 2014, 8:53 p.m.) Status -- This change has been

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

2014-08-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/ --- (Updated ago. 13, 2014, 8:55 p.m.) Review request for KDE Frameworks.

Review Request 119777: Make KFontUtils::adaptFontSize be a bit more exact

2014-08-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119777/ --- Review request for KDE Frameworks. Repository: kguiaddons Description

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-13 Thread Ben Cooksley
On Thu, Aug 14, 2014 at 3:16 AM, Denis Steckelmacher steckde...@yahoo.fr wrote: On 08/13/2014 02:41 PM, Albert Astals Cid wrote: El Dimecres, 13 d'agost de 2014, a les 14:20:58, Aleix Pol va escriure: On Wed, Aug 13, 2014 at 12:29 PM, Denis Steckelmacher steckde...@yahoo.fr wrote: On