Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review65111 --- With the port the checkbox no longer scales with dpi. The PM

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-24 Thread David Edmundson
On Aug. 24, 2014, 9:53 a.m., Kai Uwe Broulik wrote: With the port the checkbox no longer scales with dpi. The PM checkbox in battery monitor has become quite small here now. the width/height looks like it has changed, it used to be width: theme.mSize(theme.defaultFont).height +

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-08-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Aug. 24, 2014, 12:13 p.m.) Status -- This change has been

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-08-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Aug. 24, 2014, 12:13 p.m.) Status -- This change has been

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

2014-08-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Aug. 24, 2014, 12:13 p.m.) Status -- This change has been

Re: Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

2014-08-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119356/ --- (Updated Aug. 24, 2014, 2:14 nachm.) Review request for KDE Frameworks.

need flyer content and design for Qt DevDays

2014-08-24 Thread Lydia Pintscher
Hey folks :) Qt DevDays is coming up and we have the opportunity to add a flyer to the welcome bag. I think we should do this. It should be a flyer about Frameworks 5. Ideally we can re-use the same flyer later for other events like FOSDEM. It should be no bigger than A4 but imho half that size

OSX/CI: building libkdcraw fails on branch frameworks

2014-08-24 Thread Marko Käning
In file included from /Users/marko/WC/KDECI-builds/libkdcraw/src/ractionthreadbase_p.cpp:28: /Users/marko/WC/KDECI-builds/libkdcraw/src/ractionthreadbase_p.h:40:10: fatal error: 'threadweaver/WeaverObserver.h' file not found #include threadweaver/WeaverObserver.h ^ 5 warnings generated.

Re: Kioslave repos

2014-08-24 Thread Aleix Pol
On Wed, Aug 20, 2014 at 12:48 PM, Luigi Toscano luigi.tosc...@tiscali.it wrote: On Wednesday 20 of August 2014 11:38:12 Jonathan Riddell wrote: On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday

Re: Kioslave repos

2014-08-24 Thread Marko Käning
On 24 Aug 2014, at 23:48 , Aleix Pol aleix...@kde.org wrote: Hm, fair enough. How does it sound to make kio-extras a framework then? It doesn't add new API but it does add run-time functionality to the applications. Oh, I thought kio-extras IS a framework already…

Build failed in Jenkins: kcmutils_master_qt5 #74

2014-08-24 Thread KDE CI System
See http://build.kde.org/job/kcmutils_master_qt5/74/changes Changes: [faure] Fix nonsensical default value. The config file for konqueror is konquerorrc. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

2014-08-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/#review65157 --- Changing the theme for everyone using kconfigwidgets would

Re: Kioslave repos

2014-08-24 Thread Marko Käning
On 24 Aug 2014, at 23:54 , Aleix Pol aleix...@kde.org wrote: On Sun, Aug 24, 2014 at 11:51 PM, Marko Käning mk-li...@email.de wrote: On 24 Aug 2014, at 23:48 , Aleix Pol aleix...@kde.org wrote: Hm, fair enough. How does it sound to make kio-extras a framework then? It doesn't add new API

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

2014-08-24 Thread Albert Astals Cid
On ago. 24, 2014, 9:56 p.m., Aleix Pol Gonzalez wrote: Changing the theme for everyone using kconfigwidgets would break integration quite a bit, wouldn't it be possible to set it as fallback? Break integration with what? It only changes the theme if it's empty and hicolor, because if

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

2014-08-24 Thread Aleix Pol Gonzalez
On Aug. 24, 2014, 9:56 p.m., Aleix Pol Gonzalez wrote: Changing the theme for everyone using kconfigwidgets would break integration quite a bit, wouldn't it be possible to set it as fallback? Albert Astals Cid wrote: Break integration with what? It only changes the theme

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

2014-08-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/#review65160 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 13, 2014,

Re: OSX/CI: ?NEW? qt5 build failure !!!

2014-08-24 Thread Marko Käning
When I tried to build a recent qt5 using cmake version 3.0.20140603-g0ee11 I’ve seen this error again: On 12 Aug 2014, at 20:22 , Marko Käning mk-li...@email.de wrote: Undefined symbols for architecture x86_64: QMacTimeZonePrivate::QMacTimeZonePrivate(QByteArray const), referenced from: