Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-09 Thread Denis Steckelmacher
On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: What is the status of this? Is there anything blocking it being shipped and made available on api.kde.org? It works locally, so I'm just waiting for a ship-it or other comments :-) - Denis

Re: OSX/CI: bovo fails to build on branch frameworks

2014-09-09 Thread Albert Astals Cid
El Dimarts, 9 de setembre de 2014, a les 07:09:40, Marko Käning va escriure: I’ve tried to build a KDE game as a little test horse for the OSX/CI system and ran into the problem that KDEGames cannot be found. What am I missing? libkdegames Albert --- -- Found KF5: success (found

Removing border and background from KPageView

2014-09-09 Thread Anton Kreuzkamp
Hi, on the VDG forum there has been a discussion about improving the design of sidebars (https://forum.kde.org/viewtopic.php?f=285t=120006). Meant are the sidebars that allow navigating between application pages, namely KPageView. The idea is to remove the border and the white background, so

Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Removing border and background from KPageView

2014-09-09 Thread Albert Astals Cid
El Dilluns, 8 de setembre de 2014, a les 23:31:52, Anton Kreuzkamp va escriure: Hi, on the VDG forum there has been a discussion about improving the design of sidebars (https://forum.kde.org/viewtopic.php?f=285t=120006). Meant are the sidebars that allow navigating between application

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/#review66098 --- src/declarativeimports/core/datasource.cpp

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- (Updated Sept. 9, 2014, 9:14 vorm.) Review request for KDE Frameworks.

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
On Sept. 8, 2014, 11:24 vorm., Milian Wolff wrote: src/k7zip.cpp, line 1509 https://git.reviewboard.kde.org/r/120096/diff/1/?file=310286#file310286line1509 this could be a QByteArray directly, and again resize it, not reserve. Should I also move the encodedBuffer out of the loop to

Re: Removing border and background from KPageView

2014-09-09 Thread Christoph Feck
On Tuesday 09 September 2014 10:33:22 Albert Astals Cid wrote: El Dilluns, 8 de setembre de 2014, a les 23:31:52, Anton Kreuzkamp va escriure: Hi, on the VDG forum there has been a discussion about improving the design of sidebars

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/#review66107 --- src/declarativeimports/core/datasource.cpp

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66110 --- Ship it! looks good from my side, but david should have a

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- (Updated Sept. 9, 2014, 10:19 a.m.) Review request for KDE Frameworks

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
On Sept. 9, 2014, 9:04 vorm., David Edmundson wrote: src/declarativeimports/core/datasource.cpp, line 171 https://git.reviewboard.kde.org/r/120110/diff/1/?file=310511#file310511line171 Nice work identifying the cause, but I think we can improve the fix. We were calling

Re: Removing border and background from KPageView

2014-09-09 Thread Hugo Pereira Da Costa
On 09/09/2014 12:16 PM, Christoph Feck wrote: On Tuesday 09 September 2014 10:33:22 Albert Astals Cid wrote: El Dilluns, 8 de setembre de 2014, a les 23:31:52, Anton Kreuzkamp va escriure: Hi, on the VDG forum there has been a discussion about improving the design of

Re: Removing border and background from KPageView

2014-09-09 Thread Christoph Feck
On Tuesday 09 September 2014 12:37:12 Hugo Pereira Da Costa wrote: On 09/09/2014 12:16 PM, Christoph Feck wrote: On Tuesday 09 September 2014 10:33:22 Albert Astals Cid wrote: El Dilluns, 8 de setembre de 2014, a les 23:31:52, Anton Kreuzkamp va escriure: Hi,

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread David Edmundson
On Sept. 9, 2014, 9:04 a.m., David Edmundson wrote: src/declarativeimports/core/datasource.cpp, line 171 https://git.reviewboard.kde.org/r/120110/diff/1/?file=310511#file310511line171 Nice work identifying the cause, but I think we can improve the fix. We were calling

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- (Updated Sept. 9, 2014, 11:48 vorm.) Review request for KDE Frameworks

Re: Review Request 120110: Fix a crash when shutting down plasma shell, while destruction models

2014-09-09 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120110/ --- (Updated Sept. 9, 2014, 11:49 vorm.) Status -- This change has been

Build failed in Jenkins: knotifications_master_qt5 #99

2014-09-09 Thread KDE CI System
See http://build.kde.org/job/knotifications_master_qt5/99/changes Changes: [allan.jensen] Let QImage do the conversion instead of doing it manually -- [...truncated 27 lines...] git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10

Jenkins build is back to normal : knotifications_master_qt5 #100

2014-09-09 Thread KDE CI System
See http://build.kde.org/job/knotifications_master_qt5/100/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66124 --- Ship it! Ship It! - David Faure On Sept. 9, 2014, 10:19

KDE Frameworks 5.2.0 release

2014-09-09 Thread David Faure
I just tagged and packed 5.2.0. I extracted the following changelog items from git commits. But I don't really understand the plasma-framework and threadweaver commits Mirko and Plasma people: can you tell me the relevant changes ? Hint: `git log v5.1.0..` = * KIO/KService: now

Re: There's no proper replacement for KIcon

2014-09-09 Thread Kevin Krammer
On Sunday, 2014-09-07, 10:27:06, Albert Astals Cid wrote: So as I see it, there's three options: * Do nothing, and expect that people have to set one of XDG_CURRENT_DESKTOP, KDE_FULL_SESSION, GNOME_DESKTOP_SESSION_ID or DESKTOP_SESSION environment variables to get icons * Do the

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
On Sept. 7, 2014, 1:48 nachm., David Edmundson wrote: I've just added kdeframeworks to the review group in case they have comments. Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject and that's a BIC, right? - Kai Uwe

Re: Review Request 119958: Fix thumbnails for mimetype groups.

2014-09-09 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119958/ --- (Updated Sept. 9, 2014, 3:05 p.m.) Status -- This change has been

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-09 Thread Carl Symons
On 09/09/2014 06:57 AM, David Faure wrote: I just tagged and packed 5.2.0. I extracted the following changelog items from git commits. But I don't really understand the plasma-framework and threadweaver commits Mirko and Plasma people: can you tell me the relevant changes ? Hint: `git

Re: kio_trash

2014-09-09 Thread David Faure
On Sunday 17 August 2014 00:03:41 David Faure wrote: kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, support for trash in FileUndoManager, and I'm about to add a KIO::restoreFromTrash job).

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread David Edmundson
On Sept. 7, 2014, 1:48 p.m., David Edmundson wrote: I've just added kdeframeworks to the review group in case they have comments. Kai Uwe Broulik wrote: Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject and that's a BIC, right?

Retiring and testament

2014-09-09 Thread Kevin Ottens
Hello dear KDE contributors, I'm sending this from Akademy 2014. Our KDE Frameworks BoF is now over, as usual we did great progress: https://community.kde.org/Frameworks/Meetings/201409Akademy Also I put in place the goals for the months to come before coming:

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 9, 2014, 3:50 p.m.) Status -- This change has been

Review Request 120118: Make code coverage possible in any KDE project

2014-09-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120118/ --- Review request for Build System and KDE Frameworks. Repository:

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-09 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review66143 --- Ship it! Ship It! - Alex Merry On Sept. 7, 2014, 7:57

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66153 --- src/k7zip.cpp

OSX/CI: libkdegames fails to build on branch frameworks

2014-09-09 Thread Marko Käning
Automatic moc for target kgamepropertytest AUTOGEN: error: /Users/marko/WC/KDECI-builds/libkdegames/audio/kgsound-phonon.cpp: The file includes the moc file kgsound.moc, which seems to be the moc file from a different source file. This is not supported. Include kgsound-phonon.moc to run moc on

Re: OSX/CI: bovo fails to build on branch frameworks

2014-09-09 Thread Marko Käning
Hi Albert and Ian, On 09 Sep 2014, at 10:05 , Albert Astals Cid aa...@kde.org wrote: El Dimarts, 9 de setembre de 2014, a les 07:09:40, Marko Käning va escriure: I’ve tried to build a KDE game as a little test horse for the OSX/CI system and ran into the problem that KDEGames cannot be found.

Re: OSX/CI: kate uses invalid category

2014-09-09 Thread Dominik Haumann
On Sunday, September 07, 2014 05:57:30 PM Marko Käning wrote: On 07 Sep 2014, at 13:34 , Dominik Haumann dhaum...@kde.org wrote: On Saturday, September 06, 2014 02:54:04 PM Marko Käning wrote: When building kate I suddenly see tons of these warnings popping up: Rename to *-apps-*.png. Can

Jenkins build became unstable: ktexteditor_master_qt5 #628

2014-09-09 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/628/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: bovo fails to build on branch frameworks

2014-09-09 Thread Marko Käning
Thanks to Ian (!!!) it could be clarified that libsndfile and openal is needed to build libkdegames. While openal is provided by OSX, libsndfile needs to be installed via MacPorts. --- BUT, now here stuck here: --- Building CXX object CMakeFiles/bovo.dir/gui/mainwindow.cc.o

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-09-09 Thread David Faure
On Sept. 5, 2014, 10:08 p.m., David Faure wrote: Ah wait, I do: lots of @since 5.2 missing in api docs. And a [ChangeLog] entry like in Qt in the commit log, although I haven't written/stolen the script to extract that yet. Err, I mean CHANGELOG: -- we probably want to keep

Re: Review Request 120071: QUrl::fromUserInput in kfilewidget

2014-09-09 Thread David Faure
On Sept. 5, 2014, 10:14 p.m., David Faure wrote: Ship It! I reworked this code today, to fix other issues (fromUserInput is wrong for relative paths, which affected at least other parts of the code). Can you check that it's still working for you? Thanks. - David