Build failed in Jenkins: kdelibs4support_master_qt5 #271

2014-09-14 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 120208: Link to setWindowModified documentation

2014-09-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120208/ --- (Updated Sept. 14, 2014, 10 p.m.) Status -- This change has been mar

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-14 Thread Mark Gaiser
> On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644 > > --- a/src/urifilters/shorturi/ks

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-14 Thread Alexander Richardson
> On Sept. 14, 2014, 2:26 nachm., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644 > > --- a/src/urifilters/shorturi

Re: Review Request 120208: Link to setWindowModified documentation

2014-09-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120208/#review66498 --- src/kdeui/kdialog.h

Re: Review Request 120208: Link to setWindowModified documentation

2014-09-14 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120208/#review66497 --- Ship it! Ship It! - Milian Wolff On Sept. 14, 2014, 9:23 p

Review Request 120208: Link to setWindowModified documentation

2014-09-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120208/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 119607: Support for ".hidden" files

2014-09-14 Thread Bruno Nova
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.cpp, line 2801 > > > > > > I think that you can remove this line. > > Bruno Nova wrote: > Oops, forgot to remove `QString`

Re: Review Request 119607: Support for ".hidden" files

2014-09-14 Thread Bruno Nova
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Set. 14, 2014, 7:32 p.m.) Review request for KDE Frameworks and

Re: Review Request 119607: Support for ".hidden" files

2014-09-14 Thread Bruno Nova
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.cpp, line 1218 > > > > > > const What do you mean? `filesToHide` should be `const`? (I thought I had added this comment before

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2014-09-14 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66489 --- All in all, the patch looks good, but it misses emitting the s

Re: Translations in frameworks released tarballs

2014-09-14 Thread David Faure
On Sunday 14 September 2014 18:07:19 Chusslove Illich wrote: > > [: Christoph Feck :] > > with the 5.2 release, the bug that unneeded translations are packaged into > > each tarball is back in a different form. Now, a "scripts" folder is > > inside each po/ subfolder, with redundant translations. >

Re: OSX/CI: plasmate fails to build on branch frameworks

2014-09-14 Thread Marko Käning
On 14 Sep 2014, at 16:24 , Marko Käning wrote: > Linux/CI hang, because there was a missing dependency to kdevplatform. > This has been fixed by now, but Jenkins master hasn’t picked up the dependency > change yet. After two hours I triggered another rebuild, which pulled the corrected deps in an

Re: Translations in frameworks released tarballs

2014-09-14 Thread Chusslove Illich
> [: Christoph Feck :] > with the 5.2 release, the bug that unneeded translations are packaged into > each tarball is back in a different form. Now, a "scripts" folder is > inside each po/ subfolder, with redundant translations. > > Does not happen on every archive, but on many of them. Happens on

Re: Review Request 119607: Support for ".hidden" files

2014-09-14 Thread Bruno Nova
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > I've added some comments inline. You should wait for David's feedback > > though. > > > > BTW, do other platforms, which support ".hidden" files already, only > > support full file names in that file, or can you add wildcards (such as

Re: Review Request 119607: Support for ".hidden" files

2014-09-14 Thread Bruno Nova
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Set. 14, 2014, 3:32 p.m.) Review request for KDE Frameworks and

Re: Review Request 120200: Only create one instance of defaultExecutor.

2014-09-14 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120200/#review66473 --- Ship it! Ouch, nice catch! - Milian Wolff On Sept. 14, 201

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #95

2014-09-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120200: Only create one instance of defaultExecutor.

2014-09-14 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120200/ --- Review request for KDE Frameworks. Repository: threadweaver Description

OSX/CI: plasmate fails to build on branch frameworks

2014-09-14 Thread Marko Käning
Linux/CI hang, because there was a missing dependency to kdevplatform. This has been fixed by now, but Jenkins master hasn’t picked up the dependency change yet. On OSX/CI the project fails here: --- [ 97%] Building CXX object plasmate/CMakeFiles/plasmate.dir/app/plasmateapp.cpp.o [ 98%] Buildi

Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

2014-09-14 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

2014-09-14 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Translations in frameworks released tarballs

2014-09-14 Thread Christoph Feck
Hi, with the 5.2 release, the bug that unneeded translations are packaged into each tarball is back in a different form. Now, a "scripts" folder is inside each po/ subfolder, with redundant translations. Does not happen on every archive, but on many of them. Just pick an archive that is around

OSX/CI: kdepimlibs fails to build on branch master

2014-09-14 Thread Marko Käning
Turns out that boost can’t be located properly, although it is installed. BTW, kdevplatform make extensive use of boost and has NO problem finding it. --- In file included from /Users/marko/WC/KDECI-builds/kdepimlibs/build/syndication/src/syndication/syndication/elementwrapper.h:1: /Users/marko/

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-09-14 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- (Updated Sept. 14, 2014, 1:44 p.m.) Status -- This change has been m

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

2014-09-14 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Sept. 14, 2014, 1:34 p.m.) Status -- This change has been m

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-14 Thread Mark Gaiser
> On sep 14, 2014, 12:26 p.m., Mark Gaiser wrote: > > My attempt at this. Feel free to use it as you see fit. > > > > diff --git a/src/urifilters/shorturi/kshorturifilter.cpp > > b/src/urifilters/shorturi/kshorturifilter.cpp > > index 00668d9..6c35393 100644 > > --- a/src/urifilters/shorturi/ks

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120138/#review66454 --- My attempt at this. Feel free to use it as you see fit. diff

Review Request 120196: Find-Module to detect libgit2

2014-09-14 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-14 Thread Ben Cooksley
On Sun, Sep 14, 2014 at 4:42 PM, Matthew Dawson wrote: > On September 12, 2014 03:19:13 AM Ben Cooksley wrote: >> > On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: >> > Matthew Dawson wrote: >> > I don't think upstream would be happy with the patch, as it hijacks >> > the moderator email

Jenkins build is back to stable : kio_master_qt5 #355

2014-09-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel