Re: Review Request 119777: Make KFontUtils::adaptFontSize be a bit more exact

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119777/ --- (Updated Sept. 18, 2014, 9:43 p.m.) Status -- This change has been m

Re: Review Request 114933: KF5 Port of kdeui/kmessagewidgetdemo

> On Aug. 12, 2014, 9:33 a.m., Aleix Pol Gonzalez wrote: > > After some discussion with the SDK and Book groups in the sprint, I think > > we should move this into the kde:kwidgetsaddons repository, in an examples > > subdirectory. > > Laurent Navet wrote: > do you want me to move this fro

Re: Review Request 119777: Make KFontUtils::adaptFontSize be a bit more exact

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119777/#review66879 --- Ship it! No feedback => commit it :) - Christoph Feck On A

Re: Review Request 120142: correct documentation for overlays parameter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120142/ --- (Updated Sept. 18, 2014, 9:14 p.m.) Status -- This change has been m

Re: Review Request 119607: Support for ".hidden" files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/#review66872 --- Wait? I was _really_ expecting the .hidden file to support pat

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66871 --- I would really like to hear Aurelien's opinion, but maybe you

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

> On Sept. 18, 2014, 8:52 p.m., Christoph Feck wrote: > > src/kmessagewidget.cpp, line 412 > > > > > > Would it make sense to emit hideAnimationFinished() before reversing > > the direction to "showing"? Likewis

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66869 --- src/kmessagewidget.cpp

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/ --- (Updated Sept. 18, 2014, 8:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

> On Sept. 12, 2014, 10:49 a.m., Christoph Feck wrote: > > Use KPixmapSequence if you need to access an FDO animation icon. > > Dan Vrátil wrote: > That's the thing: I want to feed the animation icon to KPixmapSequence, > but KPixmapSequence only accepts full file path, or QPixmap. And I ca

Review Request 120267: Don't run kioexec if we are already running it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120267/ --- Review request for KDE Frameworks and David Faure. Bugs: 339123 https

Re: Review Request 120257: Add support for initial mapping state of WM_HINTS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120257/#review66844 --- Ship it! src/netwm_def.h

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

> On Sept. 14, 2014, 6:33 p.m., Dominik Haumann wrote: > > All in all, the patch looks good, but it misses emitting the signals > > hideAnimationFinished() and showAnimationFinished(). > > Why? Without your patch, you can be *sure* that after calling show() or > > animatedShow() the signal show

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #104

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Minimum compiler versions

2014-09-17 14:12 GMT-03:00 Nicolás Alvarez : > If we'll keep the compiler requirements as-is, I volunteer to fix > what's broken in the minimum versions we claim to support. But I think > we need CI for gcc 4.5, otherwise it will keep breaking... Okay, that wasn't so hard. KF5 now compiles with g

Re: Non-coinstallable frameworks

On Thursday 18 September 2014 13:15:51 Aleix Pol wrote: > Hi Ivan, > I've just learned that the KActivities framework is not co-installable with > kdelibs4. > > We should fix that in a way or another, this makes the whole > plasma-framework (or anything else depending on KActivities) not > co-inst

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66825 --- Ship it! some more nitpickery from my side, but otherwise thi

Non-coinstallable frameworks

Hi Ivan, I've just learned that the KActivities framework is not co-installable with kdelibs4. We should fix that in a way or another, this makes the whole plasma-framework (or anything else depending on KActivities) not co-installable as well, which is quite bad as some applications still need it

Re: Review Request 119607: Support for ".hidden" files

> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.cpp, line 1218 > > > > > > const > > Bruno Nova wrote: > What do you mean? `filesToHide` should be `const`? > (I thoug

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

> On Sept. 14, 2014, 6:33 p.m., Dominik Haumann wrote: > > All in all, the patch looks good, but it misses emitting the signals > > hideAnimationFinished() and showAnimationFinished(). > > Why? Without your patch, you can be *sure* that after calling show() or > > animatedShow() the signal show

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/ --- (Updated Sept. 18, 2014, 10:40 a.m.) Review request for KDE Frameworks, C

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

> On Sept. 13, 2014, 3:20 p.m., Milian Wolff wrote: > > autotests/kmessagewidgetautotest.cpp, line 115 > > > > > > Couldn't this actually check that no animation is running at all now? > > We triggered the hide

Re: Review Request 119607: Support for ".hidden" files

> On Set. 17, 2014, 7:59 p.m., David Faure wrote: > > Thanks for the patch. A few comments: > > > > Is there any sort of spec or reference implementation for ".hidden" files? > > Are they supposed to support wildcards, for instance? > > > > Something else, it would be good to add a unittest to

Re: Review Request 119607: Support for ".hidden" files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/ --- (Updated Set. 18, 2014, 10:06 a.m.) Review request for KDE Frameworks and

Re: What's "qt5-stable" on build.kde.org

On Thu, Sep 18, 2014 at 9:30 PM, Jan Kundrát wrote: > On Thursday, 18 September 2014 10:10:41 CEST, Ben Cooksley wrote: >> >> This would still apply even after the implementation of new scheme for >> dependencies and other build metadata. > > > Where do I learn about these new features? See the m

Re: What's "qt5-stable" on build.kde.org

On Thursday, 18 September 2014 10:10:41 CEST, Ben Cooksley wrote: This would still apply even after the implementation of new scheme for dependencies and other build metadata. Where do I learn about these new features? Cheers, Jan -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.fla

Re: What's "qt5-stable" on build.kde.org

On Thu, Sep 18, 2014 at 6:04 PM, Marko Käning wrote: > On 18 Sep 2014, at 07:52 , Martin Gräßlin wrote: >> That's not what I meant. I mean we have things like frameworks which require >> only Qt 5.2, but we also have things like e.g. KWin requiring Qt 5.3 (soon >> 5.4). This will require two Qt b

Review Request 120257: Add support for initial mapping state of WM_HINTS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120257/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D