Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76203 --- +1 Looks good to me. - Aleix Pol Gonzalez On Feb. 8, 2015,

Re: Review Request 122462: [KCompletion] Fix typos in documentation

2015-02-17 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122462/#review76202 --- Ping? - David Gil Oliva On feb. 8, 2015, 10:46 p.m., David

Build failed in Jenkins: kde-baseapps_master_qt5 #241

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/kde-baseapps_master_qt5/241/changes Changes: [andreas.sturmlechner] Make tests optional -- [...truncated 2663 lines...] ^

Re: Review Request 122549: Avoid code path that leaves local config files locked

2015-02-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76212 --- bump? - David Edmundson On Feb. 12, 2015, 9:34 p.m., David

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-17 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76186 --- Ship it! src/knotifyconfigelement.h

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #1007

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/1007/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

2015-02-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76195 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 17, 2015,

Re: Review request: QBluez

2015-02-17 Thread David Rosca
Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? Also tried to run the tests and qbluez-managertest seems to get stuck forever. Does it

Making prison a framework

2015-02-17 Thread Sune Vuorela
Hi The KDESupport library, libprison, a bar code rendering abstraction layer could be heading forward for the first release of a qt5, widgets free version. People also suggesting to make it a framework. So please, take a look at kde:prison and let's try to get it reviewed for frameworks /Sune

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

2015-02-17 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/ --- (Updated Feb. 17, 2015, 2:51 p.m.) Review request for KDE Frameworks,

Review Request 122606: Fix startup of kssld5 dbus service

2015-02-17 Thread Bartosz Sławianowski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122606/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554/#review76184 --- Ship it! i'm not 100% sure on the issue below, apart from

Re: KPeople part of KDE Frameworks

2015-02-17 Thread Aleix Pol
On Tue, Feb 17, 2015 at 7:56 PM, Albert Astals Cid aa...@kde.org wrote: El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure: Hi, I would like to submit KPeople for review process so it can join the KF5 family in the next 5.8 release. KPeople is a tier 3 framework

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #1008

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/1008/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdelibs4support_master_qt5 #329

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/kdelibs4support_master_qt5/329/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KPeople part of KDE Frameworks

2015-02-17 Thread Albert Astals Cid
El Divendres, 13 de febrer de 2015, a les 14:25:33, Aleix Pol va escriure: Hi, I would like to submit KPeople for review process so it can join the KF5 family in the next 5.8 release. KPeople is a tier 3 framework (because of KService, which will be dropped eventually, without breaking ABI)

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-02-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/#review76177 --- src/currency.cpp

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2015-02-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- (Updated Feb. 17, 2015, 11:22 a.m.) Review request for KDE Frameworks.

Re: Review Request 122608: Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback

2015-02-17 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76197 --- Oh, cool. I hope it does not cause a slowdown. Can someone

Re: Review request: QBluez

2015-02-17 Thread Albert Astals Cid
El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. I see. What about renaming it to BluezQt? That would

Jenkins build is back to normal : kconfig_stable_qt5 #22

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/kconfig_stable_qt5/22/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review request: QBluez

2015-02-17 Thread David Rosca
That would work i guess, note it's not only about the project name, but also about the class names. Sure. But i get two others to fail Any idea? Hmm, I would say that it is actually expected to fail if there is an error when calling GetManagedObjects on org.freedesktop.DBus.ObjectManager.

Re: Review Request 121447: Return inode/directory when isDir returns true (kfileitem)

2015-02-17 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121447/ --- (Updated Feb. 17, 2015, 9:43 p.m.) Status -- This change has been

Re: Review request: QBluez

2015-02-17 Thread Albert Astals Cid
El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: That would work i guess, note it's not only about the project name, but also about the class names. Sure. But i get two others to fail Any idea? Hmm, I would say that it is actually expected to fail if there

Re: Review request: QBluez

2015-02-17 Thread David Rosca
Well, then the test should try to detect it and QEXPECT_FAIL, havign tests fail means something is bad, and as you say it's not bad, just expected. I meant it's expected to fail in the case that something goes wrong when initializing Manager. And that is, for example, the case with running

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #1009

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/1009/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122613: Do not add an extra slash if item does not have a host (KUrlComboBoxPrivate::textForItem)

2015-02-17 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122613/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: kio and scheme://

2015-02-17 Thread Àlex Fiestas
Review request to fix this! https://git.reviewboard.kde.org/r/122613/ Thanks for the support guys! On Sun, Nov 2, 2014 at 1:43 PM, Àlex Fiestas afies...@kde.org wrote: Hi there There are quite a few places where the following code is found: if (!url.path().endsWith('/')) {

Review Request 122604: Do not require KSelectionWatcher and KSelectionOwner to be on platform xcb

2015-02-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122604/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #1006

2015-02-17 Thread KDE CI System
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel