Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122751/#review76758 --- Ship it! Ship It! - Jeremy Whiting On Feb. 28, 2015, 3:23

Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

2015-02-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122751/ --- (Updated Feb. 28, 2015, 12:55 p.m.) Status -- This change has been

Review Request 122754: Remove use of KI18N_MODULE_DIR.

2015-02-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122754/ --- Review request for KDE Frameworks and Chusslove Illich. Repository:

Review Request 122751: Let ecm_configure_package_config_file manage path variables.

2015-02-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122751/ --- Review request for Documentation, KDE Frameworks, Luigi Toscano, and

Review Request 122755: Add testcases for KIO::del()

2015-02-28 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 122606: Fix startup of kssld5 dbus service

2015-02-28 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122606/#review76754 --- I'm not acquainted with the codebase, but I can confirm that

Re: Review Request 120649: Encode the URIs which end up in DTD files

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/#review76781 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:13

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-28 Thread Sebastian Kügler
On Dec. 1, 2014, 4:59 p.m., Aleix Pol Gonzalez wrote: Have you checked if the Background Services kded still works after this? Aleix Pol Gonzalez wrote: Sorry, I meant KCM. Alex Richardson wrote: `grep -irn background /kf5-install/share/kservices5/kded` does not give any

Re: Review Request 121317: Add JSON metadata to the kded modules

2015-02-28 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121317/#review76764 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015,

Re: Review Request 122754: Remove use of KI18N_MODULE_DIR.

2015-02-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122754/ --- (Updated Feb. 28, 2015, 1:52 p.m.) Review request for KDE Frameworks and

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-02-28 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review76782 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:12

Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-02-28 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- (Updated Feb. 28, 2015, 10:02 p.m.) Status -- This change has been

Re: Review Request 122755: Add testcases for KIO::del()

2015-02-28 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/ --- (Updated Feb. 28, 2015, 9:21 p.m.) Review request for KDE Frameworks.

Re: Review Request 120649: Encode the URIs which end up in DTD files

2015-02-28 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/ --- (Updated Feb. 28, 2015, 10:05 p.m.) Status -- This change has been

Re: Review Request 122755: Add testcases for KIO::del()

2015-02-28 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review76769 --- Thanks for the test! :) Maybe you can add some negative test

Re: Review Request 122764: Adding missing licenses

2015-02-28 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122764/ --- (Updated Feb. 28, 2015, 7:38 p.m.) Review request for KDE Frameworks.

Review Request 122764: Adding missing licenses

2015-02-28 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122764/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 122755: Add testcases for KIO::del()

2015-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review76790 --- Ship it! Looks good to me, can you push yourself?