Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Albert Astals Cid
El Dissabte, 21 de març de 2015, a les 22:00:11, David Faure va escriure: > On Saturday 21 March 2015 19:18:53 laurent Montel wrote: > > Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit : > > > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va > > escriure: > > > > On

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread David Faure
On Saturday 21 March 2015 19:18:53 laurent Montel wrote: > Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit : > > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va escriure: > > > On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > > > > Am Samstag, 21. März 2015, 11:

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread laurent Montel
Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit : > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va escriure: > > On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > > > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > > > > On March 21, 2015 04:00:11 P

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Albert Astals Cid
El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va escriure: > On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > > > On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > > > > === > > > > KConfig config(QLatin1St

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Mathias Kraus
Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > > === > > KConfig config(QLatin1String("kminesrc")); > > config.reparseConfiguration(); > > === > Sorry, my suggestion of using reparseConfiguration wasn't clear. I meant >

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Matthew Dawson
On March 21, 2015 04:29:25 PM Mathias Kraus wrote: > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson: > > On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > > > === > > > KConfig config(QLatin1String("kminesrc")); > > > config.reparseConfiguration(); > > > === > > > > Sorry, m

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Mathias Kraus
Am Samstag, 21. März 2015, 14:06:03 schrieb David Faure: > On Saturday 21 March 2015 10:16:07 Mathias Kraus wrote: > > Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel: > > > Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > > > > KdePlatformTheme::loadSetting > > > > > > > > T

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Mathias Kraus
Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel: > Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > > KdePlatformTheme::loadSetting > > > > This code runs before the application name is set, but the fallback to > > argv[0] should still work. [This makes me realize that we sho

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread Matthew Dawson
On March 21, 2015 04:00:11 PM Mathias Kraus wrote: > === > KConfig config(QLatin1String("kminesrc")); > config.reparseConfiguration(); > === Sorry, my suggestion of using reparseConfiguration wasn't clear. I meant using it against the global KSharedConfig, not a newly created KConfig. I

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

2015-03-21 Thread David Rosca
> On March 21, 2015, 12:55 p.m., David Faure wrote: > > Yep (looks like you posted a followup commit rather than merging the two, > > and the commit log on reviewboard is outdated, it still talks about V3). > > But if you make sure to review and clean up the commit, you can commit. I updated t

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

2015-03-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/ --- (Updated March 21, 2015, 1:07 p.m.) Review request for KDE Frameworks and

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread David Faure
On Saturday 21 March 2015 10:16:07 Mathias Kraus wrote: > Am Samstag, 7. März 2015, 14:43:14 schrieb laurent Montel: > > Le Saturday 07 March 2015 13:47:13 David Faure a écrit : > > > > KdePlatformTheme::loadSetting > > > > > > This code runs before the application name is set, but the fallback to

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77880 --- Ship it! Yep (looks like you posted a followup commit rather

Re: KF 5.8 changelog

2015-03-21 Thread David Faure
On Friday 13 March 2015 18:33:53 Michael Pyne wrote: > Isn't the feature intended to aid those preparing release announcements, as > opposed to being fed directly to a webpage? No, the full changelog is what I post to the lists (including kde-announce) and what ends up on the web, see e.g. https:

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

2015-03-21 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122981/ --- (Updated March 21, 2015, 12:39 p.m.) Review request for KDE Frameworks, M

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

2015-03-21 Thread Gregor Mi
> On March 17, 2015, 7:10 a.m., Martin Gräßlin wrote: > > src/kglobalaccel.h, lines 256-260 > > > > > > please add an > > @since > > and > > @param For the @since I looked at the value in the CMakeLi

Re: Review Request 122981: add KGlobalAccel::loadShortcutFromGlobalSettings

2015-03-21 Thread Gregor Mi
> On March 17, 2015, 7:10 a.m., Martin Gräßlin wrote: > > src/kglobalaccel.h, line 269 > > > > > > what are the "some cases"? I removed the "some cases". I was thinking about kwin/effects/desktopgrid/desktopgri