Re: Review Request 123679: Fix build with Qt 5.5

2015-05-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80075 --- src/kselectionproxymodel.cpp (line 2501)

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- (Updated May 8, 2015, 9:17 a.m.) Status -- This change has been

Re: Versioning of Frameworks

2015-05-08 Thread Christian Mollekopf
On Tue, May 5, 2015, at 05:38 PM, Martin Gräßlin wrote: On Tuesday 05 May 2015 17:30:05 Mario Fux wrote: Am Dienstag, 05. Mai 2015, 13.46:16 schrieb Martin Gräßlin: If master is always releasable, you should indeed only merge into master with a change of a version number. If you

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/#review80080 --- Ship it! Ship It! - Christoph Cullmann On May 7, 2015,

Re: Versioning of Frameworks

2015-05-08 Thread Christian Mollekopf
On Wed, May 6, 2015, at 01:42 PM, Jan Kundrát wrote: Hi Christian, Hi Jan, I think that the stuff you're looking for (reducing version churn) can also be provided by having stable branches for selected parts of KF5. IMHO this can be quite an elegant solution given the usual cat-herding

Re: Review Request 123679: Fix build with Qt 5.5

2015-05-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/#review80082 --- Ship it! Ship It! - Milian Wolff On May 8, 2015, 10:42

Review Request 123690: Don't use the DataEngineStructure for Applets

2015-05-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123690/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 123690: Don't use the DataEngineStructure for Applets

2015-05-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123690/ --- (Updated May 8, 2015, 7:23 p.m.) Status -- This change has been

Review Request 123689: We probably don't want to track null package structures

2015-05-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123689/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 123690: Don't use the DataEngineStructure for Applets

2015-05-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123690/ --- (Updated May 8, 2015, 5:25 p.m.) Status -- This change has been

Re: Review Request 123689: We probably don't want to track null package structures

2015-05-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123689/ --- (Updated May 8, 2015, 7:25 p.m.) Status -- This change has been

Re: Review Request 123689: We probably don't want to track null package structures

2015-05-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123689/#review80096 --- Ship it! Ship It! - Marco Martin On May 8, 2015, 5:13

Re: Review Request 123690: Don't use the DataEngineStructure for Applets

2015-05-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123690/#review80095 --- Ship it! Ship It! - Marco Martin On May 8, 2015, 5:16

Re: Review Request 123669: Add KPluginLoader::findPluginsById convenience API

2015-05-08 Thread Alex Richardson
On May 7, 2015, 8:24 a.m., Alex Richardson wrote: Seems like this is duplicated in a few places already so I agree we should add it. But won't most users of the API want only a single plugin returned? Maybe also add a function `KPluginMetaData KPluginLoader::findPluginById(const

Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

2015-05-08 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

changelog for 5.10

2015-05-08 Thread David Faure
I couldn't decrypt the commits in KActivities ... ### KActivities * (no changelog provided) ### KConfig * Generate QML-proof classes using the kconfigcompiler ### KCoreAddons * New cmake macro kcoreaddons_add_plugin to create KPluginLoader-based plugins more easily. ### KDeclarative *

Re: Review Request 123679: Fix build with Qt 5.5

2015-05-08 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123679/ --- (Updated May 8, 2015, 11:48 a.m.) Status -- This change has been

Re: changelog for 5.10

2015-05-08 Thread Aleix Pol
On Sat, May 9, 2015 at 12:47 AM, David Faure fa...@kde.org wrote: I couldn't decrypt the commits in KActivities ... ### KActivities * (no changelog provided) ### KConfig * Generate QML-proof classes using the kconfigcompiler ### KCoreAddons * New cmake macro kcoreaddons_add_plugin to