Re: Review Request 124315: Change keyboard shortcut to avoid conflict with next tab

2015-07-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124315/#review82305 --- Changing shortcuts is never a good idea. I'd prefer fixing it

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/#review82306 --- Ship it! Three minor things left, this is looking really

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

2015-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/#review82311 --- Guys, shortening this value won't make anything faster.

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

2015-07-10 Thread Martin Klapetek
On July 10, 2015, 11:03 a.m., David Faure wrote: Guys, shortening this value won't make anything faster. Instead, in case an app takes 26 seconds to start (slow machine, busy system, lots of initialization code...) the caller will get an error message erroneously. Did you never see

Review Request 124315: Change keyboard shortcut to avoid conflict with next tab

2015-07-10 Thread Simon Persson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124315/ --- Review request for Kate and KDE Frameworks. Bugs: 350025

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

2015-07-10 Thread David Faure
On July 10, 2015, 9:03 a.m., David Faure wrote: Guys, shortening this value won't make anything faster. Instead, in case an app takes 26 seconds to start (slow machine, busy system, lots of initialization code...) the caller will get an error message erroneously. Did you never see

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

2015-07-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124304/ --- (Updated July 10, 2015, 11:52 a.m.) Status -- This change has been

Re: Review Request 124304: Reduce the KDBusService timeout from 5 minutes to 25 seconds

2015-07-10 Thread Martin Klapetek
On July 10, 2015, 11:03 a.m., David Faure wrote: Guys, shortening this value won't make anything faster. Instead, in case an app takes 26 seconds to start (slow machine, busy system, lots of initialization code...) the caller will get an error message erroneously. Did you never see

Re: Review Request 124319: Add missing licenses

2015-07-10 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124319/ --- (Updated July 10, 2015, 12:48 p.m.) Status -- This change has been

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Jesse Jaara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/#review82323 --- Ship it! Ship It! - Jesse Jaara On heinä 10, 2015, 11:15

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Jesse Jaara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 10, 2015, 11:15 ap) Review request for KDE Frameworks and

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Jesse Jaara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated July 10, 2015, 12:11 p.m.) Status -- This change has been

Re: Review Request 124319: Add missing licenses

2015-07-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124319/#review82328 --- absolute no ShipIt. Maintainer veto! This needs proper

Re: Review Request 124315: Change keyboard shortcut to avoid conflict with next tab

2015-07-10 Thread Toni Asensi Esteve
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124315/#review82320 --- If two shortcuts are the same (the shortcut of go to previous

Re: [kglobalaccel/kglobalaccel-master] /: Add missing licenses

2015-07-10 Thread Martin Gräßlin
On Friday 10 July 2015 12:26:23 Maximiliano Curia wrote: Git commit cd503fed45a937c5d7eae22502304c16ba5e8fea by Maximiliano Curia. Committed on 10/07/2015 at 12:13. Pushed by maximilianocuria into branch 'kglobalaccel-master'. Add missing licenses The distributed tarballs include GPL-2 po

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Jesse Jaara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 10, 2015, 10:41 ap) Review request for KDE Frameworks and

Re: Review Request 124282: Implement Voikko based spellchecker for Sonnet

2015-07-10 Thread Jesse Jaara
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124282/ --- (Updated heinä 10, 2015, 11:12 ap) Review request for KDE Frameworks and

Review Request 124319: Add missing licenses

2015-07-10 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124319/ --- Review request for KDE Frameworks. Repository: kglobalaccel

Re: Review Request 124319: Add missing licenses

2015-07-10 Thread Maximiliano Curia
On July 10, 2015, 12:49 p.m., Martin Gräßlin wrote: absolute no ShipIt. Maintainer veto! This needs proper fixing, just changing the license is no solution! Please refer to the discussion I just sent to the mailing list. It would be nice if such important changes don't get

Jenkins-kde-ci: kwallet master kf5-qt5 » Linux,gcc - Build # 15 - Failure!

2015-07-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwallet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Jul 2015 10:36:34 + Build duration: 1 min 4 sec CHANGE SET Revision

Jenkins-kde-ci: kwallet master stable-kf5-qt5 » Linux,gcc - Build # 14 - Failure!

2015-07-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kwallet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Jul 2015 10:36:34 + Build duration: 21 sec CHANGE SET Revision

Re: Review Request 124319: Add missing licenses

2015-07-10 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124319/#review82324 --- Ship it! Ship It! - Scott Kitterman On July 10, 2015,

Re: Review Request 124319: Add missing licenses

2015-07-10 Thread Martin Gräßlin
On July 10, 2015, 2:49 p.m., Martin Gräßlin wrote: absolute no ShipIt. Maintainer veto! This needs proper fixing, just changing the license is no solution! Please refer to the discussion I just sent to the mailing list. It would be nice if such important changes don't get pushed

Re: Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated July 11, 2015, 12:16 a.m.) Status -- This change has been

Re: Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated Juli 10, 2015, 11:34 nachm.) Review request for KDE Frameworks.

Re: Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/#review82346 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 11, 2015,

Re: Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/#review82344 --- KF5AuthConfig.cmake.in (line 20)

Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- Review request for KDE Frameworks. Repository: kauth Description

Re: Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated Juli 10, 2015, 7:22 nachm.) Review request for KDE Frameworks.

Re: Review Request 124321: Fix building with the fake backend

2015-07-10 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124321/ --- (Updated Juli 10, 2015, 9:09 nachm.) Review request for KDE Frameworks.

Re: [kglobalaccel/kglobalaccel-master] /: Add missing licenses

2015-07-10 Thread Maximiliano Curia
Hi Martin, On 10/07/15 14:44, Martin Gräßlin wrote: On Friday 10 July 2015 12:26:23 Maximiliano Curia wrote: Add missing licenses as the kglobalaccel maintainer I'm very surprised by your change. The framework MUST be LGPL, because it's a framework. How come that you decided that it is