Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82521 --- src/kextracolumnsproxymodel.h (line 39)

Re: Review Request 124328: Man pages for kapidox

2015-07-14 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124328/ --- (Updated July 15, 2015, 5:48 a.m.) Status -- This change has been ma

Re: Review Request 124328: Man pages for kapidox

2015-07-14 Thread Allen Winter
> On July 12, 2015, 4:45 p.m., Kevin Krammer wrote: > > I thought our man pages are written in docbook and then translated by the > > usual docbook workflow? > > Albert Astals Cid wrote: > Correct. > > Luigi Toscano wrote: > Yes, because they can be translated. But that means a depende

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/#review82500 --- Ship it! src/kextracolumnsproxymodel.cpp (line 36)

Re: Review Request 124328: Man pages for kapidox

2015-07-14 Thread Scott Kitterman
> On July 12, 2015, 4:45 p.m., Kevin Krammer wrote: > > I thought our man pages are written in docbook and then translated by the > > usual docbook workflow? > > Albert Astals Cid wrote: > Correct. > > Luigi Toscano wrote: > Yes, because they can be translated. But that means a depende

Re: Review Request 124129: Fix KAuthorized config file loading

2015-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124129/ --- (Updated July 14, 2015, 11:17 a.m.) Status -- This change has been d

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124331/ --- (Updated July 14, 2015, 10:42 a.m.) Review request for KDE Frameworks, Je

Re: Review Request 124331: New proxy: KExtraColumnsProxyModel, allows to add columns to an existing model.

2015-07-14 Thread David Faure
> On July 13, 2015, 7:42 p.m., Sune Vuorela wrote: > > src/kextracolumnsproxymodel.h, line 92 > > > > > > where is the implementation of this? (and the unit tests ? :) Ouch, good catch, I forgot to finish this.