Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 83 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/83/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 12 Sep 2015 20:40:44 + Build duration: 3 min 5 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 84 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/84/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 12 Sep 2015 20:50:19 + Build duration: 22 sec CHANGE SET Revision

Review Request 125208: Workaround bug 350758

2015-09-12 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/ --- Review request for KDE Frameworks, David Faure and Jean-Baptiste Mardelle.

Re: Review Request 125208: Workaround bug 350758

2015-09-12 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/ --- (Updated Sept. 12, 2015, 9:40 p.m.) Review request for KDE Frameworks,

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-09-12 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/ --- (Updated Sept. 13, 2015, 12:18 a.m.) Review request for KDE Frameworks,

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 84 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/84/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 12 Sep 2015 20:50:19 + Build duration: 2 min 42 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 83 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/83/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 12 Sep 2015 20:40:44 + Build duration: 25 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 90 - Failure!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/90/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 23:53:19 + Build duration: 2 min 23 sec CHANGE SET Revision

Re: Review Request 125208: Workaround bug 350758

2015-09-12 Thread Xuetian Weng
> On Sept. 12, 2015, 10:12 p.m., David Rosca wrote: > > I am the author of the mentioned patch. I had the same idea - don't call > > show() before calling exec(), but I didn't want to use a timer for that, so > > I found a hack with hide() that worked ... at least it seemed to work. > > So +1

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 83 - Failure!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 23:53:19 + Build duration: 4 min 16 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 93 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/93/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 12 Sep 2015 20:40:44 + Build duration: 49 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 93 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/93/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 12 Sep 2015 20:40:44 + Build duration: 1 min 18 sec CHANGE SET

Re: Review Request 125208: Workaround bug 350758

2015-09-12 Thread Jean-Baptiste Mardelle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/#review85297 --- I can confirm that this works, fantastic! I have not looked

Review Request 125177: kbuildsycoca: deprecate option --nosignal.

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125177/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85232 --- src/sycoca/ksycoca.cpp (line 574)

Review Request 125184: KSycoca: rename private slot to avoid ambiguity with DBus signal

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125184/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-12 Thread Jean-Baptiste Mardelle
> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote: > > +1 > > Jean-Baptiste Mardelle wrote: > Kdenlive is also affected by this issue, as described in bug #346413 > Pressing "Esc" allows to dismiss the invisible file dialog and regain > control of the app. > However I tested the

Review Request 125185: kbuildsycoca: move sending of DBus signal to the KBuildSycoca class

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/ --- Review request for KDE Frameworks. Repository: kservice Description

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-09-12 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review85235 --- This looks quite inefficient to me. Every time

Re: Review Request 125184: KSycoca: rename private slot to avoid ambiguity with DBus signal

2015-09-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125184/#review85242 --- +1 - David Edmundson On Sept. 12, 2015, 8:28 a.m., David

Re: Review Request 125185: kbuildsycoca: move sending of DBus signal to the KBuildSycoca class

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125185/#review85237 --- Ben Cooksley had an interesting suggestion: instead of

Re: Review Request 125177: kbuildsycoca: deprecate option --nosignal.

2015-09-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125177/#review85241 --- +1 - David Edmundson On Sept. 12, 2015, 8:27 a.m., David

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 33 - Unstable!

2015-09-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 08:58:23 + Build duration: 3 min 12 sec CHANGE SET Revision

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-12 Thread Xuetian Weng
> On Sept. 11, 2015, 10:02 a.m., Luca Beltrame wrote: > > +1 > > Jean-Baptiste Mardelle wrote: > Kdenlive is also affected by this issue, as described in bug #346413 > Pressing "Esc" allows to dismiss the invisible file dialog and regain > control of the app. > However I tested the

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-12 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/ --- (Updated Sept. 12, 2015, 4:08 p.m.) Status -- This change has been

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-09-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review85267 --- Do we really need to add overhead to the icon loading for

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 92 - Still Failing!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/92/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 12 Sep 2015 16:08:53 + Build duration: 1 min 22 sec CHANGE SET

Re: Review Request 125184: KSycoca: rename private slot to avoid ambiguity with DBus signal

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125184/ --- (Updated Sept. 12, 2015, 2:17 p.m.) Status -- This change has been

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/ --- (Updated Sept. 12, 2015, 2:17 p.m.) Status -- This change has been

Re: Review Request 125177: kbuildsycoca: deprecate option --nosignal.

2015-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125177/ --- (Updated Sept. 12, 2015, 2:17 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 91 - Failure!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/91/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 12 Sep 2015 09:11:44 + Build duration: 1 min 22 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 91 - Failure!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/91/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 12 Sep 2015 09:11:44 + Build duration: 40 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 81 - Failure!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/81/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 12 Sep 2015 09:11:44 + Build duration: 57 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 81 - Failure!

2015-09-12 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/81/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 12 Sep 2015 09:11:44 + Build duration: 1 min 46 sec CHANGE SET

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-12 Thread Albert Astals Cid
> On set. 12, 2015, 8:17 a.m., David Faure wrote: > > src/sycoca/ksycoca.cpp, line 574 > > > > > > Interesting, 3 people (including me) read this code, nobody spotted the > > wrong '!' on this line ;) > >

Re: Review Request 125152: KBuildSycoca: replace dbus-based locking with a lock file.

2015-09-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125152/#review85258 --- Ship it! Ship It! - Albert Astals Cid On set. 11, 2015,

Re: Review Request 125184: KSycoca: rename private slot to avoid ambiguity with DBus signal

2015-09-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125184/#review85260 --- Ship it! This is very technically a SIC since one could be

Re: Review Request 125185: kbuildsycoca: move sending of DBus signal to the KBuildSycoca class

2015-09-12 Thread Albert Astals Cid
> On set. 12, 2015, 9:39 a.m., David Faure wrote: > > Ben Cooksley had an interesting suggestion: instead of sending a DBus > > signal, we could make KSycoca use QFileSystemWatcher to detect when sycoca > > has been updated, and emit the Qt signal then. > > > > The only downside is that we

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 89 - Still Unstable!

2015-09-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 09:08:54 + Build duration: 5 min 23 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 82 - Still Unstable!

2015-09-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 09:08:54 + Build duration: 10 min CHANGE SET Revision

Re: Review Request 125177: kbuildsycoca: deprecate option --nosignal.

2015-09-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125177/#review85259 --- Ship it! Ship It! - Albert Astals Cid On set. 12, 2015,

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-09-12 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- (Updated Sept. 12, 2015, 1:29 p.m.) Review request for KDE Frameworks.