Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

On Thursday October 22 2015 18:48:30 Marko Käning wrote: > have you followed the discussion with Qt's developers regarding the QSP patch > [1]? > If not, I advise you to do a little reading there! > Qt won’t ever support such an approach, i.e. one would have to patch it, if > KDE itself doesn’t

Re: Question about goal of Windows/Mac frameworks

Hi, > Am 21.10.2015 um 01:19 schrieb Aleix Pol: >> On Wed, Oct 21, 2015 at 1:12 AM, Ralf Habacker wrote: Christoph Cullmann hat am 20. Oktober 2015 um 16:49 geschrieben: That works only, if the applications bundle their ui files in

Re: breeze icons default and its inheritance

On Thursday 22 October 2015 07:28:09 Harald Sitter wrote: > if > an icon was in oxygen (by default, or installed by an application) I never understood why apps were changed to install their own icons in oxygen rather than hicolor (which was the standard way to ensure icons would be available

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87245 --- autotests/jobtest.cpp (line 298)

Re: Review Request 125325: New widget KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125325/#review87241 --- Ship it! Ship It! - David Faure On Oct. 20, 2015, 9:20

Re: Review Request 125164: Fix misbehavior when canceling a job

> On Oct. 19, 2015, 5:44 p.m., Albert Astals Cid wrote: > > Is this trying to fix something similar to > > https://git.reviewboard.kde.org/r/125613/diff/ ? No, completely unrelated. - David --- This is an automatically generated

Re: icons packages with frameworks

Hi, > On Wednesday 21 October 2015 21:07:16 Christoph Cullmann wrote: >> Hi, >> >> >> So maybe this wouldn't be such a bad move after all. >> > >> > Agreed, we have frameworks (e.g. KIconThemes) "depending" on breeze, so it >> > makes some kind of sense to ship them together. >> yeah, beside

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review87243 --- Ship it! This looks good to me. Don't move the struct out of

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125691/#review87244 --- src/widgets/kopenwithdialog.cpp (line 911)

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review87248 --- src/widgets/koverlayiconplugin.h (line 44)

Re: icons packages with frameworks

On Wednesday 21 October 2015 21:07:16 Christoph Cullmann wrote: > Hi, > > >> So maybe this wouldn't be such a bad move after all. > > > > Agreed, we have frameworks (e.g. KIconThemes) "depending" on breeze, so it > > makes some kind of sense to ship them together. > yeah, beside that, if you

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

Hi René, On 22 Oct 2015, at 19:24 , René J.V. Bertin wrote: > Not exactly, no. The patch was rejected in the presented form, but we were > invited to file a bug report (I think it's > https://bugreports.qt.io/browse/QTBUG-44473). Here we (me, IIRC) managed to > make the

Re: Review Request 125158: add logic to use icons for default xdg user dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- (Updated Oct. 22, 2015, 7:26 a.m.) Status -- This change has been

Re: Review Request 125725: Make KCrash optional for kservice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125725/#review87249 --- For the record, I would have approved this. This is really

Review Request 125756: Initialize QFunctionPointer to nullptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

> On Oct. 22, 2015, 7:30 a.m., David Faure wrote: > > src/widgets/kopenwithdialog.cpp, line 911 > > > > > > How about changing this condition to > >(...) && !qMimeType.isEmpty() ? > > > > If

Re: Review Request 125756: Initialize QFunctionPointer to nullptr

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/#review87260 --- src/declarativeimports/core/windowthumbnail.h (lines 128 -

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

Thanks René and Jeremy, On 22 Oct 2015, at 22:43 , Jeremy Whiting wrote: > ...It sounds like a good solution for embedding a copy of Qt next > to each application for windows use (and maybe for osx use too if > resources don't make it completely unneccessary), but not for the

Re: icons packages with frameworks

Hi, btw., to get all things working even if breeze in bundled in that way one needs in addition: 1) breeze to be default theme in kiconthemes or a way to set it manually 2) :/icons being in default search paths in kiconsthemes, too. For 2) I already have a patch, is some "setDefaultIconTheme"

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

On Thursday October 22 2015 22:05:59 Marko Käning wrote: > > https://bugreports.qt.io/browse/QTBUG-44473?focusedCommentId=272971=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-272971) > > Because the proposal supports environment variables too, I guess this > > would

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

Yeah, if we go that direction on mac it would be fine for bundled Qt, but not for shared Qt. It would make all applications that use qt5-mac or qt5-kde or whatnot use linuxy paths or not. It's a runtime switch, so not very helpful if you've installed stuff to linuxy paths and then let the user

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

On Wednesday October 21 2015 13:08:46 Dominik Haumann wrote: > In Windows, such a package manager does not exist. KDE tried to create > such a package manager through the emerge/KDE Windows installer, but > this is non-standard [on Windows] and simply not what users want. That's not entirely

Re: Question about goal of Windows/Mac frameworks

Am 21.10.2015 um 01:19 schrieb Aleix Pol: > On Wed, Oct 21, 2015 at 1:12 AM, Ralf Habacker wrote: >>> Christoph Cullmann hat am 20. Oktober 2015 um 16:49 >>> geschrieben: >>> That works only, if the applications bundle their ui files in resources, >>> too,

Re: Review Request 125164: Finish killed KIO jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Oct. 23, 2015, 2:48 a.m.) Review request for KDE Frameworks.

Re: Review Request 125164: Fix misbehavior when canceling a job

> On Oct. 22, 2015, 9:39 a.m., David Faure wrote: > > autotests/jobtest.cpp, line 309 > > > > > > What is the purpose of changing the currently-being-uploaded data > > buffer? Ah, from the fix I can see the

Re: Review Request 125164: Fix misbehavior when canceling a job

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Oct. 23, 2015, 2:19 a.m.) Review request for KDE Frameworks.

Re: Review Request 125164: Fix misbehavior when canceling a job

> On Oct. 22, 2015, 9:39 a.m., David Faure wrote: > > src/core/transferjob.cpp, line 400 > > > > > > Why slotFinished? Wouldn't just return be enough? > > kill() is supposed to take care of emitting finished

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/ --- (Updated Oct. 22, 2015, 3:31 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 67 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 13:35:39 + Build duration: 2 min 36 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 63 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 13:35:39 + Build duration: 3 min 56 sec CHANGE SET Revision

Re: Question about goal of Windows/Mac frameworks

On Thu, 22 Oct 2015, Christoph Cullmann wrote: If such an approach seems reasonable, we could have some helper for this in a framework. Perhaps the "breeze" framework could even just provide such an rcc and a little lib to load it that can be used for people creating bundles/installers.

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/#review87264 --- Ship it! Ship It! - Martin Gräßlin On Oct. 22, 2015, 2:31

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 66 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 13:21:09 + Build duration: 2 min 21 sec CHANGE SET Revision

Re: Question about goal of Windows/Mac frameworks

Impressive! And cool to see another project using the cmake externals approach, I can copy a lot of it for Krita 3, I think. How are you handling icons? Bundling the breeze theme, or putting the icons in resource files? -- Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org On Thu,

Re: Question about goal of Windows/Mac frameworks

On Thu, 22 Oct 2015, Christoph Cullmann wrote: Hi, Impressive! And cool to see another project using the cmake externals approach, I can copy a lot of it for Krita 3, I think. How are you handling icons? Bundling the breeze theme, or putting the icons in resource files? as I was lazy, I just

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 62 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 13:21:09 + Build duration: 4 min 38 sec CHANGE SET Revision

Re: Question about goal of Windows/Mac frameworks

Hi, > Impressive! And cool to see another project using the cmake externals > approach, I can copy a lot of it for Krita 3, I think. How are you > handling icons? Bundling the breeze theme, or putting the icons in resource > files? as I was lazy, I just compiled complete breeze into a binary rcc

Re: Question about goal of Windows/Mac frameworks

Hi, > On Thu, 22 Oct 2015, Christoph Cullmann wrote: > >> Hi, >> >>> Impressive! And cool to see another project using the cmake externals >>> approach, I can copy a lot of it for Krita 3, I think. How are you >>> handling icons? Bundling the breeze theme, or putting the icons in resource >>>

Re: Review Request 125750: Reduce some allocations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/#review87265 --- Ship it! There's probably a way of avoinding the allocation

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125756/ --- (Updated Oct. 22, 2015, 1:27 p.m.) Status -- This change has been

Re: Review Request 125750: Reduce some allocations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125750/ --- (Updated Oct. 22, 2015, 1:20 p.m.) Status -- This change has been

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 68 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 15:40:49 + Build duration: 1 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 68 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 15:40:49 + Build duration: 1 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 15:40:49 + Build duration: 3 min 59 sec CHANGE SET Revision

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 22 Oct 2015 15:40:49 + Build duration: 3 min 59 sec CHANGE SET Revision

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125515/#review87274 --- Ship it! 4096 bytes looks reasonable. I think I would still

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

> On Oct. 22, 2015, 9:09 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/windowthumbnail.h, lines 128-129 > > > > > > AFAIK we are not yet allowed to use nullptr in frameworks. You need to > > use

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

Hi Ralf, On 22 Oct 2015, at 08:35 , Ralf Habacker wrote: > umbrello for example depends on about 50 other libraries and packages > https://build.opensuse.org/project/show/home:rhabacker:branches:windows:mingw:win32:KF511. > Not patching Qt requires to repack every single

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

> On Oct. 22, 2015, 4:32 p.m., Frank Reininghaus wrote: > > 4096 bytes looks reasonable. I think I would still find a fail-safe > > solution with a dynamically increasing buffer prettier, but it's so > > extremely unlikely that this will ever cause problems that it's not worth > > arguing