----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/#review87245 -----------------------------------------------------------
autotests/jobtest.cpp (line 298) <https://git.reviewboard.kde.org/r/125164/#comment59927> did you copy/paste all that stuff from elsewhere? I don't see why you need that modificationtime stuff for this test. autotests/jobtest.cpp (line 309) <https://git.reviewboard.kde.org/r/125164/#comment59929> What is the purpose of changing the currently-being-uploaded data buffer? Ah, from the fix I can see the purpose is to make it emit readyRead. Can you add a comment here like "// make it emit readyRead..." if that's indeed the idea? (I assume this is to emulate something more like a socket?) autotests/jobtest.cpp (line 311) <https://git.reviewboard.kde.org/r/125164/#comment59928> Why restart the timer here? You kill the job more than once? I'm confused. src/core/transferjob.cpp (line 400) <https://git.reviewboard.kde.org/r/125164/#comment59930> Why slotFinished? Wouldn't just return be enough? kill() is supposed to take care of emitting finished already, and you don't want to emit it twice. - David Faure On Sept. 11, 2015, 1:24 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125164/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 1:24 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Catch that the job has been cancelled and emit the job as finished. > > Still, I'm not too sure it's the correct fix. > > > Diffs > ----- > > autotests/jobtest.h ef8c3e1 > autotests/jobtest.cpp c24bcea > src/core/transferjob.cpp 0c38070 > > Diff: https://git.reviewboard.kde.org/r/125164/diff/ > > > Testing > ------- > > Added a test and made it pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
