Review Request 125767: Make KConfigWidgets self contained, bundle the one global file in a resource

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125767/ --- Review request for KDE Frameworks. Repository: kconfigwidgets

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/ --- (Updated Oct. 23, 2015, 5:58 p.m.) Review request for KDE Frameworks.

Re: Review Request 125641: Allow PAM unlocking of a running wallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review87317 --- src/runtime/kwalletd/main.cpp (line 173)

Re: Review Request 125763: Add Skip Close Animation to NET::Property2

> On Oct. 23, 2015, 4:41 p.m., Martin Gräßlin wrote: > > I understand the changes to NETRootInfo, but I fail to see what the changes > > to NETWinInfo are supposed to do. If the changes to NETWinInfo aren't required, it simplifies the patch a lot. I'll post a fixed patch tomorrow. -

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 102 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Oct 2015 10:10:37 + Build duration: 3 min 53 sec CHANGE SET Revision

Re: Review Request 125762: External extractor plugin support for KFileMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 23, 2015, 6:58 p.m.) Review request for Baloo, KDE

Re: Review Request 125762: External extractor plugin support for KFileMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 23, 2015, 7:10 p.m.) Review request for Baloo, KDE

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 102 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Oct 2015 10:10:37 + Build duration: 3 min 53 sec CHANGE SET Revision

Review Request 125763: Add Skip Close Animation to NET::Property2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125763/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository:

Re: Review Request 125763: Add Skip Close Animation to NET::Property2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125763/#review87302 --- I understand the changes to NETRootInfo, but I fail to see

Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87303 --- Looks good to me. Maybe some testing would be useful? -

Review Request 125762: External extractor plugin support for KFileMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.

Re: Review Request 125762: External extractor plugin support for KFileMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125762/ --- (Updated Oct. 23, 2015, 4:17 p.m.) Review request for Baloo, KDE

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 98 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Oct 2015 10:10:37 + Build duration: 3 min 42 sec CHANGE SET Revision

Re: Question about goal of Windows/Mac frameworks

On 23 October 2015 at 16:18, Luigi Toscano wrote: > On Friday 23 of October 2015 10:31:36 Christoph Cullmann wrote: >> Hi, >> >> > Am 21.10.2015 um 12:41 schrieb Christoph Cullmann: >> >> The last time I build umbrello with kf5 (version 5.11) dbus was required >> >> to

Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/ --- (Updated Oct. 23, 2015, 5:28 p.m.) Review request for KDE Frameworks,

Re: Question about goal of Windows/Mac frameworks

Hi, > On Fri, 23 Oct 2015, Jaroslaw Staniek wrote: > >> Actually let's look as a popular ported standalone app: GTK/GNOME's >> help-browser that GIMP uses on Windows is the same as on Linux but I >> don't see it using dbus (but still webkitgtk is used). Moreover if >> someone caring for UX reads

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

> On Oct. 23, 2015, 3:14 p.m., Aleix Pol Gonzalez wrote: > > src/kded.cpp, line 686 > > > > > > Maybe it should set up KAboutData as well? It's a QApplication, not a KApplication, so the only purpose of

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/ --- (Updated Oct. 23, 2015, 4:50 p.m.) Review request for KDE Frameworks.

Re: Question about goal of Windows/Mac frameworks

On Friday 23 of October 2015 10:31:36 Christoph Cullmann wrote: > Hi, > > > Am 21.10.2015 um 12:41 schrieb Christoph Cullmann: > >> The last time I build umbrello with kf5 (version 5.11) dbus was required > >> to run khelpcenter and open/save file dialogs and for remote control. > >>

Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/ --- Review request for KDE Frameworks. Repository: kded Description

Re: Question about goal of Windows/Mac frameworks

On Friday 23 of October 2015 16:32:12 Christoph Cullmann wrote: > Hi, > > > On Friday 23 of October 2015 10:31:36 Christoph Cullmann wrote: > >> Hi, > >> > >> > Am 21.10.2015 um 12:41 schrieb Christoph Cullmann: > >> >> The last time I build umbrello with kf5 (version 5.11) dbus was > >> >>

Re: Question about goal of Windows/Mac frameworks

Hi, > On Friday 23 of October 2015 16:32:12 Christoph Cullmann wrote: >> Hi, >> >> > On Friday 23 of October 2015 10:31:36 Christoph Cullmann wrote: >> >> Hi, >> >> >> >> > Am 21.10.2015 um 12:41 schrieb Christoph Cullmann: >> >> >> The last time I build umbrello with kf5 (version 5.11) dbus

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/#review87311 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 23, 2015,

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125766/#review87313 --- src/kded.cpp (line 684)

Re: Review Request 125766: Changed the manual command line parsing to use QCommandLineParser.

> On Oct. 23, 2015, 5:09 p.m., Aleix Pol Gonzalez wrote: > > Ship It! Eh sorry I pressed that by fault, I don't know how it got confirmed. My actual review follows. - Aleix --- This is an automatically generated e-mail. To reply,

Re: Question about goal of Windows/Mac frameworks

Hi, > On Friday 23 of October 2015 10:31:36 Christoph Cullmann wrote: >> Hi, >> >> > Am 21.10.2015 um 12:41 schrieb Christoph Cullmann: >> >> The last time I build umbrello with kf5 (version 5.11) dbus was required >> >> to run khelpcenter and open/save file dialogs and for remote control. >> >>

Re: Question about goal of Windows/Mac frameworks

On Wednesday 21 of October 2015 20:09:33 Kevin Ottens wrote: > > And then, three areas of efforts which we are missing right now in > Frameworks: - systematically try to reduce the tier and type of our > frameworks (the maturity direction I was talking about); Do you mean that a Framework is

Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/ --- Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt.

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

> On Oct. 23, 2015, 12:11 p.m., Martin Gräßlin wrote: > > src/kwindoweffects.h, lines 162-168 > > > > > > Maybe we should extend the documentation a little bit? E.g. that it's > > only a hint to the WM, that

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

> On Oct. 23, 2015, 8:41 a.m., Martin Gräßlin wrote: > > src/platforms/xcb/kwindoweffects.cpp, line 333 > > > > > > nitpick: unrelated whitespace change. > > Boudhayan Gupta wrote: > That's my text-editor

Re: icons packages with frameworks

Hi, patch for the 2) issue is there: https://git.reviewboard.kde.org/r/125760/ Greetings Christoph - Am 22. Okt 2015 um 23:15 schrieb cullmann cullm...@absint.com: > Hi, > > btw., to get all things working even if breeze in bundled in that way one > needs > in addition: > > 1) breeze

Re: Review Request 125736: Add Skip Window Close Animation to KWindowEffects

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125736/#review87294 --- src/kwindoweffects.h (lines 162 - 168)

Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87320 --- +1 looks good to me. - Aleix Pol Gonzalez On Oct. 23,

Re: Question about goal of Windows/Mac frameworks

Hi, > Am 21.10.2015 um 12:41 schrieb Christoph Cullmann: >> >> The last time I build umbrello with kf5 (version 5.11) dbus was required >> to run khelpcenter and open/save file dialogs and for remote control. >>

Re: Review Request 125641: Allow PAM unlocking of a running wallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review87316 --- "I originally didn't want to pass it over dbus, but in the