Re: Question about goal of Windows/Mac frameworks

Hi, >> Boudewijn Rempt hat am 23. Oktober 2015 um 19:46 >> geschrieben: >> For Krita, we decided ages ago to simply open a browser on the userbase >> manual of Krita. Yes, it is conceivable that there are people who use >> Krita without internet access who still need help,

Re: Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125806/#review87415 --- Ship it! src/kmultitabbar.cpp (line 601)

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Re: Question about goal of Windows/Mac frameworks

Am 26.10.2015 um 10:33 schrieb Christoph Cullmann: > Hi, > >>> Boudewijn Rempt hat am 23. Oktober 2015 um 19:46 >>> geschrieben: >>> For Krita, we decided ages ago to simply open a browser on the userbase >>> manual of Krita. Yes, it is conceivable that there are people who use

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125806/ --- Review request for KDE Frameworks and Christoph Feck. Repository:

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. How about "KDE-KIO-Protocols"? I think having a KDE

Review Request 125803: KBuildSycoca: always save, even if no change in .desktop file was noticed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125803/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125819/ --- Review request for KDE Frameworks. Repository: kwallet Description

Re: Review Request 125819: Use KDE_INSTALL_FULL_DBUSINTERFACEDIR to install dbus interfaces

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125819/#review87474 --- This shouldn't be necessary. I think the issue you're having

Re: Review Request 125779: properly handle middle click in navigatormenu

> On Oct. 26, 2015, 2:56 p.m., Martin Klapetek wrote: > > Looks good to me > > > > Do you have commit access? > > Ilia Kats wrote: > I think so, yes, although I have not used it for quite a while. Should I > try to push and see what happens? Ideally you should wait for someone giving you

Re: Review Request 125795: Add KCollapsibleGroupBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125795/ --- (Updated Oct. 26, 2015, 1:47 p.m.) Status -- This change has been

Re: Review Request 125800: OS X build and warning fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125800/ --- (Updated Oct. 26, 2015, 2:18 p.m.) Review request for KDE Frameworks and

Re: Review Request 125779: properly handle middle click in navigatormenu

> On Oct. 26, 2015, 2:56 p.m., Martin Klapetek wrote: > > Looks good to me > > > > Do you have commit access? > > Ilia Kats wrote: > I think so, yes, although I have not used it for quite a while. Should I > try to push and see what happens? > > Martin Klapetek wrote: > Ideally you

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Re: Review Request 125779: properly handle middle click in navigatormenu

> On Oct. 26, 2015, 1:56 p.m., Martin Klapetek wrote: > > Looks good to me > > > > Do you have commit access? > > Ilia Kats wrote: > I think so, yes, although I have not used it for quite a while. Should I > try to push and see what happens? > > Martin Klapetek wrote: > Ideally you

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 112 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/112/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 26 Oct 2015 12:17:19 + Build duration: 6 min 32 sec CHANGE SET Revision

Re: Review Request 125779: properly handle middle click in navigatormenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125779/#review87425 --- Looks good to me Do you have commit access?

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 121 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/121/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 26 Oct 2015 12:19:37 + Build duration: 3 min 1 sec CHANGE SET

Re: Question about goal of Windows/Mac frameworks

On Monday 26 of October 2015 11:50:10 Ralf Habacker wrote: > > BTW: You mentioned the url > https://docs.kde.org/stable5/en/applications/kate/index.html in an earlier > email to access online help. khelpcenter determine the currently selected > language by itself and loads the language related

Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125809/ --- Review request for KDE Frameworks and Plasma. Repository:

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 122 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/122/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 26 Oct 2015 17:22:41 + Build duration: 3 min 19 sec CHANGE SET

Re: Review Request 125797: protocoltojson application

> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 113 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/113/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 26 Oct 2015 17:22:41 + Build duration: 6 min 28 sec CHANGE SET Revision

Re: Review Request 125797: protocoltojson application

> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure

Re: Review Request 125797: protocoltojson application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125797/ --- (Updated Oct. 26, 2015, 4:50 p.m.) Review request for KDE Frameworks and

Re: Review Request 125778: Allow local kioslave deployment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/ --- (Updated Oct. 26, 2015, 4:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Re: Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125809/ --- (Updated Oct. 26, 2015, 5:22 p.m.) Status -- This change has been

Re: Review Request 125778: Allow local kioslave deployment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125778/ --- (Updated Oct. 26, 2015, 4:55 p.m.) Review request for KDE Frameworks and

Re: Review Request 125806: Fix build with -DDEFINE_NO_DEPRECATED=1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125806/ --- (Updated Oct. 26, 2015, 4:58 p.m.) Status -- This change has been

Re: Review Request 125809: Fix logic (and warnings) in ModelContextMenu.qml

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125809/#review87441 --- Ship it! Ship It! - David Edmundson On Oct. 26, 2015,

Re: Review Request 125797: protocoltojson application

> On Oct. 25, 2015, 9:32 p.m., Christoph Cullmann wrote: > > I think one needs to add a outer scope with some "KIO-Protocol-Info" or so > > key to be able to check if we have valid data inside a lib. > > But I am not sure how to name that. > > Alex Merry wrote: > How about

Re: Review Request 125797: protocoltojson application

> On Oct. 26, 2015, 5:27 p.m., Alex Richardson wrote: > > The protocoltojson program will have to read the plugin metadata.json file > > to insert the "KDE-KIO-Protocols" to that json file as it is not possible > > to embed more than one JSON file into a Qt plugin. > > > > I am not sure

Re: Review Request 125815: RFC: Attempt to provide an alternative when khelpcenter is not available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125815/#review87456 --- Hi, not sure about URLs either, but looks like a nice idea.

Review Request 125815: RFC: Attempt to provide an alternative when khelpcenter is not available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125815/ --- Review request for KDE Frameworks, Christoph Cullmann and Luigi Toscano.

Re: Question about goal of Windows/Mac frameworks

On Mon, Oct 26, 2015 at 10:33 AM, Christoph Cullmann wrote: > Hi, > >>> Boudewijn Rempt hat am 23. Oktober 2015 um 19:46 >>> geschrieben: >>> For Krita, we decided ages ago to simply open a browser on the userbase >>> manual of Krita. Yes, it is

Re: Review Request 125803: KBuildSycoca: always save, even if no change in .desktop file was noticed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125803/#review87455 --- Ship it! Ship It! - Albert Astals Cid On oct. 26, 2015,