Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125928/ --- (Updated Nov. 3, 2015, 9:45 a.m.) Status -- This change has been

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > > > > > What does `qApp->wheelScrollLines()` return now? > > David Rosca wrote: > It

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review87900 --- Ping - David Rosca On Oct. 29, 2015, 8:22 p.m., David

Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125928/ --- Review request for KDE Frameworks, Christoph Cullmann, Frank Reininghaus,

Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125928/#review87903 --- +1 otherwise :) src/filewidgets/knewfilemenu.cpp (lines 581

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

On Tuesday 03 November 2015, Albert Astals Cid wrote: > El Monday 02 November 2015, a les 14:56:15, Marco Martin va escriure: > > On Monday 02 November 2015, David Faure wrote: > > > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > > > >

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > > > > > What does `qApp->wheelScrollLines()` return now? > > David Rosca wrote: > It

Re: Review Request 125928: Ship the "new file templates" in the kiofilewidgets library using a .qrc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125928/#review87905 --- Ship it! LGTM - Harald Sitter On Nov. 3, 2015, 8:24 a.m.,

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 8:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > >

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

> On Nov. 3, 2015, 1:40 p.m., Milian Wolff wrote: > > src/lib/jobs/kjob.h, line 644 > > > > > > move this into KJobPrivate, no? I don't think I can. I tried and I wasn't able to call the QPrivateSignal from

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/#review87922 --- Ship it! lgtm, esp. if the tests pass src/lib/jobs/kjob.h

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125790/#review87921 --- src/imageformats/psd.json (lines 2 - 3)

Re: Failure while executing KTar::open while using KCompressionDevice as the device

2015-11-02 23:03 GMT-03:00 Aleix Pol : > On Tue, Nov 3, 2015 at 3:00 AM, Luiz Romário Santana Rios > wrote: >> 2015-11-02 22:41 GMT-03:00 Aleix Pol : >>> On Mon, Nov 2, 2015 at 6:53 PM, Luiz Romário Santana Rios >>>

Re: Review Request 125904: Save proxy url with correct scheme.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125904/ --- (Updated Nov. 3, 2015, 3:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

> On Nov. 3, 2015, 5:21 nachm., Ivan Čukić wrote: > > The current master (the library) should build without boost now. Indeed. Thanks for the fix. - Heiko --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125852/ --- (Updated Nov. 3, 2015, 5:48 nachm.) Status -- This change has been

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/#review87944 --- Ship it! Ship It! - David Faure On Nov. 2, 2015, 7:31

Re: Review Request 125905: Make kactivitymanagerd a QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/#review87946 --- Ship it! Ship It! - Ivan Čukić On Nov. 1, 2015, 1:33

Re: Review Request 125852: Depend on boost even if KACTIVITIES_LIBRARY_ONLY is enabled

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125852/#review87947 --- The current master (the library) should build without boost

Re: Review Request 125905: Make kactivitymanagerd a QApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125905/ --- (Updated Nov. 3, 2015, 7:12 p.m.) Status -- This change has been

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

> On nov. 3, 2015, 10:21 p.m., Alex Merry wrote: > > src/kdeui/kpixmapcache.cpp, line 132 > > > > > > Why time_t here, and quint32 further down? If anything, I'd expect it > > to be the other way around - this

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 148 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/148/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Nov 2015 22:19:49 + Build duration: 13 min CHANGE SET Revision

Re: Review Request 125924: KJob::kill(Quiet) should also exit the event loop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125924/ --- (Updated Nov. 3, 2015, 10:44 p.m.) Status -- This change has been

Re: Review Request 125164: Finish killed KIO jobs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125164/ --- (Updated Nov. 3, 2015, 11:44 p.m.) Status -- This change has been

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125869/#review87966 --- How does this work without modifying

Re: Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/#review87974 --- Ship it! I'm happy for this to go in - you may want to wait

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125790/ --- (Updated Nov. 3, 2015, 7:51 nachm.) Review request for KDE Frameworks.

Re: Review Request 124714: Add support to qmake's options to api.kde.org

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124714/#review87955 --- Sorry I've let this sit for so long - Real Life(TM) got in

Review Request 125938: Don't try to store a QDateTime in mmap'ed memory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125938/ --- Review request for KDE Frameworks and Michael Pyne. Repository:

Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository:

Re: Review Request 125941: Add KCompressionDevice tests to KArchive

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125941/#review87980 --- autotests/kcompressiondevicetest.cpp (line 29)

Re: Review Request 125815: RFC: Attempt to provide an alternative when khelpcenter is not available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125815/#review87979 --- Bump? Anyone with docs.kde.org knowledge around? - Aleix Pol

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 156 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/156/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Nov 2015 23:01:24 + Build duration: 9 min 22 sec CHANGE SET Revision 57454f9080206f62aa3e67104b79539f1ad3822f

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 149 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Nov 2015 23:01:24 + Build duration: 7 min 1 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 149 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/149/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Nov 2015 23:01:24 + Build duration: 7 min 1 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 155 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/155/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 Nov 2015 22:19:49 + Build duration: 6 min 45 sec CHANGE SET Revision 27cc932453dadb16ecfe731339acee842fc2c244

Re: Review Request 125936: Update KProtocolManager after configuration change.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125936/ --- (Updated Nov. 4, 2015, 6:28 a.m.) Review request for KDE Frameworks and

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Nov. 3, 2015, 9:47 p.m., Albert Astals Cid wrote: > > How does this work without modifying > > KProtocolInfoPrivate::KProtocolInfoPrivate? You mean the JSON stuff? That was implemented in https://git.reviewboard.kde.org/r/125830/ For the http slave, that already works nicely, but we

Re: Review Request 125869: Convert all io slave .protocol data to json and embed it.

> On Oct. 30, 2015, 7:29 a.m., David Faure wrote: > > src/ioslaves/trash/trash.json, line 6 > > > > > > That doesn't look very English to me ;) > > > > The original is: > > > >

Re: KPixmapCache in kdelibs4support uses QDateTime in mmap'ed struct

On 2015-11-03 00:56, Michael Pyne wrote: On Tue, November 3, 2015 00:40:58 Albert Astals Cid wrote: Someone went a bit too far in the "port away from time_t to QDateTime" and changed the timestamp member of the KPixmapCacheIndexHeader struct. According to mpyne and thiago this is a big no-no.