Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/ --- (Updated Nov. 16, 2015, 4:42 p.m.) Review request for KDE Software on

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Nov. 16, 2015, 4:55 p.m.) Status -- This change has been

Re: Review Request 126084: Small KDeclarative cleanup

2015-11-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126084/#review88420 --- Ship it! Ship It! - Sebastian Kügler On Nov. 16, 2015,

Review Request 126086: kauth-policy-gen should not be an app bundle on OS X

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-11-16 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88425 --- Ship it! Ship It! - Heiko Tietze On Okt. 13, 2015, 1:33

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/#review88418 --- Here's a debugging trace after hitting a breakpoint set on

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-11-16 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125619/#review88424 --- Ping? - Elvis Angelaccio On Oct. 13, 2015, 1:33 p.m.,

Review Request 126087: Move the i18n context from KDeclarative

2015-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126087/ --- Review request for KDE Frameworks, Chusslove Illich and Marco Martin.

Review Request 126088: Port KDeclarative to use KI18n directly, rather than adding its own bindings

2015-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126088/ --- Review request for KDE Frameworks. Repository: kdeclarative

Re: Review Request 126086: kauth-policy-gen should not be an app bundle on OS X

2015-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/#review88426 --- src/CMakeLists.txt (line 1)

Review Request 126085: Fix filename suggestion changing to something random when changing save-as mimetype.

2015-11-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126085/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-16 Thread René J . V . Bertin
On Monday November 16 2015 12:29:49 René J.V. Bertin wrote: > If that's the intended behaviour, why does the KIdleTime example work on > Linux, without "restarting" `catchNextResumeEvent`?? Sorry for the rapid fire of growing messages - that comes with asking questions through RRs ... I

Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/ --- Review request for KDE Frameworks, Plasma and David Edmundson.

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 142 - Failure!

2015-11-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/142/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 16 Nov 2015 16:55:44 + Build duration: 1 min 42 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 142 - Failure!

2015-11-16 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/142/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 16 Nov 2015 16:55:44 + Build duration: 3 min 32 sec CHANGE

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- >assuming, that is, distros push out the updates together

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 143 - Fixed!

2015-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/143/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 16 Nov 2015 17:23:19 + Build duration: 3 min 5 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 143 - Fixed!

2015-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/143/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 16 Nov 2015 17:23:19 + Build duration: 3 min 5 sec CHANGE SET

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Boudhayan Gupta
> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously 'course, I'll post there as well as add

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 143 - Fixed!

2015-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/143/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 16 Nov 2015 17:23:19 + Build duration: 2 min 33 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 143 - Fixed!

2015-11-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/143/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 16 Nov 2015 17:23:19 + Build duration: 2 min 33 sec CHANGE

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/ --- (Updated Nov. 16, 2015, 11:03 p.m.) Review request for KDE Software on

KIdleTime : provide a settable resolution for the polling backends?

2015-11-16 Thread René J . V . Bertin
Hi, Working on modernising the OS X plugin for KIdleTime, I realised that there is no mechanism foreseen to set the frequency at which the current system idle time should be sampled on those platforms that need to use a polling approach (OS X, MS Windows and apparently also XScreenSaver). The

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126078/ --- (Updated Nov. 16, 2015, 11:15 p.m.) Review request for KDE Software on

Re: Review Request 126086: kauth-policy-gen should not be an app bundle on OS X

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Nov. 16, 2015, 10:15 p.m.) Review request for KDE Software on

Re: KIdleTime : provide a settable resolution for the polling backends?

2015-11-16 Thread René J . V . Bertin
Aleix Pol wrote: > I guess it's because it shouldn't poll necessarily, but get a > notification whenever the OS considers appropriate. Polling is > considered a bad practice in general. I'd agree, but not all OSes provide other mechanisms, in which case polling is the only remaining option.

Re: KIdleTime : provide a settable resolution for the polling backends?

2015-11-16 Thread Aleix Pol
On Mon, Nov 16, 2015 at 10:31 PM, René J.V. wrote: > Hi, > > Working on modernising the OS X plugin for KIdleTime, I realised that there > is no mechanism foreseen to set the frequency at which the current system > idle time should be sampled on those platforms that need to

Review Request 126084: Small KDeclarative cleanup

2015-11-16 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126084/ --- Review request for KDE Frameworks. Repository: kdeclarative

Re: Review Request 126069: [OS X] better integration of the cross-platform wallet runtime

2015-11-16 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126069/ --- (Updated Nov. 16, 2015, 12:59 p.m.) Review request for KDE Software on

Re: [OS X] should kauth-policy-gen be an app bundle?

2015-11-16 Thread René J . V . Bertin
On Monday November 16 2015 00:15:10 Aleix Pol wrote: >Please make a RR, if you had done we I would have reviewed it instead >of replying to this e-mail. Because reading the RR alert, clicking on the link, looking over it, clicking on the "Add comment" link and answering is faster and more

Re: KIdleTime : provide a settable resolution for the polling backends?

2015-11-16 Thread Martin Graesslin
On Tuesday, November 17, 2015 8:42:31 AM CET Martin Graesslin wrote: > On Monday, November 16, 2015 1:31:02 PM CET René J.V. Bertin wrote: > > Hi, > > > > Working on modernising the OS X plugin for KIdleTime, I realised that > > there > > is no mechanism foreseen to set the frequency at which the

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88456 --- should the file be added to ksnapshot? - Martin Gräßlin On

Re: KIdleTime : provide a settable resolution for the polling backends?

2015-11-16 Thread Martin Graesslin
On Monday, November 16, 2015 1:31:02 PM CET René J.V. Bertin wrote: > Hi, > > Working on modernising the OS X plugin for KIdleTime, I realised that there > is no mechanism foreseen to set the frequency at which the current system > idle time should be sampled on those platforms that need to use a