Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 09:56:04 + Build duration: 2 min 3 sec CHANGE SET Revision

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 39 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 09:56:04 + Build duration: 2 min 3 sec CHANGE SET Revision

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 09:56:04 + Build duration: 3 min 22 sec CHANGE SET Revision 9447c3e8bac843ceb43955ae8f8f259a362ef055

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 34 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 09:56:04 + Build duration: 3 min 22 sec CHANGE SET Revision 9447c3e8bac843ceb43955ae8f8f259a362ef055

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/#review90002 --- Ship it! Ship It! - Chusslove Illich On Дец. 23, 2015,

Re: Review Request 126489: Reduce unwanted type changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126489/#review90005 --- Ship it! Ship It! - Chusslove Illich On Дец. 23, 2015,

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/ --- (Updated Dec. 23, 2015, 3:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/ --- (Updated Dec. 23, 2015, 4:03 p.m.) Review request for KDE Frameworks and

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89992 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 15, 2015,

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 118 > > > > > > Why do we keep all this code? Personally I would keep it, becouse I think its related to some not

Re: Review Request 126400: [GCI] Fix some Clazy warnings

> On Dec. 23, 2015, 3:46 p.m., Aleix Pol Gonzalez wrote: > > Can you commit? > > Imran Tatriev wrote: > Done! ;) Next time, add a `REVIEW: 126400` statement after the commit message to link it directly. - Aleix --- This is an

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/ --- (Updated Dec. 23, 2015, 4:01 p.m.) Status -- This change has been

Re: Review Request 126489: Reduce unwanted type changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126489/ --- (Updated Dec. 23, 2015, 4:23 p.m.) Status -- This change has been

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 37 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/37/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 16:23:20 + Build duration: 9.9 sec CHANGE SET No changes

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 31 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 14:50:45 + Build duration: 7.9 sec CHANGE SET No changes

Re: Review Request 126440: Fix some Clazy warnings in kinit.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126440/ --- (Updated Dec. 23, 2015, 2:50 p.m.) Status -- This change has been

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126392/#review89994 --- Ship it! Thanks Andrey. Do you have push rights? - Aleix

Re: Review Request 126400: [GCI] Fix some Clazy warnings

> On Дек. 23, 2015, 8:46 п.п., Aleix Pol Gonzalez wrote: > > Can you commit? Done! ;) - Imran --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89993

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/#review8 --- src/klocalizedstring.cpp (line 1128)

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 54 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 14:58:35 + Build duration: 9.9 sec CHANGE SET No changes

Re: Review Request 126400: [GCI] Fix some Clazy warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126400/#review89993 --- Ship it! Can you commit? - Aleix Pol Gonzalez On Dec. 17,

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

> On Дец. 23, 2015, 8:24 пре п., Alexander Potashev wrote: > > Test question: should it be "1.5 other windows" or "1.5 other window"? > > > > The code in this patch seems to truncate the double to an integer and then > > use the appropriate plural form for the integer. But, for example, in >

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/#review89981 --- src/klocalizedstring.cpp (line 231)

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/#review89995 --- src/k7zip.cpp (line 118)

Review Request 126489: Reduce unwanted type changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126489/ --- Review request for KDE Frameworks and Chusslove Illich. Repository:

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 205 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/205/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Wed, 23 Dec 2015 14:22:00 + Build duration: 11 sec CHANGE SET No changes

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy-reserve-candidates`? > > Artur Puzio

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Dec. 23, 2015, 2:49 p.m., Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy-reserve-candidates`? > > Artur Puzio wrote: >

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/#review90023 --- - Sergio Martins On Dec. 23, 2015, 2:49 p.m., Artur Puzio

Review Request 126495: Install parsetrigrams tool for cross compiling.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126495/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

On 12/24/2015 08:14 AM, Simon Lees wrote: Sorry, I'm not on the list please CC me. On Thursday, December 10, 2015 2:39:36 PM CET Mark Gaiser wrote://> It won't depend on KWin. It will depend on an API provided by the KWayland library (tier 1). In runtime it depends on a wayland interface

RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

Sorry, I'm not on the list please CC me. On Thursday, December 10, 2015 2:39:36 PM CET Mark Gaiser wrote://> It won't depend on KWin. It will depend on an API provided by the KWayland library (tier 1). In runtime it depends on a wayland interface which in theory anybody can provide. In practice

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 11:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the

Review Request 126494: Add cross compile support for desktoptojson.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126494/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126429/ --- (Updated Gru 23, 2015, 8:50 po południu) Review request for KDE

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Gru 23, 2015, 3:49 po południu, Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy-reserve-candidates`? > > Artur Puzio

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 55 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 22:33:11 + Build duration: 2 min 0 sec CHANGE SET Revision

Re: Review Request 126429: Fixed all Clazy warnings level 1 and level 2

> On Dec. 23, 2015, 3:49 p.m., Aleix Pol Gonzalez wrote: > > src/k7zip.cpp, line 2029 > > > > > > I wouldn't get this all in. Is that suggested by > > `-Wclazy-reserve-candidates`? > > Artur Puzio wrote: >

Jenkins-kde-ci: kconfig master kf5-qt5 » Linux,gcc - Build # 55 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kconfig%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Dec 2015 22:33:11 + Build duration: 2 min 0 sec CHANGE SET Revision

Re: Review Request 126392: Fix some Clazy warnings in kcoreaddons

> On Дек. 23, 2015, 2:46 п.п., Aleix Pol Gonzalez wrote: > > Thanks Andrey. > > Do you have push rights? No, I do not have permission to push. I posted solution of errors in previous review. - Andrey --- This is an automatically

Re: Review Request 126476: Make it possible to use doubles as index for i18np*() calls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126476/ --- (Updated Dec. 23, 2015, 1:53 p.m.) Review request for KDE Frameworks and