Re: LGPL for Breeze QStyle and qtquickcontrols?

On Sat, May 28, 2016 14:53:54 Jaroslaw Staniek wrote: > All in all, If nobody just noted an issue with the licensing above maybe > nobody tried to place/distribute a non-GPL software on top of Plasma? That > would be the worst news of all to me. > > Please speak up someone else because it's a

Review Request 128039: Fix the window type of the progress widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128039/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description

Re: Review Request 128036: Fix default encoding to UTF-8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128036/ --- (Updated May 28, 2016, 2:41 p.m.) Status -- This change has been

Re: Review Request 128036: Fix default encoding to UTF-8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128036/ --- (Updated May 28, 2016, 4:36 p.m.) Review request for Kate and KDE

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128034/ --- (Updated May 28, 2016, 4:33 p.m.) Status -- This change has been

Re: Review Request 128035: KTextEditor: Fix foreground color of replaced text

> On May 28, 2016, 2:27 p.m., Albert Astals Cid wrote: > > I honestly don't think you need a review for such an obvious typo case as > > this. I am doing it, since the KDE frameworks are supposed to be reviewed, and I personally don't want to be an exception "just because I know better" ;)

Re: Review Request 128035: KTextEditor: Fix foreground color of replaced text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128035/ --- (Updated May 28, 2016, 7:30 p.m.) Status -- This change has been

Re: Review Request 128036: Fix default encoding to UTF-8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128036/#review95953 --- Ship it! Yes, this will work on Windows, and imho is the

Review Request 128036: Fix default encoding to UTF-8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128036/ --- Review request for Kate and KDE Frameworks. Repository: ktexteditor

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

> On May 28, 2016, 12:35 p.m., Kai Uwe Broulik wrote: > > Afaik you can add enum values as long as you don't cause the other's values > > to change or cause the compiler to choose a larger underlying type to fit > > the enum in. > > Dominik Haumann wrote: > Yes, afaik that is correct. >

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128034/#review95952 --- Ship it! Ship It! - Christoph Cullmann On May 28,

Re: Review Request 128035: KTextEditor: Fix foreground color of replaced text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128035/#review95950 --- Ship it! I honestly don't think you need a review for

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

> On May 28, 2016, 12:35 p.m., Kai Uwe Broulik wrote: > > Afaik you can add enum values as long as you don't cause the other's values > > to change or cause the compiler to choose a larger underlying type to fit > > the enum in. > > Dominik Haumann wrote: > Yes, afaik that is correct. >

Re: kio/kcookiejar visibility

El dissabte, 28 de maig de 2016, a les 0:33:05 CEST, René J.V. Bertin va escriure: > Hi, > > The kcookiejar kded service contains some code to make sure the posted > window ("Cookie Alert") is actually seen by the user. This uses window Ids > and KWindowSystem::setMainWindow(), and thus doesn't

Review Request 128035: KTextEditor: Fix foreground color of replaced text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128035/ --- Review request for Kate and KDE Frameworks. Bugs: 363441

Re: LGPL for Breeze QStyle and qtquickcontrols?

On 23 May 2016 at 09:38, Martin Graesslin wrote: > On Sunday, May 22, 2016 12:22:28 AM CEST Jaroslaw Staniek wrote: > > So we, in KDE, lack LGPL style code for our de-facto official look and > feel. > > This is the crucial point. Breeze is not the de-facto official look and >

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

> On May 28, 2016, 12:35 p.m., Kai Uwe Broulik wrote: > > Afaik you can add enum values as long as you don't cause the other's values > > to change or cause the compiler to choose a larger underlying type to fit > > the enum in. Yes, afaik that is correct. Then my question is: Which is the

Re: Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128034/#review95943 --- Afaik you can add enum values as long as you don't cause the

Review Request 128034: KateHighlightManger::defaultStyleCount() off by one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128034/ --- Review request for Kate and KDE Frameworks. Repository: ktexteditor

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 92 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 28 May 2016 12:17:01 + Build duration: 6 min 1 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 92 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 28 May 2016 12:17:01 + Build duration: 6 min 1 sec CHANGE SET Revision