Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 57 - Still Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 23 Jul 2016 01:53:55 + Build duration: 3 min 13 sec CHANGE SET Revision

Re: Review Request 120904: [KCharSelect] Handle characters outside BMP

2016-07-22 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120904/ --- (Updated July 23, 2016, 1:53 a.m.) Status -- This change has been

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 146 - Fixed!

2016-07-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 22:02:10 + Build duration: 22 min CHANGE SET Revision 3817dfdba5390fda2bc55636a3bce09f8ec414b9 by

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 146 - Fixed!

2016-07-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 22:02:10 + Build duration: 22 min CHANGE SET Revision 3817dfdba5390fda2bc55636a3bce09f8ec414b9 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 146 - Fixed!

2016-07-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 22:02:10 + Build duration: 4 min 45 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 146 - Fixed!

2016-07-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/146/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 22:02:10 + Build duration: 4 min 45 sec CHANGE SET Revision

Re: Review Request 128428: KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128428/ --- (Updated July 22, 2016, 10:10 p.m.) Status -- This change has been

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128471/ --- (Updated July 22, 2016, 10:09 p.m.) Status -- This change has been

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 10:01 p.m.) Status -- This change has been

Re: Review Request 128501: KNewFileMenu: Fix creating link to application

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128501/ --- (Updated July 22, 2016, 10:01 p.m.) Status -- This change has been

Re: Review Request 128501: KNewFileMenu: Fix creating link to application

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128501/#review97768 --- Ship it! Ship It! - David Faure On July 22, 2016, 4:53

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97767 --- Ship it! Ship It! - David Faure On July 22, 2016, 2:48

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-22 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128413/ --- (Updated July 22, 2016, 9:21 p.m.) Review request for KDE Frameworks,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 145 - Still Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 20:55:54 + Build duration: 7 min 49 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 145 - Still Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 20:55:54 + Build duration: 15 min CHANGE SET Revision 6fd238b461b4d51d02d4d24690c09452ada519d1 by

Re: Review Request 128490: Checksums tab: replace groupbox with horizontal separator

2016-07-22 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/ --- (Updated July 22, 2016, 8:55 p.m.) Status -- This change has been

Re: Review Request 128501: KNewFileMenu: Fix creating link to application

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128501/ --- (Updated July 22, 2016, 4:53 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 56 - Still Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/56/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 15:07:01 + Build duration: 3 min 7 sec CHANGE SET Revision

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 2:48 p.m.) Review request for KDE Frameworks and

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 12:05 p.m.) Review request for KDE Frameworks

Re: Review Request 128428: KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

2016-07-22 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128428/#review97758 --- +1 I confirm that it fixes bugs in kmail. Thanks :) -

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 158 - Fixed!

2016-07-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/158/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 10:12:23 + Build duration: 2 min 51 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 158 - Fixed!

2016-07-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/158/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 10:12:23 + Build duration: 2 min 51 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 144 - Still Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/144/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 09:59:06 + Build duration: 9 min 46 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 144 - Still Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/144/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 09:59:06 + Build duration: 9 min 42 sec CHANGE SET Revision baee8275cba183db8a3d8db4ad386b5b09b7cd21

Re: Review Request 127959: Adding missing license

2016-07-22 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127959/ --- (Updated July 22, 2016, 9:49 a.m.) Status -- This change has been

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97757 --- src/filewidgets/knewfilemenu.cpp (line 453)

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 9:45 a.m.) Review request for KDE Frameworks and

Re: Review Request 128150: [libkerfuffle] Ark application exits before job's finished

2016-07-22 Thread Elvis Angelaccio
> On June 16, 2016, 8:54 a.m., David Faure wrote: > > kerfuffle/jobs.cpp, line 127 > > > > > > The bug is on this line, don't use a direct connection. > > Anthony Fieroni wrote: > Yeah, i think so at first

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-22 Thread Elvis Angelaccio
> On July 21, 2016, 10:51 p.m., Martin Klapetek wrote: > > Just a tiny note - that separator is horizontal, not vertical ;) Oh, of course ;) - Elvis --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128490: Checksums tab: replace groupbox with horizontal separator

2016-07-22 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/ --- (Updated July 22, 2016, 9:07 a.m.) Review request for KDE Frameworks and

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
> On July 22, 2016, 7:22 a.m., David Faure wrote: > > src/filewidgets/knewfilemenu.cpp, line 481 > > > > > > Wait, isn't m_popupFiles the dir where we opened the popupmenu? Why the > > RemoveFilename then?

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 8:51 a.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 157 - Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/157/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 08:19:53 + Build duration: 7 min 29 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 143 - Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/143/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 08:05:36 + Build duration: 10 min CHANGE SET Revision 6d5026e1e28536632f2a27bbb1bf11b9dcce3405 by

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 143 - Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/143/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 22 Jul 2016 08:05:36 + Build duration: 6 min 37 sec CHANGE SET Revision

Re: Review Request 128471: [kio] Some fixes for KNewFileMenu.

2016-07-22 Thread David Faure
> On July 21, 2016, 9:52 p.m., David Faure wrote: > > src/filewidgets/knewfilemenu.cpp, line 497 > > > > > > I don't follow. Doesn't removing this connect, break the case of > > desktop files not from a

Re: Review Request 128490: Checksums tab: replace groupbox with vertical separator

2016-07-22 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128490/#review97747 --- Ship it! This is much better, thanks :) - Ragnar Thomsen

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97746 --- src/filewidgets/knewfilemenu.cpp (line 481)

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/#review97745 --- Looks good expect for the unrelated change

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 110 - Unstable!

2016-07-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/110/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Fri, 22 Jul 2016 06:33:52 + Build duration: 2 min 31 sec CHANGE SET

Re: Review Request 128499: KNewFileMenu: Fix suggestion of new filename when file already exist in desktop

2016-07-22 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128499/ --- (Updated July 22, 2016, 6:35 a.m.) Review request for KDE Frameworks and