Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-08-02 Thread Garret Wassermann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/ --- (Updated Aug. 3, 2016, 1:28 a.m.) Review request for KDE Frameworks,

Re: Review Request 128581: Make the default KMessageBoxDontAskAgainMemoryStorage save to QSettings

2016-08-02 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128581/#review98034 --- You also tested with kmessageboxtest, right?

Re: Review Request 128583: Make KrossUi and the command-line tool optional

2016-08-02 Thread Aleix Pol Gonzalez
> On Aug. 3, 2016, 3:28 a.m., Aleix Pol Gonzalez wrote: > > Why? > > Alexander Potashev wrote: > To make Kross easier to build for exotic (= non-Linux) platforms. (We > have no actual users for these options yet.) My experience says this tends to complicate the usage of the frameworks,

Re: Review Request 128586: Use a dedicated Qt logging category in KrossUi

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128586/ --- (Updated Aug. 3, 2016, 10:23 a.m.) Status -- This change has been

Re: Review Request 128585: Use a dedicated Qt logging category in qts/*

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128585/ --- (Updated Aug. 3, 2016, 2:23 a.m.) Status -- This change has been

Re: Review Request 128582: Remove unused KF5 dependencies

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/ --- (Updated Aug. 3, 2016, 2:23 a.m.) Status -- This change has been

Re: Review Request 128584: Use a dedicated Qt logging category in KrossCore's .cpp files

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128584/ --- (Updated Aug. 3, 2016, 2:23 a.m.) Status -- This change has been

Re: Review Request 128583: Make KrossUi and the command-line tool optional

2016-08-02 Thread Alexander Potashev
> On Авг. 3, 2016, 4:28 д.п., Aleix Pol Gonzalez wrote: > > Why? To make Kross easier to build for exotic (= non-Linux) platforms. (We have no actual users for these options yet.) - Alexander --- This is an automatically generated

Re: Review Request 128587: Move the QtScript backend into a separate directory

2016-08-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128587/#review98029 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 3,

Re: Review Request 128584: Use a dedicated Qt logging category in KrossCore's .cpp files

2016-08-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128584/#review98026 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 3,

Re: Review Request 128583: Make KrossUi and the command-line tool optional

2016-08-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128583/#review98025 --- Why? - Aleix Pol Gonzalez On Aug. 3, 2016, 1:36 a.m.,

Re: Review Request 128582: Remove unused KF5 dependencies

2016-08-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128582/#review98024 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 3,

Review Request 128590: Let kpackagetool5 generate appstream information for kpackage components

2016-08-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128590/ --- Review request for KDE Frameworks, Plasma, Matthias Klumpp, and Harald

Review Request 128586: Use a dedicated Qt logging category in KrossUi

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128586/ --- Review request for KDE Frameworks. Repository: kross Description

Review Request 128587: Move the QtScript backend into a separate directory

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128587/ --- Review request for KDE Frameworks. Repository: kross Description

Review Request 128585: Use a dedicated Qt logging category in qts/*

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128585/ --- Review request for KDE Frameworks. Repository: kross Description

Review Request 128584: Use a dedicated Qt logging category in KrossCore's .cpp files

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128584/ --- Review request for KDE Frameworks. Repository: kross Description

Review Request 128583: Make KrossUi and the command-line tool optional

2016-08-02 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128583/ --- Review request for KDE Frameworks. Repository: kross Description

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-08-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/12/#review98023 --- src/unit.h (line 53)

Re: Low quality input country flags

2016-08-02 Thread Albert Astals Cid
El diumenge, 31 de juliol de 2016, a les 17:13:07 CEST, Viorel-Cătălin Răpițeanu va escriure: > Hi all, > > I've got a question related to the flags used to display the input layout > in plasma. > To explain, the flags used for the input sources either don't have the > correct aspect ratio,

Review Request 128580: If we pass a QIcon as an argument to IconItem::Source, use it

2016-08-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128580/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

2016-08-02 Thread Andreas Sturmlechner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/#review98020 --- Works for me, thanks! - Andreas Sturmlechner On Aug. 2,

Re: Review Request 128575: KRearrangeColumnsProxyModel: fix assert when running against debug build of Qt

2016-08-02 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128575/ --- (Updated Aug. 2, 2016, 6:15 p.m.) Status -- This change has been

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/ --- (Updated Aug. 2, 2016, 6:14 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 117 - Fixed!

2016-08-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/117/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 02 Aug 2016 16:45:41 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 117 - Fixed!

2016-08-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/117/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 02 Aug 2016 16:45:41 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Unstable!

2016-08-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/116/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 02 Aug 2016 16:23:20 + Build duration: 10 min CHANGE SET Revision

Review Request 128579: Use KPackage to install Plasma Packages

2016-08-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128579/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128566: [xcb] Use a KSelectionWatcher to monitor the compositing selection

2016-08-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128566/ --- (Updated Aug. 2, 2016, 4:26 p.m.) Status -- This change has been

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-08-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128398/ --- (Updated Aug. 2, 2016, 2:24 p.m.) Status -- This change has been

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-08-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128515/#review98004 --- Ship it! He, this is the very same patch that I found in

Re: Review Request 128578: KRearrangeColumnsProxyModel: fix assert in index(0, 0) on empty model

2016-08-02 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128578/#review97998 --- Ship it! (assuming you approve of my change) - Daniel

Re: Review Request 128575: KRearrangeColumnsProxyModel: fix assert when running against debug build of Qt

2016-08-02 Thread Daniel Vrátil
> On Aug. 2, 2016, 2:24 p.m., David Faure wrote: > > I'll write a corresponding unittest. Why was the source index invalid? > > rowCount==0 in the source model? Yes, the source model was empty. - Daniel --- This is an automatically

Review Request 128578: KRearrangeColumnsProxyModel: fix assert in index(0, 0) on empty model

2016-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128578/ --- Review request for KDE Frameworks and Daniel Vrátil. Repository:

Re: Review Request 128577: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128577/ --- (Updated Aug. 2, 2016, 12:39 p.m.) Status -- This change has been

Re: Review Request 128575: KRearrangeColumnsProxyModel: fix assert when running against debug build of Qt

2016-08-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128575/#review97996 --- I'll write a corresponding unittest. Why was the source

Review Request 128575: KRearrangeColumnsProxyModel: fix assert when running against debug build of Qt

2016-08-02 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128575/ --- Review request for KDE Frameworks and David Faure. Repository:

Review Request 128576: [xcb] Ensure the compositingChanged signal is emitted if NETEventFilter is recreated

2016-08-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128576/ --- Review request for KDE Frameworks and Plasma. Bugs: 362531

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

2016-08-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- (Updated Aug. 2, 2016, 10:53 a.m.) Review request for KDE Frameworks,

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 48 - Unstable!

2016-08-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/48/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 02 Aug 2016 08:24:53 + Build duration: 11 min CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 47 - Unstable!

2016-08-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/47/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 02 Aug 2016 08:24:53 + Build duration: 11 min CHANGE SET Revision

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

2016-08-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/#review97993 --- Ship it! Ship It! - Marco Martin On Aug. 2, 2016, 8:26

Re: Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

2016-08-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- (Updated Aug. 2, 2016, 10:26 a.m.) Review request for KDE Frameworks,

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/ --- (Updated Aug. 2, 2016, 8:24 a.m.) Status -- This change has been

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-02 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/#review97992 --- Ship it! Ship It! - Ivan Čukić On Aug. 2, 2016, 5:47

Review Request 128572: [autotest] Extend ThemeTest with a case for compositing changes

2016-08-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128572/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository:

Re: Review Request 128567: Add a convenient API to query the windowing system/platform used by Qt

2016-08-02 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128567/#review97991 --- No further comments from here. I'll give Ivan chance for him