Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-17 Thread Sune Vuorela
> On Sept. 16, 2016, 4:57 p.m., Sune Vuorela wrote: > > autotests/kconfigtest.cpp, line 1376 > > > > > > Isn't a QSKIP if user is root in the beginning of the test a better > > approach ? > > Gleb Popov wrote:

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Leslie Zhai
> On 九月 18, 2016, 10:41 a.m., Christoph Feck wrote: > > I do not understand the bug report you linked to. > > > > After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar > > because the message text is really long, and after clicking the Details > > button, those are correc

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Christoph Feck
> On Sept. 18, 2016, 4:41 a.m., Christoph Feck wrote: > > I do not understand the bug report you linked to. > > > > After applying rev 2 of this patch, I see that KMessageBox uses a scrollbar > > because the message text is really long, and after clicking the Details > > button, those are corr

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128768/#review99246 --- I do not understand the bug report you linked to. After appl

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Leslie Zhai
> On 九月 15, 2016, 9:41 p.m., Kai Uwe Broulik wrote: > > tests/kmessageboxtest.cpp, line 232 > > > > > > QString QString::repeated(int times) const > > > > Returns a copy of this string repeated the speci

Re: Review Request 128768: Directly show detailsGroup for KMessageBox::detailedSorry by default

2016-09-17 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128768/ --- (Updated 九月 18, 2016, 10 a.m.) Review request for KDE Frameworks and Davi

Re: Review Request 126086: [OS X] backend ported from KDE4

2016-09-17 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126086/ --- (Updated Sept. 17, 2016, 7:41 p.m.) Review request for KDE Software on Ma

Re: Scrap baloo?

2016-09-17 Thread Christoph Cullmann
Hi, > Hi, > > On 16 September 2016 at 01:04, Christoph Cullmann wrote: => Opinions? >>> >>> It would be nice to hear what Vishesh, Pinak and Boudhayan think about >>> this. > > I prefer getting familiar with the code as well as having a mile-high > view of what does what before I start lay

Re: Help requested with KAuth backends : OS X

2016-09-17 Thread René J . V . Bertin
Sune Vuorela wrote: > I know nothing about mac, and only have a limited knowledge of KAuth, on > linux, but I'll give it a go replying anyways. Thanks, that's a start :) > Whenever an application wants something that requires elevated > priviledges, it contacts policykit, that does the authoriza

Re: Help requested with KAuth backends : OS X

2016-09-17 Thread Sune Vuorela
On 2016-09-17, René J.V Bertin wrote: > Can someone please give me some help setting up a working Mac backend for > KAuth? I know nothing about mac, and only have a limited knowledge of KAuth, on linux, but I'll give it a go replying anyways. On linux, there is a thing called policykit. It is

Help requested with KAuth backends : OS X

2016-09-17 Thread René J . V . Bertin
Hi, Can someone please give me some help setting up a working Mac backend for KAuth? I currently have the basics right after porting the modifications I made to the KDE4 predecessor, but there's a nasty not-so-little detail I've not yet tackled: the helper process that does the actual work. The