Re: Review Request 129658: KConfigDialogManager: cleanup static maps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101623 --- src/kconfigdialogmanager.cpp

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 328 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/328/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:58:48 + Build duration: 7 min 39 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kjs master stable-kf5-qt5 » Linux,gcc - Build # 154 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kjs%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/154/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:43:42 + Build duration: 3 min 1 sec CHANGE SET No changes

Jenkins-kde-ci: kjs master kf5-qt5 » Linux,gcc - Build # 151 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kjs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/151/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:22:55 + Build duration: 30 sec CHANGE SET No changes

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 131 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:06:45 + Build duration: 43 sec CHANGE SET No changes

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 126 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/126/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:01:07 + Build duration: 1 min 5 sec CHANGE SET No changes

Re: Scheduled downtime: spring.kde.org

Hi all, The system upgrade has now been completed - all of the previously mentioned services should now be back online. Please let us know if you find anything which is not functioning correctly. Thanks, Ben

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? >

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? >

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Дек. 27, 2016, 11:16 след обяд, Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? >

Re: All Frameworks modules are now available as repositories on Phabricator

On Wed, Dec 28, 2016 at 8:56 AM, Luigi Toscano wrote: > Elvis Angelaccio ha scritto: >> On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano >> wrote: >>> ... so that it's easier to use Differential for reviews. >> >> Thanks! >> What about tasks?

[Differential] [Updated] D2854: New: ECMAddQch, for generating qch & doxygen tag files

ltoscano added a reviewer: KDE Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks, #kde_buildsystem Cc: shumski, kfunk,

[Differential] [Updated] D3733: Force colored warnings in ninja's output

ltoscano added a reviewer: KDE Buildsystem. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3733 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #frameworks, #kde_buildsystem

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. > > Elvis Angelaccio wrote: > Why? Isn't it deprecated? >

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Dec. 27, 2016, 9:18 p.m., Christoph Feck wrote: > > className() is just a char pointer. Is it possible to convert the maps to > > not use QString? I don't think so, they are public api, e.g. `static QHash *changedMap();` - Elvis

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

> On Dec. 27, 2016, 9:16 p.m., Albert Astals Cid wrote: > > -1 Don't break what is not broken. > > > > First thing i check "KButtonGroup", is already wrong to be removed. Why? Isn't it deprecated? https://api.kde.org/frameworks/kdelibs4support/html/classKButtonGroup.html - Elvis

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/#review101609 --- There is autotests/kdatecomboboxtest.cpp. Does it need

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/#review101613 --- I'd say this could really do with some autotests - Albert

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101612 --- className() is just a char pointer. Is it possible to

Re: Review Request 129659: KConfigDialogManager: improve documentation for custom widgets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129659/#review101611 --- Ship it! Ship It! - Albert Astals Cid On Dec. 16,

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101610 --- -1 Don't break what is not broken. First thing i check

[Differential] [Accepted] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

aacid accepted this revision. aacid added a reviewer: aacid. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH kglobalaccel-test-mode REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES

Re: Review Request 129659: KConfigDialogManager: improve documentation for custom widgets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129659/#review101607 --- Ping? - Elvis Angelaccio On Dec. 16, 2016, 3:44 p.m.,

Re: Review Request 129658: KConfigDialogManager: cleanup static maps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129658/#review101606 --- Ping? - Elvis Angelaccio On Dec. 16, 2016, 3:05 p.m.,

Re: All Frameworks modules are now available as repositories on Phabricator

Elvis Angelaccio ha scritto: > On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano > wrote: >> ... so that it's easier to use Differential for reviews. > > Thanks! > What about tasks? Should we create a Workboard for the Frameworks > project? Or is it planned that each

Re: All Frameworks modules are now available as repositories on Phabricator

On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano wrote: > ... so that it's easier to use Differential for reviews. Thanks! What about tasks? Should we create a Workboard for the Frameworks project? Or is it planned that each framework be a Project with its own workboard?

Re: Minimum required cmake version

On Tue, Dec 27, 2016 at 7:25 PM, Sven Brauch wrote: > On 27/12/16 19:23, Aleix Pol wrote: >> Makes sense, although you still won't be able to compile these >> frameworks on CentOS 6.8 even if we fix that, right? > I have CMake 3.6 on CentOS 6.8, it's just called "camke3"

Re: Minimum required cmake version

On 27/12/16 19:23, Aleix Pol wrote: > Makes sense, although you still won't be able to compile these > frameworks on CentOS 6.8 even if we fix that, right? I have CMake 3.6 on CentOS 6.8, it's just called "camke3" instead of "cmake". That's why I was running cmake 2.8 so far, and noticed this

Re: Minimum required cmake version

On Tue, Dec 27, 2016 at 7:20 PM, Sven Brauch wrote: > Hi, > > On 27/12/16 19:18, Aleix Pol wrote: >> Have you checked that changing to cmake 3.0 actually solves this >> problem? > I have 3.6 on the same system and with that it works. I don't have 3.0. :/ > > However, 3.0 docs

Re: Minimum required cmake version

Hi, On 27/12/16 19:18, Aleix Pol wrote: > Have you checked that changing to cmake 3.0 actually solves this > problem? I have 3.6 on the same system and with that it works. I don't have 3.0. :/ However, 3.0 docs explicitly mentions Q_GADGET. Greetings, Sven signature.asc Description: OpenPGP

Re: Minimum required cmake version

On Tue, Dec 27, 2016 at 5:48 PM, Sven Brauch wrote: > Hi, > > building on CentOS 6.8, I noticed some frameworks (namely KAuth, > KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to > be related with moc'ing the Q_GADGET macro. Still, they specify cmake >

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 327 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/327/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 17:57:06 + Build duration: 16 min CHANGE SET Revision

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/ --- (Updated Dec. 27, 2016, 6:12 p.m.) Status -- This change has been

Minimum required cmake version

Hi, building on CentOS 6.8, I noticed some frameworks (namely KAuth, KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to be related with moc'ing the Q_GADGET macro. Still, they specify cmake 2.8 as the minimum required cmake version. Do we - attempt to fix this with cmake

Re: Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- (Updated Dec. 27, 2016, 5:46 p.m.) Review request for KDE Frameworks and

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/#review101602 --- src/kwindowsystem.cpp (lines 728 - 732)

Re: Review Request 129706: Don't focus progress windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129706/#review101604 --- Ship it! Ship It! - Martin Gräßlin On Dec. 27, 2016,

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 280 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/280/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 27 Dec 2016 17:21:19 + Build duration: 11 min CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 280 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/280/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 27 Dec 2016 17:21:19 + Build duration: 11 min CHANGE SET

[Differential] [Closed] D3812: Deprecate Plasma::Package API in PluginLoader

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4798310ed788: Deprecate Plasma::Package API in PluginLoader (authored by graesslin). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3812?vs=9366=9395

Review Request 129709: Fix checking for valid date entered

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129709/ --- Review request for KDE Frameworks and John Layt. Repository:

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 27, 2016, 5:40 p.m.) Review request for KDE Software on

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- (Updated Dec. 27, 2016, 5:31 p.m.) Review request for KDE Software on

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126291/ --- (Updated Dec. 27, 2016, 5 p.m.) Review request for KDE Software on Mac

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 15:20:23 + Build duration: 3 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/390/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 15:20:23 + Build duration: 3 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 393 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/393/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 15:20:23 + Build duration: 3 min 8 sec CHANGE SET Revision

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 393 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/393/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 15:20:23 + Build duration: 3 min 8 sec CHANGE SET Revision

Re: All Frameworks modules are now available as repositories on Phabricator

On Monday, 26 December 2016 01:19:41 CET Luigi Toscano wrote: > ... so that it's easier to use Differential for reviews. \o/ Thanks a lot for this! -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

Re: Review Request 129706: Don't focus progress windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129706/ --- (Updated Dec. 27, 2016, 12:14 p.m.) Review request for KDE Frameworks,

Re: Review Request 129706: Don't focus progress windows

> On Dec. 26, 2016, 4:53 p.m., Martin Gräßlin wrote: > > Use QWidget::setAttribute with Qt::WA_ShowWithoutActivating doh, thanks! I was just looking at the window flags... - Martin Tobias Holmedahl --- This is an automatically

Re: Review Request 129706: Don't focus progress windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129706/ --- (Updated Dec. 27, 2016, 12:13 p.m.) Review request for KDE Frameworks,

Re: Review Request 129706: Don't focus progress windows

> On Dec. 26, 2016, 4:24 p.m., Anthony Fieroni wrote: > > src/kwidgetjobtracker.cpp, line 82 > > > > > > You can try > > vi->setWindowFlags(windowFlags() | Qt::WindowDoesNotAcceptFocus); > > > > I

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/#review101585 --- Ship it! Ship It! - Marco Martin On Dec. 26, 2016,

[Differential] [Accepted] D3812: Deprecate Plasma::Package API in PluginLoader

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH deprecate-package-in-pluginloader REVISION DETAIL https://phabricator.kde.org/D3812 EMAIL PREFERENCES