[Differential] [Request, 18 lines] D4604: KConfig: stop exporting and installing KConfigBackend.

dfaure created this revision. dfaure added a reviewer: mdawson. dfaure added a subscriber: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY It can't possibly have been used anywhere, because it's not in the KConfig API anywhere. The intended way to use this API

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 251 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 14 Feb 2017 06:56:07 + Build duration: 2 min 3 sec CHANGE SET No changes JUNIT RESULTS Name: (roo

[Differential] [Request, 12 lines] D4603: Use sentence style capitalization with label texts of edit fields

kossebau created this revision. kossebau added a reviewer: Kate. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Cmp. https://community.kde.org/KDE_Visual_Design_Group/HIG/Capitalization REPOSITORY R39 KT

[Differential] [Accepted] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

cfeck accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4564 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, cfeck Cc: #f

[Differential] [Commented On] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

elvisangelaccio added a comment. In https://phabricator.kde.org/D4564#86076, @cfeck wrote: > Does calling setHideDelay(0) also need to immediately hide()? It seems not necessary, `setHideDelay(0)` will set a 0 interval on the timer, which causes `timeout` to be emitted (and this

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 434 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/434/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 22:39:11 + Build duration: 9 min 31 sec CHANGE SET Revision 51c91f5a18036029ac0f405d9e4389ee5d

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 429 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/429/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 22:22:13 + Build duration: 6 min 42 sec CHANGE SET Revision 24ff23c6943b1156f29c80de5586db73bee7d2f5 b

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 429 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/429/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 22:22:13 + Build duration: 6 min 42 sec CHANGE SET Revision 24ff23c6943b1156f29c80de5586db73bee7d2f5 b

[Differential] [Commented On] D4595: Port from QDateTime::currentDateTime() to QElapsedTimer

dfaure added inline comments. INLINE COMMENTS > slave.cpp:190 > if (d->m_pid && KIOPrivate::isProcessAlive(d->m_pid)) { > -int delta_t = > d->contact_started.secsTo(QDateTime::currentDateTime()); > +int delta_t = d->contact_started.elapsed(); > //qDebug() << "slave

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 428 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/428/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 22:05:15 + Build duration: 6 min 54 sec CHANGE SET Revision 1f0dfc347cad8a438ed398e1ad7989347482eb3d

[Differential] [Updated, 67 lines] D4589: EditorConfig module

gszymaszek updated this revision to Diff 11308. gszymaszek added a comment. Added version checking support. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4589?vs=11263&id=11308 REVISION DETAIL https://phabricator.kde.org/D4589 AFFECTED FILE

[Differential] [Updated, 206 lines] D4576: [WIP]: integrate drop menu and filecopy drop menu

mart updated this revision to Diff 11307. mart added a comment. - crash-- REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4576?vs=11305&id=11307 BRANCH arcpatch-D4576 REVISION DETAIL https://phabricator.kde.org/D4576 AFFECTED FILES

[Differential] [Updated] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

cfeck added a comment. Does calling setHideDelay(0) also need to immediately hide()? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4564 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, cfeck Cc: #framewor

[Differential] [Commented On] D4589: EditorConfig module

dhaumann added a comment. Hm, looking at libgit2 I have: -rwxr-xr-x 1 root root 906728 Dez 2 12:13 libgit2.so.0.24.0 lrwxrwxrwx 1 root root 17 Jan 7 20:05 libgit2.so.24 -> libgit2.so.0.24.0 Looking at editorconfig, I have: lrwxrwxrwx 1 root root20 Feb 12 17:17

[Differential] [Updated] D4576: [WIP]: integrate drop menu and filecopy drop menu

mart updated the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4576 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, #frameworks, lesliezhai, ali-mohame

[Differential] [Updated, 204 lines] D4576: [WIP]: integrate drop menu and filecopy drop menu

mart updated this revision to Diff 11305. mart added a comment. - support drag on normal desktop REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4576?vs=11235&id=11305 BRANCH arcpatch-D4576 REVISION DETAIL https://phabricator.kde.org

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. editorconfig-core-lua doesn’t check C library version (CMakeLists.txt:49 ). Actually I’m not sure if setting oldest accept

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 427 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/427/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 14:09:17 + Build duration: 6 min 52 sec CHANGE SET Revision 344c500a686e27427dc3eeeab7c5aedf4150e939

[Differential] [Closed] D4595: Port from QDateTime::currentDateTime() to QElapsedTimer

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4595 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, apol Cc: #frameworks

[Differential] [Accepted] D4595: Port from QDateTime::currentDateTime() to QElapsedTimer

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D4595 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, apol

[Differential] [Commented On] D4589: EditorConfig module

gszymaszek added a comment. It seems there isn’t any version string in library headers (editorconfig.h, editorconfig_handle.h), is there any other cross-distribution way to obtain library version? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4589 EMA

[Differential] [Accepted] D4190: Update file type on save only if path changes

cullmann accepted this revision. cullmann added a reviewer: cullmann. cullmann added a comment. This revision is now accepted and ready to land. Yes, looks better that way. REVISION DETAIL https://phabricator.kde.org/D4190 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Request, 7 lines] D4595: Port from QDateTime::currentDateTime() to QElapsedTimer

dfaure created this revision. dfaure added a subscriber: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY - fixes a race condition (due to tzset inside QDateTime) - should be faster TEST PLAN compiled qt5+kf5 with clang,libc++,tsan; then ran kio's threadtest

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 430 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/430/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 11:15:39 + Build duration: 9 min 9 sec CHANGE SET Revision c00a33bc8cd46a1fa0ad3c318d809d87faa5

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 430 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/430/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 13 Feb 2017 11:15:39 + Build duration: 9 min 9 sec CHANGE SET Revision c00a33bc8cd46a1fa0ad3c318d809d87faa5

[Differential] [Updated, 253 lines] D4537: EditorConfig support

gszymaszek updated this revision to Diff 11279. gszymaszek added a comment. Fixed src/CMakeLists.txt to make EditorConfig support truly optional, removed interpret and interpretLine functions (so parsing is back in parse), simplified EditorConfig class constructor, fixed memory leak in Docume

[Differential] [Updated] D4537: EditorConfig support

gszymaszek marked 6 inline comments as done. gszymaszek added inline comments. INLINE COMMENTS > dhaumann wrote in editorconfig.cpp:23 > Better is to write: > > EditorConfig::EditorConfig(KTextEditor::DocumentPrivate *document) > : m_document(document) > , m_handle(0) > { >

[Differential] [Commented On] D4537: EditorConfig support

gszymaszek added a comment. In https://phabricator.kde.org/D4537#85846, @dhaumann wrote: > Btw, did you copy some code from another project? If so, we need to be careful, since KTextEditor is LGPLv+2. I’ve used mentioned gnome-builder’s file

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/#review102521 --- Can you comment on a proposed Qt fix for this issue, which w