D4917: [Breeze Plasma Theme] Improve action-overlay icons

andreaska added a comment. F2753390: action-overlays.svgz only a draft (not finished, only that you can review something) F2753393: overlayScreenshot.png REPOSITORY R242 Plasma Framework (Library) REVISION

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas updated this revision to Diff 12253. jsalatas added a comment. Diff updated. Hope I addressed all issues :\ See some additional comments/clarifications below: In https://phabricator.kde.org/D4947#92889, @mwolff wrote: > should be scrollToPos, c -> cursor, and make the

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review102738 --- src/ioslaves/file/file.cpp (line 1378)

D4847: KAuth integration in document saving

martinkostolny marked 4 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4847 To: martinkostolny, dhaumann, #ktexteditor Cc: dfaure, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, #frameworks,

D4847: KAuth integration in document saving

martinkostolny updated this revision to Diff 12251. martinkostolny added a comment. Thanks a lot for all the thoughts and suggestions! I tried to work them in, but I need help with some of them. I'm struggling with the atomic rename. I still find Christoph's suggestion (save to temp

Re: Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129987/ --- (Updated March 6, 2017, 9:58 p.m.) Status -- This change has been

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik added a comment. The icons are copied from the Breeze icon set. Granted, it's an "emblem" icon and not one from "actions" which is arguably wrong but I wanted to be consistent with Dolphin here… also, I expressed my frustration with our current visual design workflow numerous times,

Re: Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129987/#review102735 --- Ship it! Yes, small lists, but many of them ;) - David

Re: Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

> On March 6, 2017, 8:01 a.m., David Faure wrote: > > src/gui/kstandardshortcut.cpp, line 203 > > > > > > This search doesn't need to restart at i+1, it could restart at other > > (which is further along). > >

Re: Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129987/ --- (Updated March 6, 2017, 8:55 p.m.) Review request for KDE Frameworks.

D4917: [Breeze Plasma Theme] Improve action-overlay icons

hein added a comment. I wouldn't have veto'd it, but FWIW I think those icons don't work - their stem strength is much wider than Breeze lineart icons, they feel very out of place in our UX. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917

D4911: add Baloo DBus signals for moved or removed files

cullmann added a comment. In https://phabricator.kde.org/D4911#93007, @mgallien wrote: > > I was hoping to support the same file indexer that Plasma is using hence my work on Baloo. On my roadmap, I plan to also support Tracker. > > For Windows and Android, I have implemented an

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

jsalatas added a comment. Thank you all for your feedback. I'll update soon INLINE COMMENTS > mwolff wrote in view.h:479 > why is this not the document end pos? because of virtual cursors? if so, > please rename this to `viewEndCursor()` or similar, I don't see why this > should be

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

tfry added a comment. Hi thanks for adding me in CC. My use case was saving and restoring a certain scroll position. Thus, what I am missing, immediately, is a way to retrieve the current scroll position. The proposed startLine() goes some length, here, but does not provide columns (in case

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

broulik added a dependent revision: D4962: [Folder View] Open context menu when pressing Menu key. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai,

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/ --- (Updated March 6, 2017, 3:51 p.m.) Review request for KDE Frameworks,

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

This revision was automatically updated to reflect the committed changes. Closed by commit R242:94a6a168cf45: [Containment Interface] Trigger context menus on pressing "Menu" key (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4924 To: broulik, #plasma, #vdg, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4926: Fix cmake warning

This revision was automatically updated to reflect the committed changes. Closed by commit R135:c6305f5edbbd: Fix cmake warning (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4926?vs=12135=12241 REVISION

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

mwolff added a comment. In https://phabricator.kde.org/D4947#92995, @anthonyfieroni wrote: > Milian had in mind that you can take charge of Kompare and implement your ideas rather than release new app. :) Hihi, while not really my intention, that would of course the best way

D4926: Fix cmake warning

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D4926 To: apol, #frameworks, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D4917: [Breeze Plasma Theme] Improve action-overlay icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:badf8acfe2c0: [Breeze Plasma Theme] Improve action-overlay icons (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D4917: [Breeze Plasma Theme] Improve action-overlay icons

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg, andreask, alex-l, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg, andreask, alex-l Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4891: Port away from setRoleNames where easily possible

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dfbf2c1c302e: Port away from setRoleNames where easily possible (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

dhaumann added a reviewer: tfry. dhaumann added a comment. Add Thomas, since he iirc also was interested in such an api once. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4947 To: jsalatas, #ktexteditor, #frameworks, mwolff, tfry Cc: dhaumann, anthonyfieroni,

D4947: [KTextEditor] Expose additional internal View's functionality to the public API

dhaumann added inline comments. INLINE COMMENTS > mwolff wrote in view.h:464 > should be scrollToPos, c -> cursor, and make the cursor const I would even favour setScrollPosition(). Avoid abbreviations whenever possible. And we already have many other API that contains the full word position.

Re: Review Request 129987: Sanitize shortcut list on read/write from kdeglobals

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129987/#review102732 --- src/gui/kstandardshortcut.cpp (line 203)