Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

2017-04-30 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129983/#review103165 --- src/ioslaves/file/file.h (line 116)

D5674: Solve a visibility conflict for meinproc5

2017-04-30 Thread Luigi Toscano
ltoscano edited the test plan for this revision. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5674 To: ltoscano, vonreth Cc: #frameworks, #documentation, skadinna, kfunk

D5674: Solve a visibility conflict for meinproc5

2017-04-30 Thread Luigi Toscano
ltoscano added a project: Windows. ltoscano removed a subscriber: Windows. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5674 To: ltoscano, vonreth Cc: #frameworks, #documentation, skadinna, kfunk

D5674: Solve a visibility conflict for meinproc5

2017-04-30 Thread Luigi Toscano
ltoscano created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REVISION SUMMARY This seems to affect only mingw, which can't link meinproc5 as the symbol exported affects in the sources

D5656: Adds method to force the reloading of a document

2017-04-30 Thread Pedro Arthur P. R. Duarte
pedroarthurp added a comment. https://phabricator.kde.org/D5673 shows a use-case for this feature. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5656 To: pedroarthurp, dfaure, brauch, dhaumann, cullmann Cc: kwrite-devel, #frameworks

D5656: Adds method to force the reloading of a document

2017-04-30 Thread Pedro Arthur P. R. Duarte
pedroarthurp added a dependent revision: D5673: Add option to reload a file without user confirmation after the execution of a external script. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D5656 To: pedroarthurp, dfaure, brauch, dhaumann, cullmann Cc:

D4911: add Baloo DBus signals for moved or removed files

2017-04-30 Thread Matthieu Gallien
mgallien added a comment. In https://phabricator.kde.org/D4911#106088, @dfaure wrote: > Could this be made more lightweight by adding a precise subscription method rather than signal broadcasts? I will work on this solution. > The interested application would register into

D5394: KAuth integration in document saving - vol. 2

2017-04-30 Thread Martin Kostolný
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f7a9573d973e: KAuth integration in document saving - vol. 2 - various security improvements (authored by martinkostolny). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5394?vs=14013=14020#toc

D4911: add Baloo DBus signals for moved or removed files

2017-04-30 Thread David Faure
dfaure added a comment. Could this be made more lightweight by adding a precise subscription method rather than signal broadcasts? The interested application would register into baloo (using dbus or C++, not sure what's applicable here), saying "please do inform me about changes" or

D5394: KAuth integration in document saving - vol. 2

2017-04-30 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. The strace snipped you posted looks good to me! That new files are created with 0644 permissions is fine, the default umask is 022 anyway so running "echo test > file" as root would

D4711: Ungrab mouse on menu close

2017-04-30 Thread Anthony Fieroni
anthonyfieroni updated this revision to Diff 14014. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4711?vs=11600=14014 REVISION DETAIL https://phabricator.kde.org/D4711 AFFECTED FILES src/scriptengines/qml/plasmoid/appletinterface.cpp

D4711: Ungrab mouse on menu close

2017-04-30 Thread Anthony Fieroni
anthonyfieroni added a reviewer: davidedmundson. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4711 To: anthonyfieroni, #plasma, mart, broulik, davidedmundson Cc: mvourlakos, plasma-devel, #frameworks, spstarr, progwolff, lesliezhai, ali-mohamed,