D10220: AppArmor: Fix style

2018-01-31 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-apparmor (branched from master) REVISION DETAIL https://phabricator.kde.org/D10220 To: nibags, #framework_syntax_highlighting, dhaumann Cc: #frameworks,

D10220: AppArmor: Fix style

2018-01-31 Thread Nibaldo González
nibags added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10220 To: nibags, #framework_syntax_highlighting, dhaumann Cc: #frameworks, michaelh, ngraham

D10220: AppArmor: Fix style

2018-01-31 Thread Nibaldo González
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. nibags requested review of this revision. REVISION SUMMARY Minor fixes that I did not notice in the last update of AppArmor ( Sorry :( ). This modifies

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 59 - Still Unstable!

2018-01-31 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/59/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 31 Jan 2018 22:56:29 + Build duration: 6 min 17 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

2018-01-31 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/56/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 31 Jan 2018 22:56:29 + Build duration: 6 min 17 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still unstable!

2018-01-31 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/32/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 22:56:29 + Build duration: 4 min 58 sec and counting

D10211: Suggestion for emacs icon

2018-01-31 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: andreaska. REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham, andreaska Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10212: New virtualbox icon

2018-01-31 Thread Elvis Angelaccio
elvisangelaccio added a reviewer: andreaska. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg, andreaska Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Lovely. Thank you! REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. On it. I'll try to squeeze in a spotify icon before end of icon REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Alright, should I submit in some kind of form or just in a plain comment? name: Linus Shoravi @: linusshor...@gmail.com REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham,

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Also, as with D10211: Suggestion for emacs icon we need an email address to associate with your name before we land the patch. Thanks! REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc:

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. One final request: if you attach a nice screenshot of the icon in use, perhaps on your Task Manager/Dock like you did with the Emacs icon, I'll include it in this coming weekend's weekly round-up

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. Looks great, works great! Big thumbs-up from me. As with the emacs icon, I'll leave this open for a while just in case anyone else has comments or suggestions. REVISION DETAIL

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. That's fine for now. Since this patch wasn't created using arcanist, I'll have to manually apply the name and email anyway. Once we get you set up with arcanist, neither of us will have to do this anymore! REVISION DETAIL https://phabricator.kde.org/D10211 To:

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Yep, I saw that as well, and it also didnt have a bottom shadowed line. Now it does :) REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi updated this revision to Diff 26292. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10212?vs=26290=26292 REVISION DETAIL https://phabricator.kde.org/D10212 AFFECTED FILES icons-dark/apps/48/virtualbox.svg icons/apps/48/virtualbox.svg To: lshoravi, #breeze, ngraham,

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Getting there! This diff applies better and renders as intended. I have just one more nitpick: It's not exactly the same size as other perfectly square icons, like `yakuake.svg` and `utilities-system-monitor.svg` It would be nice to have it match that size so that

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Luigi Toscano
ltoscano added a comment. Oh, no sorry, I apologize: I misread what you wrote. Ignore my previous comment. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Then that's a likely culprit. I'll remove the layers and go at it one last time before bed. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: ltoscano, davidc, #frameworks, michaelh, ngraham

D10212: New virtualbox icon

2018-01-31 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D10212#198788, @lshoravi wrote: > Giving it another try with the virtualbox icon. > > I dont think layers ought to matter, right? They do in this universe. REVISION DETAIL https://phabricator.kde.org/D10212 To:

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi updated this revision to Diff 26290. lshoravi added a comment. Giving it another try with the virtualbox icon. I dont think layers ought to matter, right? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10212?vs=26287=26290 REVISION DETAIL

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. The border made making shadows a bit tricky, so with that in mind I'll remove them. As for the diff, I'll do as you said. I'll get arc up and running tomorrow/friday. REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. The diff for this one applies sanely, so I think it's ready to land unless other folks would like changes (I'll wait for a while to give them time to take a look). In order to land the patch, we need a real name and email address. If Linus Shoravi is your real name,

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, something's not right here. I applied the patch, and the dark diagonal shadows are missing. Also, `arc` complained that the base commit was not in the repo, so I suspect

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. This is a breeze-ification of VirtualBox's own icon. If you remove the existing Breeze icon, then it reverts to the one specified by the developers, which is basically the same as this but a bit rounder and less flat. So IMHO this icon is doing exactly what it's

D10212: New virtualbox icon

2018-01-31 Thread David C
davidc added a comment. I realize this is one face of Oracle's cube logo, but I can't help but see the big "VM" and think VMware. I associate VirtualBox with the box shape. Am I the only one? The design itself is quite nice to look at. REVISION DETAIL

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Done and done! REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi updated this revision to Diff 26287. lshoravi added a comment. This should be the right diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10212?vs=26281=26287 REVISION DETAIL https://phabricator.kde.org/D10212 AFFECTED FILES icons-dark/apps/48/virtualbox.svg

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Great! Would you mind updating the images in the Summary section to reflect your most recent changes? REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi updated this revision to Diff 26286. lshoravi added a comment. Alright, this one looks like the right one. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10211?vs=26280=26286 REVISION DETAIL https://phabricator.kde.org/D10211 AFFECTED FILES

D10212: New virtualbox icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Lovely icon! A vast improvement over the current one. However, I'm not sure the diff came out right. For an icon like this, probably the sanest approach is to make your new icon, then replace the old icon with the new one in the breeze-icons source repo, and then

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Nay, this is the wrong diff. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: #frameworks, michaelh, ngraham

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. No worries! We've all been there. :) REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham, #vdg Cc: #frameworks, michaelh, ngraham

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. I'm still figuring things out, haha  Give me a minute and I'll figure it out REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi created this revision. lshoravi added a reviewer: Breeze. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. lshoravi requested review of this revision. REVISION SUMMARY Here's a candidate for a virtualbox icon. I think the

D10212: New virtualbox icon

2018-01-31 Thread Linus Shoravi
lshoravi added a reviewer: ngraham. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10212 To: lshoravi, #breeze, ngraham Cc: #frameworks, michaelh, ngraham

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. In general, arcanist makes this process much easier, FWIW. https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham,

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Oops, is this the right diff? You want to generate a diff against the existing icon, not against your previous commit.`git diff HEAD^^ will generate a diff from what you have (HEAD) to two commits back (^^) REVISION DETAIL https://phabricator.kde.org/D10211 To:

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi updated this revision to Diff 26280. lshoravi added a comment. Here's the new diff for these changes. I also cleaned up some nodes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10211?vs=26272=26280 REVISION DETAIL https://phabricator.kde.org/D10211 AFFECTED FILES

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Beautiful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: davidc, michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

2018-01-31 Thread David C
davidc added a comment. Here is a 16px version. I think the fact that it's an E is much clearer at this size. F5685662: emacs16.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg,

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Here's a slightly altered version that should be more "E for Emacs" As for a 16px version; It didnt cross my mind. Should I make one?F5685659: Emacs.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D10211: Suggestion for emacs icon

2018-01-31 Thread Michael Heidelbach
michaelh added a comment. I like it too. How does the 16px version look? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: michaelh, abetts, ngraham, #frameworks

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. Yeah, @abetts is right. Maybe reduce the size of the little flourishes on the top and bottom a bit? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: abetts, ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Andres Betts
abetts added a comment. I like it! Maybe a way to accentuate that this is an "E" a little more. As a first impression, it didn't strike me as an E for emacs. Overall, the colors are great and the circle shape fits well. REPOSITORY R266 Breeze Icons REVISION DETAIL

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. I'll look at it! I just need to figure out how to diff between to commits first. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Thanks Graham! I'll get the hang of this soon enough. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg, ngraham Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. This looks great to me. I'll let others have a look too before we land it, just to make sure everything A-OK. And if you're up for more icon work, wanna have a go at

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. I did it for you this time. The "Add Action..." combobox above the comments field is used to do things like that. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Or you can do it for me! Thanks :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Done! Sure! .. Let me just figure that out first  REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi, #breeze, #vdg Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added reviewers: Breeze, VDG. ngraham added a comment. No worries! I like that icon, looks great. Could you maybe also attach another screenshot that shows it a bit larger, all on its own? Also, let's add some reviewers! Breeze is the theme you're submitting this for, and VDG is

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi added a comment. Sorry! Just created an account to submit this, still figuring things out. Here's a screen, with some context! F5685571: Screenshot_20180131_190553.png REPOSITORY R266 Breeze Icons REVISION DETAIL

D10211: Suggestion for emacs icon

2018-01-31 Thread Nathaniel Graham
ngraham added a comment. What, no screenshot!? :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10211 To: lshoravi Cc: ngraham, #frameworks, michaelh

D10211: Suggestion for emacs icon

2018-01-31 Thread Linus Shoravi
lshoravi created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. lshoravi requested review of this revision. REVISION SUMMARY Here's a suggestion for an emacs icon I tried to follow the breeze icon guidelines to my

D10203: documenturldb: Temporarily remove Q_ASSERT, ignore empty filenames instead

2018-01-31 Thread Michael Heidelbach
michaelh retitled this revision from "DocumentUrlDB: Temporarily remove Q_ASSERT, ignore empty filenames instead" to "documenturldb: Temporarily remove Q_ASSERT, ignore empty filenames instead". michaelh added a reviewer: Baloo. michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION

D10205: fileindexerconfig: Introduce canBeSearched()

2018-01-31 Thread Michael Heidelbach
michaelh added a reviewer: Baloo. michaelh added a project: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10205 To: michaelh, #frameworks, #dolphin, #baloo Cc: michaelh, ngraham

D10205: fileindexerconfig: Introduce canBeSearched()

2018-01-31 Thread Michael Heidelbach
michaelh updated this revision to Diff 26264. michaelh added a comment. - Correct typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10205?vs=26263=26264 BRANCH search (branched from master) REVISION DETAIL https://phabricator.kde.org/D10205 AFFECTED

D10205: fileindexerconfig: Introduce canBeSearched()

2018-01-31 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: Frameworks, Dolphin. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY Prepare for search refinement in dolphin. The option to use baloo for searching should not only

D10203: DocumentUrlDB: Temporarily remove Q_ASSERT, ignore empty filenames instead

2018-01-31 Thread Michael Heidelbach
michaelh retitled this revision from "baloo:DocumentUrlDB: Temporarily remove Q_ASSERT, ignore empty filenames instead" to "DocumentUrlDB: Temporarily remove Q_ASSERT, ignore empty filenames instead". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10203 To: michaelh,

D10203: baloo:DocumentUrlDB: Temporarily remove Q_ASSERT, ignore empty filenames instead

2018-01-31 Thread Michael Heidelbach
michaelh created this revision. michaelh added reviewers: dfaure, vhanda, Frameworks. Restricted Application added a project: Frameworks. michaelh requested review of this revision. REVISION SUMMARY In debug mode this assert prevents usage of cli tools like baloosearch. Replace Q_ASSERT with

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

2018-01-31 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10201 To: asturmlechner, #frameworks, #build_system, cgiboudeaux Cc: michaelh, ngraham

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

2018-01-31 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10201 To: asturmlechner, #frameworks, #build_system, cgiboudeaux Cc:

D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT

2018-01-31 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Frameworks, Build System, cgiboudeaux. Restricted Application added projects: Frameworks, Build System. asturmlechner requested review of this revision. REVISION SUMMARY Instead of hardcoded /usr/lib, same solution as in

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-31 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In https://phabricator.kde.org/D9116#198423, @asturmlechner wrote: > Want me to fix FindQtWaylandScanner.cmake in the same way? Sure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol,

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-31 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R240:92eb3e9767cb: Make sure to search for Qt5-based qmlplugindump (authored by asturmlechner). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-31 Thread Andreas Sturmlechner
asturmlechner added a comment. Want me to fix FindQtWaylandScanner.cmake in the same way? REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks,

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-31 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks,

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-31 Thread Andreas Sturmlechner
asturmlechner edited the summary of this revision. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D9116 REVISION DETAIL https://phabricator.kde.org/D9116 To: asturmlechner, apol, cgiboudeaux Cc: aacid, dfaure, cgiboudeaux, #frameworks, #build_system, michaelh, ngraham

D9116: Make sure to search for Qt5-based qmlplugindump

2018-01-31 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 26253. asturmlechner added a comment. Use ECMQueryQmake.cmake as suggested. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9116?vs=23304=26253 BRANCH arcpatch-D9116 REVISION DETAIL

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

2018-01-31 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/55/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 31 Jan 2018 14:03:28 + Build duration: 22 min and counting JUnit

D8532: [WIP] Restrict file extractor with Seccomp

2018-01-31 Thread Detlef Eppers
detlefe added a comment. A whitelist, even if it is broad, would be desirable to reduce the attack surface of the kernel, and is also the way it was done for Gnome Tracker. But the concerns about maintenance remain, someone should test it regularly. Are there ways this can be automated?

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 58 - Still Unstable!

2018-01-31 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/58/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Wed, 31 Jan 2018 14:03:28 + Build duration: 9 min 36 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 31 - Failure!

2018-01-31 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 31 Jan 2018 14:03:28 + Build duration: 4 min 56 sec and counting

D10173: windowthumbnail: Fix the GLXFBConfig selection code

2018-01-31 Thread Fredrik Höglund
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:46121d58484c: windowthumbnail: Fix the GLXFBConfig selection code (authored by fredrik). REPOSITORY R242 Plasma

D10124: Faster simplejob start

2018-01-31 Thread Jaime Torres Amate
jtamate marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10124 To: jtamate, #frameworks, mwolff Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

D10124: Faster simplejob start

2018-01-31 Thread Jaime Torres Amate
jtamate updated this revision to Diff 26239. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Thanks to mwolf, broulik & anthonyfieroni. It works now. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts

2018-01-31 Thread Nibaldo González
nibags updated this revision to Diff 26240. nibags added a comment. - Modification of 'itemDatas', to adapt the syntax to the available schemas 1. Updating https://phabricator.kde.org/D10174: Add syntax highlighting for SELinux CIL Policies & File Contexts # 2. Enter a brief

D10155: Use the much faster urls() method from QMimeData

2018-01-31 Thread Jaime Torres Amate
jtamate updated this revision to Diff 26238. jtamate added a comment. Something like this? > if firstMimeType == "text/uri-list" (see above, PreferLocalUrls), it's still going to be slow, no? Should this be handled >generally here by introducing a helper that checks the mime type and