jtamate updated this revision to Diff 26238. jtamate added a comment.
Something like this? > if firstMimeType == "text/uri-list" (see above, PreferLocalUrls), it's still going to be slow, no? Should this be handled >generally here by introducing a helper that checks the mime type and then uses either urls() directly or call data as >before? > also, what happens if PreferLocalUrls is set, but no text/uri-list data is available, could the old way of getting the data >for the s_kdeUriListMime have worked more reliably? If PreferLocalUrls then firstMimeType = text/url-list if firstMimeType == text/url-list apply urls() method The test hash both desktop: and file: urls in the same MimeType and it passes. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10155?vs=26113&id=26238 REVISION DETAIL https://phabricator.kde.org/D10155 AFFECTED FILES src/lib/io/kurlmimedata.cpp To: jtamate, #frameworks, dfaure Cc: mwolff, michaelh, ngraham