D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. This is bad! I have learned baloo itself doesn't handle stringlists. Which in my view would be the natural way to handle token-like items like tags, keywords and subject(s). Until this is changed in baloo I'm putting this diff on hold and fro the time being work aro

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/91/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Mar 2018 22:04:56 + Build duration: 22 min and counting JUnit Tes

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/66/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Mar 2018 22:04:56 + Build duration: 8 min 11 sec and counting

D11130: Disable deprecation warning from kpackage_install_package for now

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dd0fcc3b7322: Disable deprecation warning from kpackage_install_package for now (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde

D10694: epubextractor: Handle multiple subjects better

mgallien added a comment. Sorry for being so late. In D10694#215663 , @michaelh wrote: > @mgallien : taglibextractor.cpp is very hard to read. Hopefully it is no longer. INLINE COMMENTS > michaelh wrote in epubextractor.cpp:94 > Did you me

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Thu, 08 Mar 2018 21:25:10 + Build duration: 2 min 29 sec and counting JUnit Tests Name

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/22/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 08 Mar 2018 21:25:10 + Build duration: 1 min 56 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/28/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Mar 2018 21:25:10 + Build duration: 1 min 26 sec and counting JUnit Tests N

D11153: Use correct item URL for Create New context menu

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11153 To: prukgaber, #frameworks, dfaure Cc: hein, #frameworks, michaelh

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8c7f78206b95: Mark kpackage_install_package undeprecated for plasma_install_package (authored by kossebau). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11129?vs

D11155: handle zip files embedded within zip files

dfaure added inline comments. INLINE COMMENTS > kzip.cpp:347 > * @param dev device that is read from > * @return true if a local or central header token could be reached, false > on error can you document the new boolean param as well? REPOSITORY R243 KArchive REVISION DETAIL https://

D11156: add autotest for zips within zips

dfaure added inline comments. INLINE COMMENTS > karchivetest.cpp:1156 > + > +QVERIFY(zip.open(QIODevice::ReadOnly)); > +} A check for a file listing would avoid that just "return true" in open() is enough for the test to pass :-) REPOSITORY R243 KArchive REVISION DETAIL https://phabri

D10365: New icon for Elisa music player

This revision was automatically updated to reflect the committed changes. Closed by commit R266:26866bfffa86: New icon for Elisa music player (authored by paullesur, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10365?vs=26705&id=2

D10365: New icon for Elisa music player

ngraham accepted this revision. ngraham added a comment. I'm ok with it. Landing now. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien, ngraham Cc: mmustac, mgallien, januz, astippic

D10365: New icon for Elisa music player

mgallien added a comment. I believe there was no objections to this choice of icon. Can we ensure this gets landed soon ? I would prefer to be able to have the new icon as soon as possible. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10365

D11149: Create a constructor for KLocalizedStringPrivate

This revision was automatically updated to reflect the committed changes. Closed by commit R249:a02e99069e15: Create a constructor for KLocalizedStringPrivate (authored by jtamate). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11149?vs=28990&id=29029 REVISION

D11132: Avoid an asan runtime error

This revision was automatically updated to reflect the committed changes. Closed by commit R302:af5397635c4f: Avoid an asan runtime error (authored by jtamate). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=29002&id=29026 REVISION DETAIL https

D11130: Disable deprecation warning from kpackage_install_package for now

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH allowdeprecatedwarningdisabling REVISION DETAIL https://phabricator.kde.org/D11130 To: kossebau, mart, apol Cc: #frameworks, michaelh, ZrenBot, lesliezhai, ali-m

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH allowdeprecatedwarningdisabling REVISION DETAIL https://phabricator.kde.org/D11129 To: kossebau, mart, apol Cc: #frameworks, michaelh

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

kossebau added inline comments. INLINE COMMENTS > apol wrote in KF5PackageMacros.cmake:27 > How about if(KF5Plasma_FIND_VERSION VERSION_LESS 5.43.0)? > > This way it's only shown on projects that are actually depending on the new > version. And if they are well then that's fine to have the warn

D11129: Mark kpackage_install_package undeprecated for plasma_install_package

apol added inline comments. INLINE COMMENTS > KF5PackageMacros.cmake:27 > + # allow plasma_install_package to disable the warning until it is ported > away from this > + if (NOT ARGV4 STREQUAL NO_DEPRECATED_WARNING) > + message(AUTHOR_WARNING "Deprecated: use > kpackage_install_bundled

D10776: Make it possible to generate po files in parallel

apol marked an inline comment as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D10776 To: apol, #frameworks, sitter Cc: michaelh

D10776: Make it possible to generate po files in parallel

apol updated this revision to Diff 29024. apol added a comment. Fix typo REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10776?vs=28846&id=29024 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10776 AFFECTED FILES cmake/build-pofiles.cmake

D11132: Avoid an asan runtime error

mwolff added a comment. still accepted, fell free to submit REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D11132 To: jtamate, #frameworks, mwolff Cc: mwolff, apol, anthonyfieroni, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/9/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Thu, 08 Mar 2018 15:34:48 + Build duration: 24 min and counting JUnit Tests Name: (root) Fail

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

chinmoyr closed this revision. chinmoyr added a comment. Bug fixed in D11011 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks, dfaure Cc: awilcox, dfaure, davidedmundson, elvisangelaccio, shortsth

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/42/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Thu, 08 Mar 2018 15:34:48 + Build duration: 9 min 20 sec and counting JUnit Tests Name: (

D11153: Use correct item URL for Create New context menu

hein added reviewers: Frameworks, dfaure. hein added a comment. Looks good to me. I'll let David have a look too and then it can go in. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11153 To: prukgaber, #frameworks, dfaure Cc: hein, #frameworks, michaelh

D11037: balooctl: checkDb should also verify the last known url for the documentId.

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3fbabac6add9: balooctl: checkDb should also verify the last known url for the documentId. (authored by smithjd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11037?vs=28647&id=29016#toc REPO

D11156: add autotest for zips within zips

sandsmark created this revision. sandsmark added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY an epub in a zip file compressed by e. g. the golang standard zip library, or infozip in streaming mo

D11155: handle zip files embedded within zip files

sandsmark created this revision. sandsmark added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY if we need to fetch the sizes from a PK78 header, there might be a PK34 header before it if there is

D10543: fix crashing with duplicate entries

This revision was automatically updated to reflect the committed changes. Closed by commit R243:6736aca49c2d: karchive, kzip: try to handle duplicate files in a bit nicer way (authored by sandsmark). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10543?vs=276

D10551: autotest for crashing in KArchiveDirectory::addEntry

This revision was automatically updated to reflect the committed changes. sandsmark marked an inline comment as done. Closed by commit R243:6959a256f777: autotests: add crashing test with duplicate names (authored by sandsmark). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10551?vs=2831

D11153: Use correct item URL for Create New context menu

prukgaber created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. prukgaber requested review of this revision. REVISION SUMMARY The activatedMenu function was not using the given items path, which resulted in new folders

D11132: Avoid an asan runtime error

jtamate updated this revision to Diff 29002. jtamate added a comment. Added the link. REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=28991&id=29002 REVISION DETAIL https://phabricator.kde.org/D11132 AFFECTED FILES src/kiconeffect.cpp To:

D10591: forcefully activate popup windows when they open

mart abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10591 To: mart, #plasma Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11132: Avoid an asan runtime error

mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kiconeffect.cpp:44 > +KIconEffectPrivate() > + : effect{{}} > + , value{{}} it may be a good idea to add a comment that links to http://en.cppreference

D11149: Create a constructor for KLocalizedStringPrivate

ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11149 To: jtamate, #frameworks, ilic Cc: ilic, michaelh

D11132: Avoid an asan runtime error

jtamate updated this revision to Diff 28991. jtamate added a comment. with spaces after : and , REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11132?vs=28946&id=28991 REVISION DETAIL https://phabricator.kde.org/D11132 AFFECTED FILES src/kiconeffec

D11149: Create a constructor for KLocalizedStringPrivate

jtamate updated this revision to Diff 28990. jtamate added a comment. With spaces after : and , REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11149?vs=28988&id=28990 REVISION DETAIL https://phabricator.kde.org/D11149 AFFECTED FILES src/klocalizedstring

D11149: Create a constructor for KLocalizedStringPrivate

ilic added inline comments. INLINE COMMENTS > klocalizedstring.cpp:202-204 > + :format() > + ,numberSet(false) > + ,markupAware(false) Should have space after colon/comma? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D11149 To: jtamate, #frameworks C

D11149: Create a constructor for KLocalizedStringPrivate

jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The constructor avoids the following asan runtime errors kdesrc/frameworks/ki18n/src/klocalizedstring.cpp:179:7: