KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/7/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Thu, 15 Mar 2018 02:32:38 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/32/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Thu, 15 Mar 2018 02:32:38 + Build duration: 6 min 18 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/24/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 15 Mar 2018 02:32:38 + Build duration: 4 min 33 sec and counting

D10809: autotests: Refactor fileindexerconfigtest

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sane. Code looks acceptable and the tests pass. REPOSITORY R293 Baloo BRANCH fileindexerconfigtest-rebuild (branched from master) REVISION DETAIL

D11346: Only set iconText() if actually changed

cfeck created this revision. cfeck added a reviewer: Frameworks. Restricted Application added a project: Frameworks. cfeck requested review of this revision. REVISION SUMMARY QAction::setIconText() breaks the feature that QAction::iconText() is returning text() when the iconText is empty.

D10749: Add ECMSetupQtPluginMacroNames

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH addECMSetupQtPluginMacroNames REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks, apol Cc: apol, michaelh, ngraham

D11290: [UDevManager] Already filter for subsystem before querying

mpyne added a comment. I never had the bug myself, I just grepped through the attached log to see if it made sense or not. :) I'll close the bug for now, if it doesn't fix the issue then it'll just get reopened. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290

D10749: Add ECMSetupQtPluginMacroNames

kossebau added a comment. In D10749#225709 , @apol wrote: > LGTM Thanks for having had a look :) > Do you think it would be possible to come up with a test for it? Sadly no experience with cmake stuff testing and no initial idea

D11330: Remove shebangs from non-executable files

This revision was automatically updated to reflect the committed changes. Closed by commit R264:642fd8a06fca: Remove shebangs from non-executable files (authored by lbeltrame). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11330?vs=29501=29539 REVISION

D11315: Look first for qhelpgenerator-qt5 for help generation

This revision was automatically updated to reflect the committed changes. Closed by commit R264:27a1126b1d79: Look first for qhelpgenerator-qt5 for help generation (authored by lbeltrame). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11315?vs=29468=29538

D11342: Include the "stdcpp-path" in the json file

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. apol requested review of this revision. REVISION SUMMARY qmake also generates it and androiddeployqt consumes

D10918: taglibextractor: Refactor for better readability

michaelh added inline comments. INLINE COMMENTS > taglibextractor.cpp:157 > +if (itAlbumArtists != allTags.end()) { > +data.albumArtists = > itAlbumArtists->second.toStringList().toString(", "); > } This is an example for what we're discussing. Why the join??? We might lose

D10918: taglibextractor: Refactor for better readability

michaelh added a comment. In D10918#225927 , @astippich wrote: > @mgallien as the maintainer must also give his ok. @mgallien: You're the maintainer of kfilemetadata? Great! I didn't know. I thought all of Vishesh's heritage was

D10918: taglibextractor: Refactor for better readability

michaelh added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:331 > I think we should check explicitly for the appropriate mimetypes here You mean other than lines 225, 233, 240? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10918

D10918: taglibextractor: Refactor for better readability

astippich requested changes to this revision. astippich added a comment. This revision now requires changes to proceed. Looks good imho, just one small comment inline. of course, @mgallien as the maintainer must also give his ok. INLINE COMMENTS > taglibextractor.cpp:331 > +} else { > +

D11287: Introduce baloodb CLI tool

michaelh added a comment. In D11287#225860 , @ngraham wrote: > This is really nice, I like it! Should make debugging a lot easier. Noticed a couple of things: This is how the output now does and should look. $ baloodb devices

D11285: Introduce sanitizer class

michaelh added inline comments. INLINE COMMENTS > databasesanitizer.cpp:200 > + > +DocumentUrlDB DatabaseSanitizer::getDocuments(Transaction* txn) > +{ This is the best I could think of to make `getDocuments` accessible to DatabaseSanitizerImpl. But I don't like it. This method definitely

D11287: Introduce baloodb CLI tool

michaelh updated this revision to Diff 29525. michaelh added a comment. - Remove obsolete include REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11287?vs=29524=29525 BRANCH sanitize-cmd (branched from master) REVISION DETAIL

D11287: Introduce baloodb CLI tool

michaelh updated this revision to Diff 29524. michaelh edited the test plan for this revision. michaelh added a comment. - Add KAboutData - Remove debug statement REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11287?vs=29406=29524 BRANCH sanitize-cmd

D11287: Introduce baloodb CLI tool

ngraham added a comment. This is really nice, I like it! Should make debugging a lot easier. Noticed a couple of things: $ baloodb -v baloodb $ baloodb devices command "devices" Listing database contents... Device:2049 14855 items Found 14855 matching items

D11285: Introduce sanitizer class

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R293 Baloo BRANCH sanitize-class (branched from master) REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham

D11330: Remove shebangs from non-executable files

ochurlaud accepted this revision. This revision is now accepted and ready to land. REPOSITORY R264 KApiDox BRANCH master REVISION DETAIL https://phabricator.kde.org/D11330 To: lbeltrame, #frameworks, ochurlaud Cc: #documentation, michaelh, ngraham, skadinna

D11315: Look first for qhelpgenerator-qt5 for help generation

ochurlaud accepted this revision. ochurlaud added a comment. This revision is now accepted and ready to land. Thx for this change REPOSITORY R264 KApiDox BRANCH master REVISION DETAIL https://phabricator.kde.org/D11315 To: lbeltrame, #frameworks, ochurlaud Cc: fvogt, #documentation,

D11190: Make sure we are taking into account hte size of the element when styling

This revision was automatically updated to reflect the committed changes. Closed by commit R858:c41339d7ed30: Make sure we are taking into account hte size of the element when styling (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > markg wrote in file_unix.cpp:546-550 > Why here? > This should be done inside the createUDSEntry function (it's in file.cpp). The logic behind this is that `getxattr` exists only on Linux

D11190: Make sure we are taking into account hte size of the element when styling

ngraham added a dependent revision: D11189: Force a content size into the background style item. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D11190 To: apol, #frameworks, mart Cc: plasma-devel, ZrenBot, lesliezhai,

D11204: Support NTFS hidden files

markg requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, markg Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks,

D11204: Support NTFS hidden files

markg added a subscriber: dfaure. markg added a comment. @dfaure I've been looking over the file.cpp and file_unix.cpp code a bit and i'm rather surprised that UDS_HIDDEN isn't being set at all here. Which makes me wonder, why is the hidden logic missing and how is it working now? I don't

D10749: Add ECMSetupQtPluginMacroNames

apol added a comment. LGTM Do you think it would be possible to come up with a test for it? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10749 To: kossebau, #build_system, #frameworks Cc: apol, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

dollinger added a comment. Btw, this "new" type (`UP_DEVICE_KIND_GAMING_INPUT`) was added half an year ago ;) https://cgit.freedesktop.org/upower/tree/libupower-glib/up-types.h?h=UPOWER_0_99_5 **vs** https://cgit.freedesktop.org/upower/tree/libupower-glib/up-types.h?h=UPOWER_0_99_6

D11331: add gaming_input devices and others to Battery

dollinger added inline comments. INLINE COMMENTS > dollinger wrote in upowerdevice.cpp:98 > Well then it is added automatically, which is what you would expect I think, > and that is the reason why gaming_input wasn't detected. But we can also do it the following way, personally I don't care

D11331: add gaming_input devices and others to Battery

dollinger added inline comments. INLINE COMMENTS > aleksejshilin wrote in upowerdevice.cpp:98 > So you're changing from 'whitelist' to 'blacklist' behavior here. What will > happen when another UPower device type is added by the upstream? Well then it is added automatically, which is what you

D11331: add gaming_input devices and others to Battery

aleksejshilin added inline comments. INLINE COMMENTS > upowerdevice.cpp:98 > + */ > +return (uptype != 0 && uptype != 1 && uptype != 4); > default: So you're changing from 'whitelist' to 'blacklist' behavior here. What will happen when another UPower device type is added

D11331: add gaming_input devices and others to Battery

bshah added reviewers: broulik, Plasma. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11331 To: dollinger, broulik, #plasma Cc: #frameworks, michaelh, ngraham

D11331: add gaming_input devices and others to Battery

dollinger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. dollinger requested review of this revision. REVISION SUMMARY automatically add new types like gaming_input, as discussed here:

D11330: Remove shebangs from non-executable files

lbeltrame created this revision. lbeltrame added reviewers: Frameworks, ochurlaud. Restricted Application added projects: Frameworks, Documentation. Restricted Application added a subscriber: Documentation. lbeltrame requested review of this revision. REVISION SUMMARY These files are meant to

D11323: [UDevManager] Also explicitly query for cameras

davidedmundson added a comment. didn't we establish that devicesByProperty didn't work? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11323 To: broulik, #frameworks, davidedmundson Cc: michaelh, ngraham

D11326: [ToolTip] Check file name in KDirWatch handler

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11326 To: broulik, #plasma Cc: #frameworks, michaelh, ngraham

D11326: [ToolTip] Check file name in KDirWatch handler

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY `KDirWatch::self()` is a singleton so we would get change

D11278: [KateCompletionWidget] Create configuration interface on demand

martinkostolny added a comment. Hi! After this commit I don't see a completion dropdown anymore. And after it should be opened an one presses backspace, kate or kwrite crashes. Simple example: 1. open empty Kate 2. write "", enter, "", backspace I will provide backtrace

D11323: [UDevManager] Also explicitly query for cameras

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Only camers with ID_GPHOTO2=1 are considered by the backend so we might as well just query for

D11320: Fix QVariantMapList operator >> implementation

broulik added a comment. Is that custom marshaller even neccessary? I thought Qt could resolve QList and QVariantMap (even nested) automatically? Can you try just removing that entire thing? REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D11320 To:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Wed, 14 Mar 2018 10:48:25 + Build duration: 7 min 31 sec and counting JUnit Tests Name:

D10809: autotests: Refactor fileindexerconfigtest

broulik added a comment. lgtm but not really an expert in `QTemporaryFile` REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10809 To: michaelh, #baloo, #frameworks, ngraham Cc: broulik, ashaposhnikov, michaelh, spoorun, nicolasfella, ngraham, alexeymin

D11279: [FileIndexerConfig] Delay populating folders until actually used

This revision was automatically updated to reflect the committed changes. Closed by commit R293:76c207a14142: [FileIndexerConfig] Delay populating folders until actually used (authored by broulik). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D10366: cmake: don't flag libnm-util as found when ModemManager is found

This revision was automatically updated to reflect the committed changes. Closed by commit R281:d3c573483257: cmake: dont flag libnm-util as found when ModemManager is found (authored by aleksanderm, committed by lbeltrame). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D11290: [UDevManager] Already filter for subsystem before querying

broulik added a comment. I wasn't sure if that really fixes it, it might mitigate it? If you could perhaps retry with your strace skills. If you consider it good enough, feel free to close the bug REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik,

D9221: [KLineEdit] Use Qt's built-in clear button functionality

broulik updated this revision to Diff 29479. broulik retitled this revision from "WIP: [KLineEdit] Use Qt's built-in clear button functionality" to "[KLineEdit] Use Qt's built-in clear button functionality". broulik edited the summary of this revision. broulik edited the test plan for this

D11320: Fix QVariantMapList operator >> implementation

aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich. Restricted Application added a project: Frameworks. aleksanderm requested review of this revision. REVISION SUMMARY Thread 1 "united-airlion" received signal SIGSEGV, Segmentation fault.

D11204: Support NTFS hidden files

rominf updated this revision to Diff 29475. rominf added a comment. - Cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29473=29475 BRANCH ntfs-hidden REVISION DETAIL https://phabricator.kde.org/D11204 AFFECTED FILES

D11318: Support NTFS hidden files

rominf abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11318 To: rominf Cc: #frameworks, michaelh, ngraham

D11204: Support NTFS hidden files

rominf updated this revision to Diff 29473. rominf added a comment. - Move isNtfsHidden to file ioslave REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29141=29473 BRANCH ntfs-hidden REVISION DETAIL https://phabricator.kde.org/D11204 AFFECTED

D10809: autotests: Refactor fileindexerconfigtest

michaelh updated this revision to Diff 29472. michaelh added a comment. - Keep closer to original - Check directory existence REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10809?vs=27950=29472 BRANCH fileindexerconfigtest-rebuild (branched from master)

D11183: Sonnet: don't impose the default client

rjvbb added reviewers: dfaure, mlaurent, vkrause. rjvbb edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11183 To: rjvbb, #frameworks, cullmann, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel,

Re: D11193: Sonnet : use current hunspell API

> You should probably add the sonnet maintainer (or whoever committed > the most to the repository in recent months) as the reviewer. Possibly, but they're all supposed to be notified of this via the frameworks- devel ML already.

D11193: Sonnet : use current hunspell API

rjvbb added reviewers: dfaure, mlaurent, vkrause. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks, dfaure, mlaurent, vkrause Cc: kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/26/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 14 Mar 2018 08:06:55 + Build duration: 25 min and counting JUnit Tests Name: (root)

D11315: Look first for qhelpgenerator-qt5 for help generation

lbeltrame created this revision. lbeltrame added reviewers: Frameworks, ochurlaud. Restricted Application added projects: Frameworks, Documentation. Restricted Application added a subscriber: Documentation. lbeltrame requested review of this revision. REVISION SUMMARY A number of distributions

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 155 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/155/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 14 Mar 2018 08:06:55 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 176 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/176/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 14 Mar 2018 08:06:55 + Build duration: 7 min 48 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 14 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Wed, 14 Mar 2018 07:33:15 + Build duration: 3 min 50 sec and counting JUnit Tests Name:

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Tue, 13 Mar 2018 04:17:27 + Build duration: 1 day 3 hr and counting CONSOLE OUTPUT

KDE CI: Frameworks kirigami kf5-qt5 AndroidQt5.9 - Build # 127 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20AndroidQt5.9/127/ Project: Frameworks kirigami kf5-qt5 AndroidQt5.9 Date of build: Wed, 14 Mar 2018 07:19:02 + Build duration: 43 sec and counting CONSOLE OUTPUT