KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/78/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 20 Mar 2018 04:19:43 + Build duration: 6 min 54 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/103/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 20 Mar 2018 04:19:43 + Build duration: 4 min 11 sec and counting

D11484: Fix combobox breakage

mvourlakos added a comment. thank you, it works just fine now... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11484 To: ngraham, broulik, #plasma, mvourlakos, davidedmundson Cc: #frameworks, michaelh, ngraham

D11491: Don't calculate attribute() twice.

jtamate created this revision. jtamate added reviewers: Frameworks, Kate. Restricted Application added projects: Kate, Frameworks. jtamate requested review of this revision. REVISION SUMMARY "kateTextLine" neither "i" shouldn't have changed since the first call to attribute two lines ago.

D11489: Make concatenated strings wrappable

michaelh created this revision. michaelh added reviewers: mgallien, Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Change concatenation of epub subjects to facilitate line wrapping REPOSITORY R286

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/77/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Mar 2018 15:40:44 + Build duration: 12 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 102 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/102/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Mar 2018 15:40:45 + Build duration: 9 min 16 sec and counting

D11287: Introduce baloodb CLI tool

michaelh added inline comments. INLINE COMMENTS > ngraham wrote in main.cpp:65 > Any reason not to use a std::vector instead? No reason. Will change to std::vector. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc:

D11484: Fix combobox breakage

ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11484 To: ngraham, broulik, #plasma, mvourlakos, davidedmundson Cc: #frameworks, michaelh, ngraham

D11487: simple optimization of TextLineData::attribute

jtamate updated this revision to Diff 29925. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Same results, but more concise syntax with the range-based for. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate planned changes to this revision. jtamate added a comment. I've noticed this creates/exposes some crashes in other code/tests, for example in kdirmodeltest the second and later times the test is run. I'll check all the failing tests (given enough time). REPOSITORY R241 KIO

D11487: simple optimization of TextLineData::attribute

cullmann added a comment. Looks reasonable. Could one use a C++11 range-based for? Given the container is const in that context, it won't detach, or? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11487 To: jtamate, #frameworks, #kate Cc: cullmann, michaelh,

D11484: Fix combobox breakage

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-combobox-breakage (branched from master) REVISION DETAIL https://phabricator.kde.org/D11484 To: ngraham, broulik, #plasma, mvourlakos,

D11487: simple optimization of TextLineData::attribute

jtamate created this revision. jtamate added reviewers: Frameworks, Kate. Restricted Application added projects: Kate, Frameworks. jtamate requested review of this revision. REVISION SUMMARY Instead of getting the element to check 4 to 5 times each time, using the constant iterator, do it only

D11287: Introduce baloodb CLI tool

ngraham added inline comments. INLINE COMMENTS > michaelh wrote in main.cpp:161 > To point this out. I'm **not** the maintainer of baloo. Maybe better remove > this? I think you sort of are Baloo's de facto maintainer (which is a good thing, and you've earned the position)! > main.cpp:65 > +

D11287: Introduce baloodb CLI tool

michaelh marked 4 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin

D11287: Introduce baloodb CLI tool

michaelh added inline comments. INLINE COMMENTS > mlaurent wrote in main.cpp:135 > very hard to read it. > Could you split in several QString so it will more easy to check it's if ok :) I had trouble myself :) > main.cpp:161 > + i18n("(c) 2018, Michael Heidelbach")); >

D11287: Introduce baloodb CLI tool

michaelh updated this revision to Diff 29914. michaelh added a comment. - Improve readability and apply other suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11287?vs=29694=29914 BRANCH sanitize-cmd (branched from master) REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 157 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/157/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 19 Mar 2018 13:20:29 + Build duration: 17 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/28/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 19 Mar 2018 13:20:29 + Build duration: 16 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 178 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/178/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 19 Mar 2018 13:20:29 + Build duration: 6 min 37 sec and counting JUnit Tests Name:

D11484: Fix combobox breakage

ngraham added a reviewer: mvourlakos. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11484 To: ngraham, broulik, #plasma, mvourlakos Cc: #frameworks, michaelh, ngraham

D11484: Fix combobox breakage

ngraham created this revision. ngraham added reviewers: broulik, Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. ngraham requested review of this revision. REVISION SUMMARY

D11044: Don't try to find an icon for an empty url

dfaure added a comment. https://commits.kde.org/kio/e6723cdac2b713081417aa198f3cede8c68b78e0, now with unittests. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11044 To: jtamate, #frameworks, dfaure Cc: broulik, michaelh, ngraham

D11287: Introduce baloodb CLI tool

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:103 > +QStringLiteral("devices"), > +i18n("List devices "), > +QStringList{}, extra space at the end of i18n >

D11044: Don't try to find an icon for an empty url

dfaure added a comment. Kai-Uwe was right, this should actually check for scheme.isEmpty(). Otherwise typing ~ in kfilewidget (which leads to a relative URL without scheme) hits this same assert again. I hate relative URLs... I'll change it. REPOSITORY R241 KIO REVISION DETAIL

D11331: add gaming_input devices and others to Battery

broulik added a comment. In D11331#226852 , @dollinger wrote: > I updated the diff, but unfortunately I'm not sure where to add that enum you @broulik mentioned since there is already one in `frontend\battery.h`: I think you can add an

D10203: documenturldb: Temporarily remove Q_ASSERT, ignore empty filenames instead

michaelh abandoned this revision. michaelh added a comment. Done in D11285 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10203 To: michaelh, dfaure, vhanda, #frameworks, #baloo, mgallien Cc: ashaposhnikov, michaelh, astippich,

D11038: balooctl: Add clean option to remove stale file index entries

michaelh added a comment. In D11038#228996 , @smithjd wrote: > In D11038#228379 , @michaelh wrote: > > > - I wonder how you can run this. Please make sure you build the `debug target`. Comment out