KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 99 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/99/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 09 Apr 2018 03:19:10 + Build duration: 16 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 124 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/124/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 09 Apr 2018 03:19:10 + Build duration: 13 min and counting JUnit Te

D12051: [UDisks] Correct handling of removable file systems

This revision was automatically updated to reflect the committed changes. Closed by commit R245:122a6cd8989a: [UDisks] Correct handling of removable file systems (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12051?vs=31696&id=31712 REVISIO

D12051: [UDisks] Correct handling of removable file systems

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, I can confirm that this fixes the automount issue for me. +1 for making the code clearer, too. REPOSITORY R245 Solid BRANCH revert_empty_filepath_check REVISION DETAIL htt

D11851: Add syntax highlighting for Logcat

nibags added a comment. It's a poem by Nicanor Parra. If you want I can change the test for a real log... REPOSITORY R216 Syntax Highlighting BRANCH add-logcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D11851 To: nibags, #framework_syntax_highlighting, cullma

D12034: Use the more appropriate "two sliders" icon for "configure"

ngraham added a comment. Of note, this patch also makes it trivially easy to change the "Configure" icon in the future, because it makes everything that uses that icon actually point to the `configure` icon rather than a hodgepodge of different icons. REPOSITORY R266 Breeze Icons REVISION

D12044: baloodb: Improve interface

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. Very nice, I like it. This is a very handy tool now. REPOSITORY R293 Baloo BRANCH sanitize-improve-ui (branched from master) REVISION DETAIL https://phabricator.kde.org

D12051: [UDisks] Correct handling of removable file systems

bruns added a dependency: D12050: Make automounting work even if StorageAccess is ignored. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D12051 To: bruns, ngraham, broulik Cc: #frameworks, michaelh, ngraham, bruns

D12051: [UDisks] Correct handling of removable file systems

bruns created this revision. bruns added reviewers: ngraham, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY Filesystems which have no fstab entry have an empty filepath

D12045: Clean up existing documentation

bruns added inline comments. INLINE COMMENTS > README.md:27 > +* Baloo follows the > [KDELibs](https://techbase.kde.org/Policies/Kdelibs_Coding_Style) coding > style. > +* [](https://build.kde.org/j

D12045: Clean up existing documentation

michaelh updated this revision to Diff 31688. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12045?vs=31668&id=31688 BRANCH doc-cleanup REVISION DETAIL https://phabricator.kde.org/D12045 AFFECTED FILE

D11583: Add platform detection and adjustment to kded

This revision was automatically updated to reflect the committed changes. Closed by commit R297:88eda28b3567: Add platform detection and adjustment to kded (authored by graesslin, committed by mpyne). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11583?vs=30243&

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/66/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Apr 2018 15:49:44 + Build duration: 3 min 0 sec and counting JUnit Tests Name: (r

D12005: Fix merging of terms in the AdvancedQueryParser

bruns updated this revision to Diff 31685. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12005?vs=31585&id=31685 BRANCH baloo_term_cleanup_2 REVISION DETAIL https://phabricator.kde.org/D12005 AFFECTED FILES autotests/unit/lib/advancedqueryparsertest.cpp

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 34 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/34/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sun, 08 Apr 2018 15:40:37 + Build duration: 7 min 1 sec and counting JUnit Tests Name: (root

D12044: baloodb: Improve interface

michaelh marked 3 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #baloo, ngraham Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12044: baloodb: Improve interface

michaelh updated this revision to Diff 31684. michaelh edited the summary of this revision. michaelh added a comment. - Apply suggested changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12044?vs=31659&id=31684 BRANCH sanitize-improve-ui (branched from

D12037: Immediately apply termInConstruction when term is complete

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c7c5a0bffbea: Immediately apply termInConstruction when term is complete (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12037?vs=31638&id=31682

D11888: Handle adjacent special characters correctly

This revision was automatically updated to reflect the committed changes. Closed by commit R293:116e55a2076e: Handle adjacent special characters correctly (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11888?vs=31636&id=31681 REVISION DETAI

D12007: Add test case for parsing of double opening '(('

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4e69ffeab75f: Add test case for parsing of double opening '((' (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12007?vs=31634&id=31679 REVISION D

D12047: Avoid crash when reading corrupt data from document terms db

bruns added a reviewer: ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12045: Clean up existing documentation

bruns added inline comments. INLINE COMMENTS > README.md:5 > > -Baloo provides file searching and indexing. It does so by maintaining an > index of the contents > -of your files. > +Baloo is the file indexing and file search framework for KDE Plasma. It > focuses on speed and a very small mem

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.9 - Build # 33 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.9/33/ Project: Frameworks baloo kf5-qt5 SUSEQt5.9 Date of build: Sun, 08 Apr 2018 15:24:37 + Build duration: 7 min 15 sec and counting JUnit Tests Name: (ro

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.10 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.10/31/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Apr 2018 15:24:36 + Build duration: 5 min 39 sec and counting

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/63/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Apr 2018 15:16:16 + Build duration: 10 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.10 - Build # 30 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.10/30/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Apr 2018 15:16:16 + Build duration: 3 min 51 sec and counting CONSOLE OUTP

D12044: baloodb: Improve interface

bruns added inline comments. INLINE COMMENTS > databasesanitizer.cpp:249 > if (!(accessFilter & IgnoreAvailable)) { > -out << QStringLiteral("%1").arg(info.accessible ? "+" : "!") << > sep; > +color = (useColors && !info.accessible) ? colors.first : > colors.sec

D12029: taglibextractor: Fix empty genre bug

michaelh added a comment. `baloo-widgets` become unstable in CI because of this. https://build.kde.org/job/Applications%20baloo-widgets%20kf5-qt5%20SUSEQt5.9/34/testReport/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12029 To: michaelh, mgallien, #baloo, #

D12047: Avoid crash when reading corrupt data from document terms db

bruns created this revision. bruns added reviewers: Baloo, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. bruns requested review of this revision. REVISION SUMMARY The terms db contains terms, where each terms is stored

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 62 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/62/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Apr 2018 14:29:01 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.10 - Build # 29 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.10/29/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 08 Apr 2018 14:29:01 + Build duration: 1 min 39 sec and counting CONSOLE OUTP

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Apr 2018 14:24:11 + Build duration: 5 min 42 sec and counting JUnit Tests N

D11982: Use statbuf consistently

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b94a91a556b5: Use statbuf consistently (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11982?vs=31561&id=31671 REVISION DETAIL https://phabr

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/41/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 08 Apr 2018 14:24:11 + Build duration: 1 min 35 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/24/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Sun, 08 Apr 2018 14:24:11 + Build duration: 1 min 41 sec and counting JUnit Tests Nam

D12045: Clean up existing documentation

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REPOSITORY R293 Baloo BRANCH doc-cleanup REVISION DETAIL https://ph

D12045: Clean up existing documentation

michaelh added a task: T7843: Documentation. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12045 To: michaelh, #baloo Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12044: baloodb: Improve interface

michaelh added a comment. This is the last patch, before I let baloodb rest for some time. This is the first time I've created a cli-tool + class completely from scratch. So there a tendency to become routine-blinded ("betriebsblind"). Therefore I'd like to ask you to check for - o

D12044: baloodb: Improve interface

michaelh created this revision. michaelh added reviewers: Baloo, ngraham. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. REVISION SUMMARY - Colorize output - Improve help message TEST

D11753: baloodb: Add clean command

michaelh added a dependent revision: D12044: baloodb: Improve interface. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11753 To: michaelh, #baloo, #frameworks Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12044: baloodb: Improve interface

michaelh added a dependency: D11753: baloodb: Add clean command. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #baloo, ngraham Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

On KIO and non-unicode compatible paths

Abstract I recently had a look at Bug 173097 (Cannot delete a file with "invalid" characters in its name), and unfortunately, this seems to be a surprisingly difficult issue to fix with how KIO is currently designed. The following should document the current state to the best of my unde

D10141: Restore Persistence=session for the file ioslave kauth helper

fvogt accepted this revision. fvogt added a comment. In D10141#242466 , @chinmoyr wrote: > In D10141#242463 , @fvogt wrote: > > > No objections from me - as long as the feature is disabled correctly,

D10141: Restore Persistence=session for the file ioslave kauth helper

chinmoyr added a comment. In D10141#242463 , @fvogt wrote: > No objections from me - as long as the feature is disabled correctly, which it currently isn't. > > See also https://phabricator.kde.org/T8075#136728. https://cgit.kde.org/

Re: KNewStuff - CMake targets hardcoding paths

On Sunday, 8 April 2018 03:30:15 BST Ben Cooksley wrote: > Hi all, > > On Windows the Binary Factory has recently struck an issue with > KNewStuff where the paths supplied in the newstuffqmlplugin target it > installs are hardcoded. > > This can be seen at the bottom of > https://binary-factory.k

D10141: Restore Persistence=session for the file ioslave kauth helper

fvogt added a comment. No objections from me - as long as the feature is disabled correctly, which it currently isn't. See also https://phabricator.kde.org/T8075#136728. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10141 To: elvisangelaccio, lbe

D10141: Restore Persistence=session for the file ioslave kauth helper

elvisangelaccio added a comment. @fvogt @lbeltrame @davidedmundson Any remaining objections? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10141 To: elvisangelaccio, lbeltrame, dfaure, davidedmundson, fvogt, chinmoyr Cc: aacid, #frameworks, michaelh, n

D11569: Improve consistency of "Open With" UI by always showing top app inline

elvisangelaccio added a comment. I didn't notice that this change also affects the context menu of folders. That doesn't make much sense and just clutters the menu, imho. Why would I want an "Open with Gwenview" action if 99% of my folders do not contain pictures? REPOSITORY R241 KIO

D12037: Immediately apply termInConstruction when term is complete

michaelh accepted this revision as: michaelh. michaelh added a comment. This revision is now accepted and ready to land. "Immediately add term to stack when it is complete" as commit message? REPOSITORY R293 Baloo BRANCH b392620_fix_term_stack REVISION DETAIL https://phabricator.kde.or

D7909: Add syntax support for Crystal Programming Language

oprypin added inline comments. INLINE COMMENTS > crystal.xml:37 > + > + + version="1" kateversion="3.3" Section should be "Sources" REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff,

D11888: Handle adjacent special characters correctly

michaelh accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH t3 REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D11888: Handle adjacent special characters correctly

michaelh accepted this revision as: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#242422 , @cullmann wrote: > Ah, I let just the build run once more locally, the current static check says: > > "/local/cullmann/kf5/src/frameworks/syntax-highlighting/data/syntax/crystal.xml" Unused itemDat

D12007: Add test case for parsing of double opening '(('

michaelh added a comment. Let the rebasing begin... :-) and thanks. REPOSITORY R293 Baloo BRANCH b#392620_unittest REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D7909: Add syntax support for Crystal Programming Language

cullmann added a comment. And the auto-test does have diffs like: -class Markdown::Parser - record PrefixHeader, count : Int32 - record UnorderedList, char : Char +class Markdown::Parser +record PrefixHeader, count : Int32 +record UnorderedList, char : Char REPOSIT

D12007: Add test case for parsing of double opening '(('

michaelh accepted this revision as: michaelh. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH b#392620_unittest REVISION DETAIL https://phabricator.kde.org/D12007 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraha

D7909: Add syntax support for Crystal Programming Language

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Ah, I let just the build run once more locally, the current static check says: "/local/cullmann/kf5/src/frameworks/syntax-highlighting/data/syntax/crystal.xml" Unused ite

D7909: Add syntax support for Crystal Programming Language

cullmann added a comment. > Great!, This is my first contribution to The KDE project, I'm very happy you accepted it! :) I assume that means I shall push? :=) REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann, vkrause, #framework_syntax_

Re: KNewStuff - CMake targets hardcoding paths

Hi, On dimanche 8 avril 2018 04:30:15 CEST Ben Cooksley wrote: > Hi all, > > On Windows the Binary Factory has recently struck an issue with > KNewStuff where the paths supplied in the newstuffqmlplugin target it > installs are hardcoded. > > This can be seen at the bottom of > https://binary-fa

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#242391 , @cullmann wrote: > The hard-coded colors got removed, test is there, all fine. > Thanks for the contribution! > If you can't push youself, tell me, I will push for you. Great!, This is my fi

D11828: Simplify orPostingIterator and make it faster

michaelh added a comment. I'm not very familiar with the concept of iterators (yet). To me it looks like `auto i = new OrPostingIterator(iters); i->docId();` will return 0 and `i->next()` returns a valid docId. After that `i->docId();` is also valid. Is this how iterators work? Naively I wo

D11851: Add syntax highlighting for Logcat

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think it looks ok, no hard-coded colors, it seems to pass the basic static checks and we have a testcase. I would more like to have a test case in plain english, but the text just s

D12016: [ktexteditor] much faster positionFromCursor

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hi, I appreciate the intend to speed this up. But I think, to do this proper, it might make more sense to cache the current position in the KateViewAccessible and invalidat

D7245: Improve reStructuredText highlighting

cullmann added a comment. Sorry, for the tests: inside the autotests, there is input/reference/html Just add your testcase in input, run the tests, take a look at the results and check them in as references. REVISION DETAIL https://phabricator.kde.org/D7245 To: turbov, #kate, #framework_

D7909: Add syntax support for Crystal Programming Language

cullmann accepted this revision. cullmann added a comment. The hard-coded colors got removed, test is there, all fine. Thanks for the contribution! If you can't push youself, tell me, I will push for you. REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: fagui

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/71/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sun, 08 Apr 2018 08:18:45 + Build duration: 9 min 34 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sun, 08 Apr 2018 08:18:45 + Build duration: 5 min 56 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/54/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 08 Apr 2018 08:18:45 + Build duration: 4 min 40 sec and counting JUnit Tes

D12014: [kcoreaddons] convert to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R244:ae47ecdb2839: [kcoreaddons] convert to new connect syntax (authored by jtamate). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12014?vs=31570&id=31653 REVISIO

D11828: Simplify orPostingIterator and make it faster

michaelh added a comment. While reading in IDE realized `(*it)` resolves to `PostingIterator**` I got a little dizzy at first, then started to play with this code and came up with this. In Constructor: for (PostingIterator* it : m_iterators) { if (it == nullptr) { m_ite