D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. In D12077#246406 , @rkflx wrote: > Ah, small misunderstanding: I was mainly referring to not making Above filename (in conjunction with Short View) the overall default for the dialog. If Detailed (Tree) View was the

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham set the repository for this revision to R241 KIO. ngraham added subscribers: Dolphin, rkflx. Restricted Application added a project: Frameworks. REPOSITORY R241 KIO REVISION DETAIL

D12218: Remove Reload button from the file dialogs' toolbar

ngraham created this revision. ngraham added a reviewer: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Horizontal space on the toolbar is precious and scarce, and that Reload button is taking up some of it. Once there's a Reload button in the context menu, it can

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham added a dependent revision: D12218: Remove Reload button from the file dialogs' toolbar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 194 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/194/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 15 Apr 2018 04:12:56 + Build duration: 8 min 5 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 64 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/64/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 15 Apr 2018 04:12:56 + Build duration: 5 min 21 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 215 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/215/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 15 Apr 2018 04:12:56 + Build duration: 5 min 5 sec and counting JUnit Tests Name:

D12207: Use text "Other Application..." in "Open With" submenu

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12207 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12206: Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32164. ngraham added a comment. Simplify code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32162=32164 BRANCH no-open-with-for-folders (branched from master) REVISION DETAIL

D12206: Don't show top "Open With" app for folders; only for files

ngraham retitled this revision from "[RFC] Don't show top "Open With" app for folders; only for files" to "Don't show top "Open With" app for folders; only for files". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To:

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32162. ngraham added a comment. Restore original inconsistent whitespace REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32161=32162 BRANCH no-open-with-for-folders (branched from master) REVISION DETAIL

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham added a comment. In D12206#246415 , @rkflx wrote: > Are you sure? The API docs say that "A URL is a local file path if the scheme is "file".", i.e. it also applies to directories. The way I interpret `not very useful, especially for

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham updated this revision to Diff 32161. ngraham added a comment. Restore original logic, minus the unnecessary extra separator REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32153=32161 BRANCH no-open-with-for-folders (branched from master)

D12130: Use the more user-friendly string "File type" in the save dialogs

safaalfulaij added a comment. Btw, the `qt` tag is from Qt3 days. I'm not sure if it must be richtext, if so then a simple `html` or even KUIT markups are better choice :) Not sure about string freeze though.. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130

D10694: epubextractor: Handle multiple subjects better

bruns added a comment. Sorry to join late here ... A QMap can store multiple values for one key, and a client reading the Map can use QMap::values() to get a list of all matching properties. If a client naively uses value() instead, it just gets the first value for the key, but so be

D12197: autotests: Test for multiple values

bruns added a comment. "Prepare sample files for tags which may have multiple values" REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11745: databasesanitizer: Use flags for filtering

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Save the missing comment for "tmpfs", looks fine, thanks! INLINE COMMENTS > databasesanitizer.cpp:250 > auto mounted = info.isValid(); > - > -if (missingOnly && mounted) { >

D11753: baloodb: Add clean command

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > databasesanitizer.cpp:166 > > -private: > Transaction* m_transaction; Why do you remove the private: here? > databasesanitizer.cpp:176 > +

D12192: Decode more documentUrls

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after? REPOSITORY R293 Baloo REVISION DETAIL

D12135: Allow disabling of CoW to fail when not supported by filesystem

bruns added a comment. @michaelh can you accept - I can't ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12135 To: bruns, #baloo, adridg, #frameworks, michaelh Cc: adridg, #freebsd, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D12216: Don't need to run previous iterations commands again

apol created this revision. apol added reviewers: Frameworks, arojas. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY BUG: 393141 TEST PLAN Tested building plasma-workspace, it was clearly faster (although it would have finished

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx accepted this revision. rkflx added a comment. Ah, small misunderstanding: I was mainly referring to not making Above filename (in conjunction with Short View) the overall default for the dialog. If Detailed (Tree) View was the default, changing the mode of Short View is probably

D12130: Use the more user-friendly string "File type" in the save dialogs

rkflx added a comment. > In D12130#245826 , @rkflx wrote: > >> > in a new user account >> >> That's a bit pointless in this case, why would you let your reviewers jump through such hoops… > > > Not sure what you mean? Making

D12206: [RFC] Don't show top "Open With" app for folders; only for files

rkflx edited reviewers, added: elvisangelaccio; removed: rkflx. rkflx added a subscriber: elvisangelaccio. rkflx added a comment. @ngraham The way I understood @elvisangelaccio was that the possibility to open a folder with another application should stay, but featured less prominently (i.e.

D12207: Use text "Other Application..." in "Open With" submenu

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. LGTM, as discussed in D11569#235002 . REPOSITORY R241 KIO BRANCH open-with-other-application (branched from master) REVISION DETAIL

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks Cc: michaelh, ngraham, bruns

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Add a Reload menu item to KDirOperator's context menu, so clients that don't display a toolbar but might need to

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: [RFC] Don't show top "Open With" app for folders; only for files

ngraham retitled this revision from "[RFC] Don't show "Open With" for folders, as was apparently originally intended" to "[RFC] Don't show top "Open With" app for folders; only for files". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY

D12206: [RFC] Don't show "Open With" for folders, as was apparently originally intended

ngraham updated this revision to Diff 32153. ngraham added a comment. Instead of removing the "Open With" entries entirely, only remove the inline "Open in " entry REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12206?vs=32143=32153 BRANCH

D12206: [RFC] Don't show "Open With" for folders, as was apparently originally intended

ngraham retitled this revision from "Don't show "Open With" for folders, as was apparently originally intended" to "[RFC] Don't show "Open With" for folders, as was apparently originally intended". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham,

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: Zren, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. In D12206#246301 , @Zren wrote: > > So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? > > Hmmm? Ah I missed D11569

D12206: Don't show "Open With" for folders, as was apparently originally intended

Zren added a comment. > So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? Hmmm? Ah I missed D11569 . So the proposal is we don't show the inline "Open with Gwenview"

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32147. michaelh added a comment. - Ignore tmpfs devices REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32104=32147 BRANCH sanitize-enums (branched from master) REVISION DETAIL

D12206: Don't show "Open With" for folders, as was apparently originally intended

Zren added a comment. - Open with "Sublime Text" / "Atom" - Open with "K4DirStat" - Open with "Clementine" Comix, Gwenview, VLC, $MediaPlayer will usually "autoplay" the next file in a folder, so this won't really affect those apps. Do we really need these apps to define a

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. So you're proposing that folders show the Open With... entry, but omit the recently added additional entry that shows the first app? Sounds reasonable enough to me. Does anyone else feel otherwise? REPOSITORY R241 KIO REVISION DETAIL

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. In D12206#246284 , @ngraham wrote: > In D12206#246282 , @michaelh wrote: > > > "Open with VLC" is of course nonsense. > > > Huh? Not sure I understand. The

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. In D12206#246284 , @ngraham wrote: > In D12206#246282 , @michaelh wrote: > > > I find "Open with..." for folders useful. > > > What apps do you typically open

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham added a comment. In D12206#246282 , @michaelh wrote: > I find "Open with..." for folders useful. What apps do you typically open folders in? What's the use case? In D12206#246282 ,

D12206: Don't show "Open With" for folders, as was apparently originally intended

michaelh added a comment. I find "Open with..." for folders useful. "Open with VLC" is of course nonsense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12207: Use text "Other Application..." in "Open With" submenu

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12207 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12207: Use text "Other Application..." in "Open With" submenu

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Use the text "Other Application..." in the {nav Open With submenu, because it makes a bit clearer what's

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12206 To: ngraham, #frameworks, rkflx Cc: michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY According to a comment in the code, Open With was never supposed to show up for folders in the first place,

D12017: taglibextractortest: Test for multiple values

michaelh abandoned this revision. michaelh added a comment. Superseded by D12197 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12017 To: michaelh Cc: #frameworks, astippich, mgallien, ashaposhnikov, michaelh, spoorun,

D10694: epubextractor: Handle multiple subjects better

michaelh updated this revision to Diff 32124. michaelh edited the summary of this revision. michaelh added a comment. Remove tests from epubextractortest use multivaluetest instead Depends on D12197 REPOSITORY R286 KFileMetaData CHANGES SINCE LAST

D10694: epubextractor: Handle multiple subjects better

michaelh edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, firef, ngraham, andrebarros,

D10694: epubextractor: Handle multiple subjects better

michaelh added a dependency: D12197: autotests: Test for multiple values. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D10694 To: michaelh, mgallien, dfaure Cc: bruns, astippich, #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, firef,

D12197: autotests: Test for multiple values

michaelh added a dependent revision: D10694: epubextractor: Handle multiple subjects better. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12197 To: michaelh, #baloo, #frameworks, mgallien Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D12197: autotests: Test for multiple values

michaelh added inline comments. INLINE COMMENTS > multivaluetest.cpp:86 > + > +// Provide Property::Subject only when there is exactly one dc:subject > +QTest::newRow("epub/1 subject") The following behaviours need to be discussed. They are just suggestions. REPOSITORY R286

D12197: autotests: Test for multiple values

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, mgallien. Restricted Application added projects: Frameworks, Baloo. michaelh requested review of this revision. REVISION SUMMARY Prepare sample files with multiple tags - epub: 'dc:subject' - office docs:

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: ngraham, #frameworks, #vdg, rkflx, abetts Cc: abetts, cfeck, alexeymin, michaelh, ngraham, bruns

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

ngraham updated this revision to Diff 32114. ngraham added a comment. Rebase on current master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12149?vs=32094=32114 BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 AFFECTED FILES

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham edited the test plan for this revision. REPOSITORY R241 KIO BRANCH arcpatch-D12077 REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx, #vdg, abetts Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham added a comment. Yes, when the filename or metadata are the primary tools for differentiating files, having the items presented in a list format is much much better, as in your example of browsing for source files. But keep in mind that source files and other textual documents are

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham updated this revision to Diff 32113. ngraham added a comment. Use Detailed Tree View and adjust separators and spacing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=32112=32113 BRANCH arcpatch-D12077 REVISION DETAIL

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 14 Apr 2018 13:54:19 + Build duration: 1 min 42 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 25 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/25/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sat, 14 Apr 2018 13:54:19 + Build duration: 1 min 38 sec and counting JUnit Tests

D12077: Show view mode buttons in the open/save dialog's toolbar

ngraham updated this revision to Diff 32112. ngraham added a comment. This revision is now accepted and ready to land. Rebase on current master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31884=32112 BRANCH arcpatch-D12077 REVISION DETAIL

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh added a subscriber: bruns. michaelh added a comment. @bruns: `autotests/unit/engine/queryparsertest.cpp` and `autotests/unit/engine/termgeneratortest.cpp` are encoded with iso-8859-15. Maybe you're able to convert them to utf-8. Even with a lot of help I couldn't. Please give it

D11587: [WIP] autotests: Introduce TermGeneratorTestUTF

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11587 To: michaelh, #baloo, #frameworks Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12192: Decode more documentUrls

michaelh added inline comments. INLINE COMMENTS > transaction.cpp:469 > for (quint64 id: allIds) { > QByteArray url = docUrlDb.get(id); > if (url.isEmpty()) { For your convenience REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12192 To:

D12192: Decode more documentUrls

michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R293 Baloo BRANCH file-encoding

D12044: baloodb: Improve interface

michaelh planned changes to this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12044 To: michaelh, #baloo, ngraham Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32105. michaelh added a comment. - Adapt to upstream changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=31208=32105 BRANCH sanitize-clean (branched from master) REVISION DETAIL

D11745: databasesanitizer: Use flags for filtering

michaelh updated this revision to Diff 32104. michaelh added a comment. - Adapt to upstream changes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11745?vs=32014=32104 BRANCH sanitize-enums (branched from master) REVISION DETAIL

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

kpiwowarski abandoned this revision. kpiwowarski added a comment. Fixed by R159:9b47babb6c41 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D10691 To: kpiwowarski, #plasma,

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. In D10702#243605 , @jtamate wrote: > This freezing process happens for me in ktorrent the first time in a day I delete a file, but not the files after, even if they are iso images (>4GiB). > Are we sure the problem is

D12172: Android: Also install plugins, otherwise they are just not available

vkrause added a comment. In D12172#245790 , @apol wrote: > Yes, it's something I'd like to look into. I haven't found documentation for it yet. There is none I think, apart from the qmake and androiddeployqt sources ;-( REPOSITORY

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

rjvbb added a comment. David, Could you please push it for me? I probably won't be able to do so for at least a week and it'd be a pity if the change just misses a release because of that. Thanks. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. I think this patch makes sense, even though I'm sad that it doesn't actually fix the bug I was seeing (you call it broken config file, in that case that would mean that the code writing

D12077: Show view mode buttons in the open/save dialog's toolbar

rkflx added a comment. In D12077#245762 , @ngraham wrote: > If we did this (after making icons-on-top mode the default for file pickers ), then both Dolphin and the file pickers would have the same

D12149: Improve grid spacing in icons-on-top mode for open/save dialogs

rkflx accepted this revision. rkflx added a comment. Thanks ;) Anybody from #Frameworks still having objections on code or behaviour? REPOSITORY R241 KIO BRANCH arcpatch-D12149 REVISION DETAIL https://phabricator.kde.org/D12149 To: