KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 266 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/266/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 21 May 2018 03:23:38 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 116 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/116/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 21 May 2018 03:23:38 + Build duration: 9 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/21/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 21 May 2018 03:23:38 + Build duration: 5 min 4 sec and counting JUnit Tests Name:

D12218: Remove Reload button from the file dialogs' toolbar

ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Should we land this onto the `file-dialog-improvements` branch, or are folks still unsure? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc:

D12647: Move the inline preview button into the menu

ngraham added a comment. Should we land this on the `file-dialog-improvements` branch, or are folks still unsure? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added a comment. Done. I've created the `file-dialog-improvements` branch and landed this there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth,

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham removed a dependency: D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does. REPOSITORY R241 KIO BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: kde-frameworks-devel,

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham removed a dependent revision: D12337: Give the file dialogs a "Sort by" menu button on the toolbar. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, ngraham, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. In D12986#265699 , @abetts wrote: > What should be the end result of this patch? Hopefully something like our latest mockup: F5860717: new version.png Do folks

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.9 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks karchive kf5-qt5 SUSEQt5.9 Date of build: Sun, 20 May 2018 22:10:17 + Build duration: 4 min 4 sec and counting JUnit Tests

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.10/17/ Project: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 20 May 2018 22:10:17 + Build duration: 2 min 25 sec and counting JUnit

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.10 - Build # 23 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.10/23/ Project: Frameworks karchive kf5-qt5 SUSEQt5.10 Date of build: Sun, 20 May 2018 22:10:17 + Build duration: 1 min 11 sec and counting JUnit Tests

KDE CI: Frameworks karchive kf5-qt5 FreeBSDQt5.10 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20FreeBSDQt5.10/7/ Project: Frameworks karchive kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 20 May 2018 22:10:17 + Build duration: 53 sec and counting JUnit Tests

KDE CI: Frameworks karchive kf5-qt5 AndroidQt5.10 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20AndroidQt5.10/9/ Project: Frameworks karchive kf5-qt5 AndroidQt5.10 Date of build: Sun, 20 May 2018 22:10:17 + Build duration: 40 sec and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 115 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/115/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 20 May 2018 22:02:16 + Build duration: 7 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/20/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 20 May 2018 22:02:16 + Build duration: 4 min 36 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 265 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/265/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 20 May 2018 22:02:16 + Build duration: 4 min 53 sec and counting JUnit Tests Name:

D9672: Don't emit error signal before we tried all list commands.

aacid closed this revision. aacid added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This already landed in bc4ea213b1d948b921236db29e78846c34496db7

D10903: Preserve fragment when redirecting from http to https

aacid closed this revision. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10903 To: guoci, #plasma, dfaure Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns, #frameworks

KDE CI: Frameworks karchive kf5-qt5 AndroidQt5.10 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20AndroidQt5.10/8/ Project: Frameworks karchive kf5-qt5 AndroidQt5.10 Date of build: Sun, 20 May 2018 21:48:56 + Build duration: 2 min 13 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20WindowsMSVCQt5.10/16/ Project: Frameworks karchive kf5-qt5 WindowsMSVCQt5.10 Date of build: Sun, 20 May 2018 21:48:56 + Build duration: 58 sec and counting CONSOLE

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks karchive kf5-qt5 SUSEQt5.9 Date of build: Sun, 20 May 2018 21:48:56 + Build duration: 52 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks karchive kf5-qt5 SUSEQt5.10 - Build # 22 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20SUSEQt5.10/22/ Project: Frameworks karchive kf5-qt5 SUSEQt5.10 Date of build: Sun, 20 May 2018 21:48:56 + Build duration: 33 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks karchive kf5-qt5 FreeBSDQt5.10 - Build # 6 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks karchive kf5-qt5 FreeBSDQt5.10 Date of build: Sun, 20 May 2018 21:48:56 + Build duration: 27 sec and counting CONSOLE OUTPUT

D11155: handle zip files embedded within zip files

This revision was automatically updated to reflect the committed changes. Closed by commit R243:07e5678981c6: handle zip files embedded within zip files (authored by sandsmark, committed by aacid). Restricted Application added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265687 , @rkflx wrote: > In my personal experience spending more time on a limited set of items leads to better results and less churn (as in reverting commits, number of iterations per patch etc.) than only

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. In my personal experience spending more time on a limited set of items leads to better results and less churn (as in reverting commits, number of iterations per patch etc.) than only lightly touching a large amount of issues everywhere. Of course you can do whatever

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265675 , @rkflx wrote: > In D12986#265666 , @ngraham wrote: > > > In D12986#265662 , @rkflx wrote: > > > > > Anyway,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. What are you actually asking me to do? Stop changing strings? Stop advocating for design changes? Stop submitting patches that implement design changes? Submit better patches that don't require so much reviewer time? Stop submitting patches entirely? Do less of

D12130: Use the more user-friendly string "File type" in the save dialogs

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130 To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts Cc: kde-frameworks-devel, safaalfulaij, davidc, ltoscano, cfeck, rkflx, alexeymin, abetts, bruns, michaelh,

D12858: [KCharSelect] Fix table cell size

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, works great now! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12858 To: cfeck, #frameworks, rkflx Cc: rkflx, elvisangelaccio,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. > The value is in standardizing on something. Personally I'd be okay with a consistent style per application, with the new style applied to new applications, and allowing exceptions where it makes sense. You've already witnessed the amount of bikeshedding in

D12130: Use the more user-friendly string "File type" in the save dialogs

rkflx added a comment. @ngraham I guess you are still working on this, or did you move on to other things in the meantime? (And please set the status to "Changes planned", so this does not clog up the review queue). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12130

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. In D12986#265666 , @ngraham wrote: > In D12986#265662 , @rkflx wrote: > > > Anyway, I'm not complaining too much (but please be aware that every change you propose creates

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. In D12986#265662 , @rkflx wrote: > > The value is in standardizing on something. > > Personally I'd be okay with a consistent style per application, with the new style applied to new applications, and allowing

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. In D12986#265633 , @rkflx wrote: > Just noticed that I based my suggestion on your screenshot, but missed to see that you changed the semantics compared to the original dialog: The trash won't be emptied completely

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. Thanks, "Size" and "Full trash" are looking good now. In D12986#265235 , @rkflx wrote: > In D12986#265231 , @ngraham wrote: > > > Yeah, that makes sense. Suggestions

D12992: New elisa icon

ngraham added a reviewer: Elisa. ngraham added a comment. Very nice in general! I feel like the "e" wrapping around the musical note is a nice concept, but it looks a bit busy to me. In particular, the musical note kinds of blends in and becomes indistinct. And the "e" reminds me of the one

D12896: Add Telegram plugin

nicolasfella added a comment. Can this even work with Telegram installed as sandboxed Flatpak? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. In D12986#265556 , @abetts wrote: > That looks really good IMHO. Thanks! A lot of the credit goes to Henrik, with his excellent eye for UI design. > Somewhat unrelated, I have seen a few UIs recently that

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265552 , @ngraham wrote: > Like this? > > F5860366: Radiobutton version.png That looks really good IMHO. Somewhat unrelated, I have seen a few UIs recently that

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. Like this? F5860366: Radiobutton version.png REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg Cc: abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

abetts added a comment. In D12986#265235 , @rkflx wrote: > In D12986#265231 , @ngraham wrote: > > > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > > F5859259:

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. Good idea, perhaps some radio buttons would make more sense here. I'll play around with it and try other languages. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg Cc: abetts, rkflx, kfm-devel,

D11925: Add "SkipSwitcher" to API

graesslin added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. any update on this? It's just the version increase in registry.cpp which is missing... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

graesslin added a comment. Restricted Application added a subscriber: kde-frameworks-devel. any update on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen,

D12858: [KCharSelect] Fix table cell size

cfeck updated this revision to Diff 34516. cfeck retitled this revision from "[KCharSelect] Fix table cell width" to "[KCharSelect] Fix table cell size". cfeck edited the summary of this revision. cfeck added a comment. Also limit cell height. REPOSITORY R236 KWidgetsAddons CHANGES SINCE

D12992: New elisa icon

lshoravi created this revision. lshoravi added reviewers: VDG, ngraham. lshoravi added a project: Elisa. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. lshoravi requested review of this revision. REVISION SUMMARY New elisa

D12858: [KCharSelect] Fix table cell width

rkflx added a comment. Not sure whether that's material for this patch, but for me the vertical spacing is still a bit off, i.e. the boxes are still not square as before: Qt 5.10: F5859388: kcharselect-qt5.10.png Qt 5.11: F5859390:

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

rkflx added a comment. In D12986#265231 , @ngraham wrote: > Yeah, that makes sense. Suggestions welcome, of course. Is this any better? > F5859259: After 2.png Hm, I think after the checkbox there