D12896: Add Telegram plugin

apol added a comment. In D12896#265606 , @nicolasfella wrote: > Can this even work with Telegram installed as sandboxed Flatpak? If we use the desktop file, yes. :) REPOSITORY R495 Purpose Library REVISION DETAIL

D12992: New elisa icon

lshoravi added a comment. **This** works pretty well, though. F5863172: image.png F5863176: image.png What's the consensus? REPOSITORY R266 Breeze Icons REVISION DETAIL

D12992: New elisa icon

lshoravi added a comment. Last thing I try for tonight. F5863162: image.png White works *fairly* well, but still not all that preferable F5863167: image.png REPOSITORY R266 Breeze Icons REVISION

D12992: New elisa icon

alex-l added a comment. In D12992#266121 , @lshoravi wrote: > Here's a different iteration > > F5862923: image.png > > The e is "supposed" to double as a clef, but it might also be a little noisy

D13024: add entity OSD to general.entites

lueck closed this revision. lueck added a comment. commited with https://cgit.kde.org/kdoctools.git/commit/?id=20621d3351844aa96160c3922447a74265c20ab7 REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D13024 To: lueck, #documentation, ltoscano Cc:

D13018: Fix unit test for kfileplacesmodeltest

elvisangelaccio added a comment. Hmm, still seems to fail here: $ ctest -R kfileplacesmodeltest Test project /home/elvis/dev/kde/kio/local-build Start 50: kiofilewidgets-kfileplacesmodeltest 1/1 Test #50: kiofilewidgets-kfileplacesmodeltest ...***Failed0.60 sec

D12992: New elisa icon

lshoravi added a comment. The suggestion above is too noisy. Its useless at low sizes. This is another suggestion, but the drawback was that it has no relation to elisa itself. F5862982: image.png REPOSITORY R266 Breeze Icons REVISION

D12992: New elisa icon

abetts added a subscriber: andreask. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: andreask, kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, januz, ngraham, bruns,

D12992: New elisa icon

lshoravi added a comment. It's not very 'breezy' though... REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: kde-frameworks-devel, ssteffen, lcmscheid, nhuisman, ursjoss, mykolak, jussiv, michaelh, ognarb, januz,

D12992: New elisa icon

lshoravi added a comment. Here's a different iteration F5862923: image.png The e is "supposed" to double as a clef, but it might also be a little noisy REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To:

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham created this revision. ngraham added reviewers: KTextEditor, Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. ngraham requested review of this revision. REVISION SUMMARY Fixes Kate/KWrite's

D13024: add entity OSD to general.entites

ltoscano accepted this revision as: ltoscano. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D13024 To: lueck, #documentation, ltoscano Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13024: add entity OSD to general.entites

lueck created this revision. lueck added a reviewer: Documentation. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY > 10 hits in trunk

D12689: Lua: updated for Lua5.3

jpoelen added a comment. @dhaumann The difference is in the `dynamic` attribute of a context. Kate propagates the captures only if the value is `true` whereas SyntaxHighlighting never looks at that value and only uses the `dynamic` attribute of the rules. Personally, I find that having

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34581. renatoo added a comment. Add missing url REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34580=34581 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp

D12320: [RFC] add ability to read embedded cover files

astippich added a comment. any more comments? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh, bruns Cc: anthonyfieroni, kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13018: Fix unit test for kfileplacesmodeltest

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. renatoo requested review of this revision. TEST PLAN Run "kiofilewidgets-kfileplacesmodeltest" make sure that "testRemoteUrls" is passing

D12820: Add KWayland virtual desktop protocol

graesslin added inline comments. INLINE COMMENTS > mart wrote in org_kde_plasma_virtual_desktop.xml:45 > the virtualdesktop would then have an output property used for filtering? > or, the layout event could be kept in the manager, but be not just rows and > column, but pass the pair output and

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 162 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/162/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 21 May 2018 12:09:14 + Build duration: 9 min 25 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 21 May 2018 12:09:14 + Build duration: 8 min 15 sec and counting

D10848: Templates: consistent naming, fix translation catalog names & more

This revision was automatically updated to reflect the committed changes. Closed by commit R242:98e64e01a611: Templates: consistent naming, fix translation catalog names more (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D10848: Templates: consistent naming, fix translation catalog names & more

kossebau updated this revision to Diff 34574. kossebau added a comment. add comment about the need to adapt org.kde.plasma namespace REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10848?vs=28085=34574 BRANCH brushovertemplates

D10848: Templates: consistent naming, fix translation catalog names & more

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. good to go, modulo that possible little code comment more INLINE COMMENTS > kossebau wrote in

D12820: Add KWayland virtual desktop protocol

mart added inline comments. INLINE COMMENTS > graesslin wrote in org_kde_plasma_virtual_desktop.xml:45 > Have a look at i3. Btw it's a really often requested feature. the virtualdesktop would then have an output property used for filtering? or, the layout event could be kept in the manager, but

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

davidedmundson added a comment. Please also fill in the testing done field. INLINE COMMENTS > tooltip.cpp:162 > +dlg->SetAutoShowHide(m_autoShowHide); > +connect(dlg, :.containtsMouseChanged, this, > ::toolTipWindowContainsMouseChangedSlot); > dlg->setVisible(true); doing a

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. The code doesn't merge, and after fixing that manually that the code doesn't build

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 21 May 2018 08:49:43 + Build duration: 3 min 11 sec and counting JUnit

D11822: Make the word/char count a global preference

aacid closed this revision. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate, mwolff, cullmann Cc: kwrite-devel,