D12388: Output device color curves correction

romangg marked 2 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks, davidedmundson, graesslin Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, ngraham, bruns

D12388: Output device color curves correction

romangg updated this revision to Diff 34770. romangg added a comment. - Send color curves only for version 2 and above REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33564=34770 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/9/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 24 May 2018 04:37:45 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Thu, 24 May 2018 04:37:45 + Build duration: 9 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/47/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Thu, 24 May 2018 04:37:45 + Build duration: 8 min 56 sec and counting JUnit Tests

D13076: Increase org_kde_plasma_shell interface version

This revision was automatically updated to reflect the committed changes. Closed by commit R127:f0363584861c: Increase org_kde_plasma_shell interface version (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13076?vs=34745=34768 REVISION

D13076: Increase org_kde_plasma_shell interface version

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Works for me, (and makes sense). Thanks for debugging this @romangg REPOSITORY R127 KWayland BRANCH fixPlasmaShellVersion REVISION DETAIL https://phabricator.kde.org/D13076 To:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 269 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/269/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 24 May 2018 03:30:05 + Build duration: 14 min and counting JUnit Tests Name: (root)

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham abandoned this revision. ngraham added a comment. Let's do this in a more sensible and better-performing way with D13082 and D13083 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048

D13083: Respect custom directory icons in iconNameForURL()

ngraham edited the summary of this revision. ngraham set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083

D13083: Respect custom directory icons in iconNameForURL()

ngraham added a dependency: D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore. REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham added a dependent revision: D13083: Respect custom directory icons in iconNameForURL(). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

ngraham created this revision. ngraham added reviewers: Frameworks, apol, broulik. ngraham requested review of this revision. REVISION SUMMARY With `iconFromDirectoryFile()` a public function thanks to D13082 , we can use it to get custom icons for folders

D12992: New elisa icon

januz added a comment. TBH I like the concept of the cassette icon more than the current implementation of it. What was good about about is that it had //personality//, which is a big deal since usually icons also double as logos. IMO a solid icon should be 1) Memorable and 2) Descriptive.

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

ngraham created this revision. ngraham added reviewers: Frameworks, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This allows us to use them in

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 23 May 2018 20:18:54 + Build duration: 7 min 53 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 23 May 2018 20:18:54 + Build duration: 1 min 59 sec and counting JUnit Tests

D12896: Add Telegram plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:6f74cbb9659f: Add Telegram plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34737=34750 REVISION DETAIL

D12896: Add Telegram plugin

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Okay, let's land this and I'll try to fix it myself. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc:

D13076: Increase org_kde_plasma_shell interface version

romangg created this revision. romangg added reviewers: Plasma, sharvey. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. romangg requested review of this revision. REVISION SUMMARY It was forgotten in 10b00a219e

D12896: Add Telegram plugin

nicolasfella updated this revision to Diff 34737. nicolasfella added a comment. : - Hardcode commands and try until success REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34213=34737 BRANCH master REVISION DETAIL

D12320: [RFC] add ability to read embedded cover files

bruns added inline comments. INLINE COMMENTS > embeddedimagedata.cpp:67 > + > +if (types & EmbeddedImageData::FrontCover || types & > EmbeddedImageData::AllImages) { > +imageData.insert(EmbeddedImageData::FrontCover, > d->getFrontCover(fileUrl,mimeType)); If you follow the

D12896: Add Telegram plugin

nicolasfella added a comment. I played around a bit and it turns out more difficult than expected. - telegram-desktop-bin from AUR has telegramdesktop.desktop whereas the Flatpak version has org.telegram.desktop.desktop, so we would need to look for at least those desktop files - the

D12992: New elisa icon

ngraham added a comment. Without meaning to offend whoever made the cassette icon, I think any variant of the one proposed here is hugely better. If I recall, I wasn't overly fond of the cassette icon when it was first proposed and predicted that it would not be popular. Sure enough, that's

D13067: add pgf to the latex-ish file formats (same format as tikz)

jan.hajer created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jan.hajer requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D12896: Add Telegram plugin

apol added a comment. In D12896#267091 , @nicolasfella wrote: > In D12896#266713 , @apol wrote: > > > Then just read the Exec field and we'll add the sendpath by hand. This is ad-hoc for telegram

D12896: Add Telegram plugin

nicolasfella added a comment. In D12896#266713 , @apol wrote: > Then just read the Exec field and we'll add the sendpath by hand. This is ad-hoc for telegram anyway. I'm not quite sure what to do. Best I came up with is something like

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

bruns added inline comments. INLINE COMMENTS > kcoredirlister_p.h:302 > +// Remove the item from the sorted list (from the wrong place) and > insert it in the right place. > +void reinsert(KFileItem , const QUrl ) > +{ This can be better implemented with std::move and

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13048 To: ngraham, #frameworks, broulik Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

ngraham updated this revision to Diff 34715. ngraham added a comment. Merge master to get those nice test fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13048?vs=34675=34715 BRANCH iconNameForUrl (branched from master) REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 118 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/118/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 23 May 2018 14:11:18 + Build duration: 17 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 268 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/268/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 23 May 2018 14:11:18 + Build duration: 5 min 36 sec and counting JUnit Tests Name:

D13061: Fixed kfileplacesviewtest when not running on empty home

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a6f88d7e9c69: Fixed kfileplacesviewtest when not running on empty home (authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13061: Fixed kfileplacesviewtest when not running on empty home

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, thanks! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D13061 To: renatoo, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

bruns added inline comments. INLINE COMMENTS > kfileitem.cpp:1248 > +{ > +return d->m_hash < other.d->m_hash; > +} This is incomplete for two cases: 1. Same URL 2. Hash collision > kfileitem.h:490 > +/** > + * Returns -1 if other's URL is greater, 0 if == and 1 if less than (as >

D13061: Fixed kfileplacesviewtest when not running on empty home

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. renatoo requested review of this revision. REVISION SUMMARY Make sure that the test always run on a empty home dir REPOSITORY R241 KIO BRANCH

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate updated this revision to Diff 34708. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Based on the tests done in D12945

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/31/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Wed, 23 May 2018 11:59:42 + Build duration: 1 min 45 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 6 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 23 May 2018 11:59:42 + Build duration: 1 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 267 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/267/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 23 May 2018 11:28:07 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/25/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Wed, 23 May 2018 11:36:47 + Build duration: 3 min 48 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.10/10/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 23 May 2018 11:36:47 + Build duration: 2 min 17 sec and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 117 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/117/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 23 May 2018 11:28:07 + Build duration: 6 min 4 sec and counting JUnit Tests Name: (root)

D13018: Fix unit test for kfileplacesmodeltest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2c478f4e429b: Fix unit test for kfileplacesmodeltest (authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266694 , @bruns wrote: > Shouldn't this be handled by: > http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled this is different "setTestModeEnabled" sets the XDG_* dirs but the KIO tests

D13043: Properly sanitize input

broulik added inline comments. INLINE COMMENTS > kconcatenaterowsproxymodel.cpp:70 > const QAbstractItemModel *sourceModel = sourceIndex.model(); > +if (!sourceModel) > +return {}; Coding style, braces also for single line statements > kconcatenaterowsproxymodel.cpp:112 >

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/12/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Wed, 23 May 2018 06:07:15 + Build duration: 4 min 17 sec and counting JUnit

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/4/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 23 May 2018 06:07:15 + Build duration: 1 min 55 sec and counting

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Wed, 23 May 2018 06:07:15 + Build duration: 1 min 44 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 163 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/163/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 23 May 2018 06:06:06 + Build duration: 2 min 51 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/15/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 23 May 2018 06:06:05 + Build duration: 2 min 20 sec and counting