D13398: [KFileItem] Check most local URL for whether it's shared

broulik created this revision. broulik added reviewers: gregormi, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `desktop:/` KIO rewrites the URL but it is

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. In D13365#274965 , @brauch wrote: > To submit the change with your name on it, I'd need a full name and email address, can you provide that? Thanks! Name: Shubham Mail: aryan100jan...@gmail.com REPOSITORY

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/37/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 07 Jun 2018 03:43:22 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/61/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Jun 2018 03:43:22 + Build duration: 5 min 20 sec and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 173 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/173/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 07 Jun 2018 03:43:21 + Build duration: 3 min 24 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/24/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 07 Jun 2018 03:43:21 + Build duration: 2 min 35 sec and counting

D13395: Pony: fix single quote escape and a possible infinite loop with #

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-pony REVISION

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35730. smithjd added a comment. Split-up scheduler overhaul patchset. - The power state signal should only be emitted when the power state changes. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume

D13394: C++: update for c++20 and fix some syntax errors

jpoelen edited the summary of this revision. jpoelen added a reviewer: dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - new keywords, attributes and standard macros - hexadecimal floatting point (c++17)

D13216: Overhaul the file index scheduler.

bruns added a comment. If I understand your summary correctly, your patch changes different things. While these are clearly related, can you try to separate the changes? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc:

Re: KDE Frameworks 5.47.0

On mercredi 6 juin 2018 23:10:52 CEST Albert Astals Cid wrote: > El dimecres, 6 de juny de 2018, a les 12:55:15 CEST, Jonathan Riddell va > > escriure: > > On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote: > > > Dear packagers, > > > > > > KDE Frameworks 5.47.0 has been uploaded to

Re: KDE Frameworks 5.47.0

El dimecres, 6 de juny de 2018, a les 12:55:15 CEST, Jonathan Riddell va escriure: > On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote: > > Dear packagers, > > > > KDE Frameworks 5.47.0 has been uploaded to the usual place. > > KFileMetaData continues not to compile That was already

D13365: Fixed the cursor(caret) width in kate

brauch added a comment. To submit the change with your name on it, I'd need a full name and email address, can you provide that? Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch, cullmann Cc: cullmann, ngraham,

D12992: New elisa icon

mgallien added a comment. In D12992#269849 , @abetts wrote: > In D12992#269803 , @lshoravi wrote: > > > @abetts Yes, I've been concepting a little on different ideas but not really coming anywhere

D13216: Overhaul the file index scheduler.

mgallien added a comment. Sounds good to me. I will try to do a proper review as soon as I can. Sorry for the delay. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13302: check for needed version of libavcode, libavformat and libavutil

mgallien updated this revision to Diff 35712. mgallien added a comment. - checks if FFmpeg provides the new API and use it only in this case extend the existing configure header to allow to compile both versions of the code in the FFmpeg extractor in case the new API exists, we

D13386: haskell.xml: remove types from "prelude function" section

xialiyao created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. xialiyao requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH haskell-remove-nonsense REVISION DETAIL

D13384: FrameSvg: Do not wreck shared mask frames

zzag updated this revision to Diff 35705. zzag added a comment. Move `maskFrame->cachedBackground = QPixmap();` to the maskFrame->refcount() == 1 branch. Do we really need this assignment? REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D13384: FrameSvg: Do not wreck shared mask frames

zzag updated this revision to Diff 35704. zzag added a comment. Do not invalidate looked up frames. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13384?vs=35699=35704 BRANCH dont-wreck-shared-mask-frames REVISION DETAIL

D13380: haskell.xml: don't highlight Prelude data constructors differently from others

xialiyao updated this revision to Diff 35703. xialiyao added a comment. Apply similar change to class names REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13380?vs=35684=35703 BRANCH haskell-data-prelude REVISION DETAIL

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a comment. Sorry for the nasty diff. Caching is hard. :( REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

zzag created this revision. zzag added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY It might happen that the maskFrame is shared by

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/23/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 06 Jun 2018 17:56:57 + Build duration: 4 min 20 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 172 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/172/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Jun 2018 17:56:07 + Build duration: 3 min 31 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/22/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 06 Jun 2018 17:52:02 + Build duration: 4 min 53 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 171 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/171/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Jun 2018 17:52:02 + Build duration: 4 min 4 sec and counting

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R242:a46cd14553c2: FrameSvg: Draw corners only if both borders in both directions are enabled (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

This revision was automatically updated to reflect the committed changes. Closed by commit R242:dce258bee3da: FrameSvg: Recache maskFrame if enabledBorders has been changed (authored by zzag). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

zzag added a comment. In D13215#274782 , @mart wrote: > it has nothing to do with compositing, but it *should* fix the non composite mask never the less, as it was coming from a misrendering of the framesvg Could someone please show me

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

zzag added a comment. In D13218#274785 , @mart wrote: > how does this relates with D13215 ? If maskFrame isn't recached after enabledBorders has been changed, I would expect the "After" picture rather

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-paintcorner REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma, #frameworks, mart Cc: mart, kde-frameworks-devel, ragreen, Pitel,

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

mart added a project: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma, #frameworks Cc: mart, kde-frameworks-devel, ragreen, Pitel, michaelh, ZrenBot, ngraham, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

mart added a comment. how does this relates with D13215 ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma, #frameworks Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-framesvg-alphamask REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks, mart Cc: abetts, mart, aseigo, broulik,

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

mart added a comment. In D13215#270880 , @zzag wrote: > In D13215#270878 , @broulik wrote: > > > Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in

D13034: Add mechanism to notify other clients of config changes over DBus

zzag added inline comments. INLINE COMMENTS > kconfigwatcher.cpp:61 > + > +for(const QString : watchedPaths) { > +QDBusConnection::sessionBus().connect(QString(), I think you forgot qAsConst. ;-) for (const QString : qAsConst(watchedPaths)) { REPOSITORY R237 KConfig BRANCH

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

abetts added a comment. What can we do to help this patch move forward @zzag ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: FrameSvg: Recache maskFrame if enabledBorders has been changed

zzag retitled this revision from "FrameSVG: Recache maskFrame if enabledBorders has been changed" to "FrameSvg: Recache maskFrame if enabledBorders has been changed". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma,

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

zzag retitled this revision from "Draw FrameSVG corners only if both borders in both directions are enabled" to "FrameSvg: Draw corners only if both borders in both directions are enabled". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To:

D13218: FrameSvg: Draw corners only if both borders in both directions are enabled

zzag added a comment. Ping. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

brauch added a comment. Yes that looks better, I'll submit it later today. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch, cullmann Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D13380: haskell.xml: don't highlight Prelude data constructors differently from others

xialiyao created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. xialiyao requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH haskell-data-prelude REVISION DETAIL

D13365: Fixed the cursor(caret) width in kate

shubham updated this revision to Diff 35683. shubham added a comment. I believe this is the final patch. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13365?vs=35643=35683 REVISION DETAIL https://phabricator.kde.org/D13365 AFFECTED FILES

D13358: Add new class that is a model of numbers between two values

davidedmundson updated this revision to Diff 35681. davidedmundson marked an inline comment as done. davidedmundson added a comment. Most review comments As for the locale enum, I'm not sure. I'm working on a QML module and I'm trying to resolve any QML specific issues there rather

D13034: Add mechanism to notify other clients of config changes over DBus

davidedmundson marked 2 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in kconfigwatcher.cpp:82 > no, `parts` is `const` zzag was right then I changed it, but I hadn't clicked the "done" checkbox after fixing. REPOSITORY R237 KConfig BRANCH

D13034: Add mechanism to notify other clients of config changes over DBus

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > zzag wrote in kconfigwatcher.cpp:82 > Won't this detach? no, `parts` is `const` REPOSITORY R237 KConfig BRANCH master REVISION DETAIL

D13358: Add new class that is a model of numbers between two values

davidedmundson marked 11 inline comments as done. davidedmundson added a comment. > In all the documentation blocks you miss the argument and return value documentation. Are there any instances where that would provide any added value? INLINE COMMENTS > broulik wrote in

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. Thank you Brauch for your quick reply. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch, cullmann Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns,

D13365: Fixed the cursor(caret) width in kate

brauch added a comment. Click "download raw diff" at the top-right of the page. This is the diff you uploaded. This is not the change we want to apply when merging this review request; it only contains the changes you did from your earlier version to the latest one, not the set of changes

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. In D13365#274589 , @brauch wrote: > The change is good now but you screwed up the patch: you need to submit the full set of changes you want to do as a patch, not only the last iteration. Can you fix that? Thank

Re: KDE Frameworks 5.47.0

On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote: > Dear packagers, > > KDE Frameworks 5.47.0 has been uploaded to the usual place. KFileMetaData continues not to compile Jonathan

D13358: Add new class that is a model of numbers between two values

broulik added a comment. Just saw I forgot to submit those comments yesterday INLINE COMMENTS > knumbermodeltest.cpp:26 > +QCOMPARE(m.rowCount(), 3); > +QCOMPARE(m.data(m.index(0, 0), Qt::DisplayRole), QVariant("3")); > +QCOMPARE(m.data(m.index(1, 0),

D13365: Fixed the cursor(caret) width in kate

brauch added a comment. The change is good now but you screwed up the patch: you need to submit the full set of changes you want to do as a patch, not only the last iteration. Can you fix that? Thank you! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. In D13365#274460 , @cullmann wrote: > Yep, looks nice! Thank you for accepting the patch. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch,

D13377: Fixup @since for skip switcher API

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. fvogt requested review of this revision. REVISION SUMMARY Not released yet. TEST PLAN

D13365: Fixed the cursor(caret) width in kate

shubham added a comment. In D13365#274453 , @brauch wrote: > Yep, with that, it looks good to me. Do you have commit access? Thank you for committing it on my behalf REPOSITORY R39 KTextEditor REVISION DETAIL

D6313: Support Icon Scale from Icon naming specification 0.13

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R302:20f7137145f6: Support Icon Scale from Icon naming specification 0.13 (authored by broulik). CHANGED PRIOR TO COMMIT

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/23/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 06 Jun 2018 07:16:05 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Jun 2018 07:16:05 + Build duration: 6 min 41 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 06 Jun 2018 07:16:05 + Build duration: 6 min 55 sec and counting JUnit Tests

D13377: Fixup @since for skip switcher API

This revision was automatically updated to reflect the committed changes. Closed by commit R127:46f333a06508: Fixup @since for skip switcher API (authored by fvogt). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13377?vs=35663=35664 REVISION DETAIL

D13377: Fixup @since for skip switcher API

stikonas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13377 To: fvogt, #plasma, stikonas Cc: kde-frameworks-devel, michaelh, ngraham, bruns