D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

jpoelen added a comment. Ok, i'm doing this in the week. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. There have been changes in the xml files that will cause conflicts. I would look in the next few days. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc:

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 197 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/197/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 13 Aug 2018 22:19:55 + Build duration: 2 min 21 sec and counting

D14810: Improve Widgets' removal and configure text

ngraham added a comment. Thanks! REPOSITORY R242 Plasma Framework (Library) BRANCH remove-this-widget (branched from master) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg, abetts Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

ngraham closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg, abetts Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

abetts accepted this revision. abetts added a comment. This revision is now accepted and ready to land. This patch is sensible, it saves some strings, space, and it is grammatically consistent. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-this-widget (branched from master)

D14810: Improve Widgets' removal and configure text

abetts added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

broulik added a comment. +1 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14118: Improve "Remove this [widget]" text

ngraham abandoned this revision. ngraham added a comment. Dangit, git. Let's try again: D14810: Improve Widgets' removal and configure text REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14118 To: ngraham,

D14810: Improve Widgets' removal and configure text

ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14810 To: ngraham, #plasma, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14810: Improve Widgets' removal and configure text

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This patch makes the text for removal and

D11838: Turn on line numbers by default

ngraham added a comment. Thanks so much, guys! So much improvement in so little time. It's very impressive. Probably this particular patch is now obsolete. I guess now we need a way for individual KTextEditor-using apps to pre-populate entries in their local rc files or something.

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik updated this revision to Diff 39645. broulik added a comment. - Fix top, should have worn my glasses when reading that REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14308?vs=39519=39645 REVISION DETAIL https://phabricator.kde.org/D14308

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14308 To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns Cc: anthonyfieroni, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14308 To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns Cc: anthonyfieroni, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns added a comment. Bits ber pixel? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14308 To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns Cc: anthonyfieroni, bruns

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

davidedmundson added a comment. We went from 7 failing unit tests on CI to..6! Progress, but not done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14743 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, michaelh, ngraham,

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns added a comment. In D14308#308137 , @broulik wrote: > > Should be "Prefer higher BPP" > > That's just the internal changelog on Phabricator. Can we ship this already.. See "Summary: " ... INLINE COMMENTS >

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in icoutils_common.cpp:100 > No, that is the actual file name on qtbase git dev

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 196 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/196/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 13 Aug 2018 20:42:59 + Build duration: 7 min 7 sec and counting

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0ae178016adb: Copy PlasmaCore binary qmldir file structure into bin for unit tests (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D14743 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14808: Add QVector> Definition::characterEncodings() const

This revision was automatically updated to reflect the committed changes. Closed by commit R216:581e41dfd3ac: Add QVectorQPairQChar, QString Definition::characterEncodings() const (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D14808: Add QVector> Definition::characterEncodings() const

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Last missing piece for KTextEditor. REPOSITORY R216 Syntax Highlighting BRANCH expose-encoding-mappings (branched from master) REVISION DETAIL https://phabricator.kde.org/D14808

D14808: Add QVector> Definition::characterEncodings() const

dhaumann created this revision. dhaumann added reviewers: vkrause, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Returns a list of

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik added a comment. > Should be "Prefer higher BPP" That's just the internal changelog on Phabricator. Can we ship this already..? INLINE COMMENTS > bruns wrote in icoutils_common.cpp:100 > qico_handler.cpp (no "n") No, that is the actual file name on qtbase git dev REPOSITORY

D11838: Turn on line numbers by default

dhaumann added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. We now have application-local settings. What now? Are we closer to solving this? ...I guess not: Either it's on for all applications or off for all

D14799: Add bool Definition::foldingEnabled() const

This revision was automatically updated to reflect the committed changes. Closed by commit R216:de651c8cb6b3: Add bool Definition::foldingEnabled() const (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14799?vs=39622=39632#toc REPOSITORY R216 Syntax Highlighting

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns added a comment. Should be "Prefer higher BPP" (bits per pixel), DPI is dots per inch, i.e. spatial resolution. INLINE COMMENTS > icoutils_common.cpp:100 > +// but they store the actual depth of the icon extracted in custom > text: > +//

D14799: Add bool Definition::foldingEnabled() const

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. IMHO makes sense and one of the last missing pieces for KTextEditor. REPOSITORY R216 Syntax Highlighting BRANCH expose-folding-enabled (branched from master) REVISION DETAIL

D7033: Port ki18n from QtScript to QtQml

This revision was automatically updated to reflect the committed changes. Closed by commit R249:9040bff75a5d: Port ki18n from QtScript to QtQml (authored by carewolf). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7033?vs=39526=39629 REVISION DETAIL

D7033: Port ki18n from QtScript to QtQml

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess it's better to accept this now than later to have a longer testing period at Akademy and until the frameworks release. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL

D14800: kioslave/Mac : proxy the bundle-exec and make an agent

rjvbb set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14800 To: rjvbb Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14800: kioslave/Mac : proxy the bundle-exec and make an agent

rjvbb updated this revision to Diff 39623. rjvbb added a comment. Use a current instead of an obsolete platform token. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14800?vs=39620=39623 REVISION DETAIL https://phabricator.kde.org/D14800 AFFECTED FILES

D14799: Add bool Definition::foldingEnabled() const

dhaumann updated this revision to Diff 39622. dhaumann added a comment. - Add another test, now all code paths are tested REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14799?vs=39621=39622 BRANCH expose-folding-enabled (branched from

D14800: kioslave/Mac : proxy the bundle-exec and make an agent

rjvbb created this revision. rjvbb added a project: Frameworks. rjvbb requested review of this revision. REVISION SUMMARY (I thought I had committed this already...) On Mac, kioslave must be built as an app bundle to prevent keyboard input issues (for instance during the authentication

D14799: Add bool Definition::foldingEnabled() const

dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY foldingEnabled()

D14743: Copy PlasmaCore binary qmldir file structure into bin for unit testsThis way tests pass before installation.

davidedmundson updated this revision to Diff 39614. davidedmundson added a comment. Update REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14743?vs=39458=39614 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14743

D7909: Add syntax support for Crystal Programming Language

faguilar added a comment. In D7909#307484 , @cullmann wrote: > Hi, did you get some time to look at the remaining issues? > If they are fixed, I am happy to merge that. Hi, I haven't fixed the issues yet. I'm working on that, I will

D14118: Improve "Remove this [widget]" text

ngraham updated this revision to Diff 39608. ngraham added a comment. Make the text consistent REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14118?vs=38365=39608 BRANCH remove-this-widget (branched from master) REVISION DETAIL

D14757: Warn user before copy operation if available space is not enough

shubham added a comment. A question requestMessageBox( ) is a "pure virtual" function inside "jobUiDelegateExtension" class which is implemented in "jobUiDelegate" class which is the derived class of "jobUiDelegateExtension". When I resolve requestMessageBox() using : : like this

D13880: [KMoreTools] Reduce menu hierarchy

dhaumann added a comment. Ok - then with minor changes, let's move this forward. Who is going to do the work? :-) INLINE COMMENTS > kmoretools.cpp:650 > +if (mstruct.mainItems.isEmpty()) { > +createMoreMenu(mstruct, menu); > +} else { This line then changes to

D13880: [KMoreTools] Reduce menu hierarchy

ngraham added a comment. I'm okay with this patch as a first step, FWIW. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

ngraham added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14787 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14674: handle non-ASCII encodings of file names in tar archives

ibragimovrinat added a comment. Thanks! REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck, ibragimovrinat, kde-frameworks-devel, michaelh, ngraham, bruns

D7033: Port ki18n from QtScript to QtQml

dfaure added a comment. +1, looks good to me (but I'm no QJSEngine expert) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D7033 To: carewolf, ilic Cc: dfaure, kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, michaelh, bruns

D14674: handle non-ASCII encodings of file names in tar archives

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent, thanks for the contribution. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14674 To: ibragimovrinat, dfaure, kossebau Cc: xyquadrat, broulik, cfeck,

D14757: Warn user before copy operation if available space is not enough

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > CMakeLists.txt:153 > KF5::DBusAddons# KDEInitInterface > + KF5::WidgetsAddons > ) Please remove > copyjob.cpp:49 > > +#include > + Please remove > copyjob.cpp:892 > +

D12662: Add InlineNoteInterface

michalsrb added a comment. In D12662#307752 , @brauch wrote: > I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an

D12662: Add InlineNoteInterface

brauch added a comment. I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an updated patch here, in case I actually come up with useful changes ... REPOSITORY R39

D14785: Fix DialogNativeTest in multi screen configuration

ngraham added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14785 To: habacker, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14787: Fix 'ThemeTest::testCompositingChange() fails if windows manager is running'

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY Skip the test in that case and show the reason. BUG: 397418 FIXED-IN: 5.50.0

D14772: Deprecate KFilterProxySearchLine

kossebau added inline comments. INLINE COMMENTS > kfilterproxysearchline.h:48 > > -class KITEMVIEWS_EXPORT KFilterProxySearchLine > +class KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED KFilterProxySearchLine > : public QWidget Why not KITEMVIEWS_DEPRECATED_EXPORT? While being defined as

D14785: Fix DialogNativeTest in multi screen configuration

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY On multi screen configuration the x coordinate of the primary screen may not be

D14772: Deprecate KFilterProxySearchLine

This revision was automatically updated to reflect the committed changes. Closed by commit R276:f5fef035e5a2: Deprecate KFilterProxySearchLine (authored by svuorela). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14772?vs=39579=39580 REVISION DETAIL

D14772: Deprecate KFilterProxySearchLine

dfaure accepted this revision. REPOSITORY R276 KItemViews BRANCH master REVISION DETAIL https://phabricator.kde.org/D14772 To: svuorela, kossebau, dfaure Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D14772: Deprecate KFilterProxySearchLine

svuorela updated this revision to Diff 39579. svuorela added a comment. Improve deprecation documentation REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14772?vs=39528=39579 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14772

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#307597 , @dhaumann wrote: > What is the current state of this? > The new private functions should move to the pimpl class behind the d-pointer. > > In general: Looking at the public classes, /all/

D14772: Deprecate KFilterProxySearchLine

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. This class was doing it with a timer, I wonder if that should be part of the recommendation ("use QLineEdit with a timer"), or if we don't recommend delaying the searching as a general

D14778: Disable loading of translations when using 'C' locale

habacker added a comment. Just as info: kcoreaddons uses '(s)' suffix in its internal formating methods (https://cgit.kde.org/kcoreaddons.git/commit/src/lib/util/kformatprivate.cpp?id=ffcd094c1f4716a0d91650608e42017886a0a7e3) which is always translated with or without 's' 'not always

D14639: Add syntax-highlighting for RDoc (R documentation)

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0b8d8acf816a: Add syntax-highlighting for RDoc (R documentation) (authored by aaronpuchert). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D14778: Disable loading of translations when using 'C' locale

habacker added a comment. No, both LC_ALL=C and LC_ALL=en fetches the same english translation ~/src/kf5/kcoreaddons-build> LC_ALL=en strace -e trace=file bin/kformattest 2>&1 | grep \.qm | grep R_OK access("/usr/share/locale/en/LC_MESSAGES/kcoreaddons5_qt.qm", R_OK) = 0

D14732: Actually allow to set the refresh rate for device statistics

volkov closed this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D14732 To: volkov, #frameworks, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9247: Extend Scripting API to allow executing commands

dhaumann marked 2 inline comments as done. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9247 To: dhaumann, cullmann, mwolff, kfunk Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D9247: Extend Scripting API to allow executing commands

dhaumann updated this revision to Diff 39575. dhaumann added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. - Apply proposed fixes - Merge branch 'master' into CommandScript REPOSITORY R39 KTextEditor CHANGES SINCE

D13880: [KMoreTools] Reduce menu hierarchy

dhaumann added a comment. What is the current state of this? The new private functions should move to the pimpl class behind the d-pointer. In general: Looking at the public classes, /all/ the private functions should have been hidden behind the pimpl class... REPOSITORY R304

D14772: Deprecate KFilterProxySearchLine

vkrause added a comment. +1, and also too narrow regarding being specific to QLineEdit and QSFPM. If at all this should be just the logic, and be independent of the UI. REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D14772 To: svuorela, kossebau, dfaure Cc:

D4619: Printing: Respect footer font, fix footer vertical position, make header/footer separator line visually lighter

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9b0d8dce4977: Printing: Respect footer font, fix footer vertical position, make header/footer… (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D14762: Proposal: Add "None" highlighting to repository per default

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6166da7503e6: Add None highlighting to repository per default (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14762?vs=39522=39572#toc REPOSITORY R216 Syntax

D14762: Proposal: Add "None" highlighting to repository per default

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14762 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D14763: Definition: Expose command markers

cullmann added a comment. > Does KTE only support one comment marker of each type? Then this is ok IMHO. Yes, all others were silently discarded. Later one should check that there is only on in the static checker. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D14763: Definition: Expose command markers

vkrause added a comment. Does KTE only support one comment marker of each type? Then this is ok IMHO. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14763 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,

D14778: Disable loading of translations when using 'C' locale

aacid added a comment. Doesn't setting the locale to en solve the same problem without needing to change ECM? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14778 To: habacker, #frameworks, apol Cc: aacid, kde-frameworks-devel, kde-buildsystem,

D14593: Update Logtalk language syntax support

dhaumann added a comment. Thanks goes to do - and sorry for the delay on our side. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel,

D14593: Update Logtalk language syntax support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:2ce2523452eb: Update Logtalk language syntax support (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14593?vs=39566=39568#toc REPOSITORY R216 Syntax Highlighting

D14593: Update Logtalk language syntax support

pmoura added a comment. Thanks for your help! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas,

D11543: Optimize many syntax highlighting files and fix the '/' char of SQL

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. Thanks, changes look, please

Re: purpose unittests on Windows

On Mon, Aug 13, 2018 at 1:16 AM David Faure wrote: > > On samedi 11 août 2018 07:02:18 CEST Ben Cooksley wrote: > > On Fri, Aug 10, 2018 at 7:28 PM David Faure wrote: > > > Any idea why purpose can't find the KIO http and file protocols -- on > > > Windows? > > > > > >

D14593: Update Logtalk language syntax support

cullmann accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura, michaelh, genethomas,

D14593: Update Logtalk language syntax support

pmoura added a comment. I'm on macOS and I only forked from GitHub the `syntax-highlighting` repo. I don't have the necessary infra-structure to compile `KSyntaxHighlighting` and generate the reference files. I would very much appreciate if you can take it from here. I did test the updated

Re: KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 41 - Still unstable!

Hi David, Unfortunately it doesn't look like the fix we put in place on Saturday did the trick. I have a feeling that QStandardPaths on Windows at least will also consider the Qt install prefix in addition to the local to the executable paths when searching for mime information. That would

D14593: Update Logtalk language syntax support

dhaumann accepted this revision. dhaumann added a comment. Shall we integrate this, or can you commit yourself? REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura,

D14593: Update Logtalk language syntax support

pmoura updated this revision to Diff 39566. pmoura added a comment. Added license to Logtalk highlighting test file. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14593?vs=39558=39566 REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES

D14692: Use custom QScrollArea with size hint not limited by font size

ngraham added a comment. Thanks so much! REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D14692 To: valeriymalov, #frameworks, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14692: Use custom QScrollArea with size hint not limited by font size

This revision was automatically updated to reflect the committed changes. Closed by commit R295:23ba2b37ef82: Use custom QScrollArea with size hint not limited by font size (authored by valeriymalov). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D14593: Update Logtalk language syntax support

dhaumann added a comment. Ok, perfect, thanks! I think "Apache License 2.0" is fine as well. It's just important that we do know the license, because otherwise it's a mess over time. How to create the reference. When compiling KSyntaxHighlighting, you then write: - make - make

D14778: Disable loading of translations when using 'C' locale

ngraham added reviewers: Frameworks, apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14778 To: habacker, #frameworks, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14778: Disable loading of translations when using 'C' locale

ngraham edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14778 To: habacker Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14593: Update Logtalk language syntax support

cullmann added a comment. If there is no redundancy, I am ok with that file. The license should be stated in it explicitly, will make it later easier to understand why we can use that. For the reference generation: after a run, you will get told that stuff diffs, e.g. you do make

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14779 To: habacker, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

ngraham edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14779 To: habacker Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14593: Update Logtalk language syntax support

pmoura added a comment. The test file tests everything that should be highlighted properly. There is no redundancy in it. It is large due to testing all built-in language features, including all that would be called keywords in other languages. It is the same test file that is used to check

D14758: use view lines for wheel scrolling, not real lines

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2815fea7854f: Fix: Scroll view lines instead of real lines for wheel and touchpad scrolling (authored by brauch). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14758?vs=39499=39561#toc

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY See D14778 for the related extra-cmake-modules

D14773: completion widget: fix minimum header section size

This revision was automatically updated to reflect the committed changes. Closed by commit R39:5499a0df825c: completion widget: fix minimum header section size (authored by brauch). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14773?vs=39533=39562

D7909: Add syntax support for Crystal Programming Language

cullmann added a comment. Restricted Application added a subscriber: kwrite-devel. Hi, did you get some time to look at the remaining issues? If they are fixed, I am happy to merge that. REPOSITORY R40 Kate REVISION DETAIL https://phabricator.kde.org/D7909 To: faguilar, dhaumann,

D14778: Disable loading of translations when using 'C' locale

habacker created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. habacker requested review of this revision. REVISION SUMMARY kcoreaddons test case 'kformattest' is designed not to

D14593: Update Logtalk language syntax support

dhaumann added a comment. Just curious: The test file looks good to me, but it looks to me that it also contains some redundancy: Think of it as follows: We use this for unit testing. As such, the best case is that a test file tests all the corner cases, but ideally only once. If a test

D14593: Update Logtalk language syntax support

pmoura added a comment. How do generate the reference files? No idea of what you mean by " let it run". REVISION DETAIL https://phabricator.kde.org/D14593 To: pmoura, dhaumann, cullmann, vkrause, #framework_syntax_highlighting, #kate Cc: kwrite-devel, kde-frameworks-devel, pmoura,

D14593: Update Logtalk language syntax support

pmoura updated this revision to Diff 39558. pmoura added a comment. Added `autotests/input/highlight.lgt` file. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14593?vs=39556=39558 REVISION DETAIL https://phabricator.kde.org/D14593 AFFECTED FILES autotests/input/highlight.lgt

  1   2   >