D14890: Remove QSaveFile in favor of plain old file saving

cullmann updated this revision to Diff 39956. cullmann added a comment. - better error handling, take a look at the file error string REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14890?vs=39921&id=39956 BRANCH nosavefile (branched from master) REVI

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Propagating the error is good in any case. Will later adapt my patch to use it, like you proposed. Still, my crash does happen independent of this I assume. REPOSITORY R243 KArchiv

D14308: [Exe Thumbnailer] Improve icon selection algorithm

bruns added inline comments. INLINE COMMENTS > icoutils_common.cpp:99 > +// QtIcoHandler converts all images to 32-bit depth > +// but they store the actual depth of the icon extracted in custom > text: > +// qtbase/src/plugins/imageformats/ico/qicohandler.cpp:455 gramma

D14915: Bindings: Check if bindings can be generated for a specific python version

bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The generated C++ sources include , so it must be available

D14890: Remove QSaveFile in favor of plain old file saving

dfaure added a comment. Fix for KCompressionDevice + addendum to this patch posted on https://bugs.kde.org/show_bug.cgi?id=397545 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel,

D14914: Bindings: Use python version matching the found clang python module

bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case both python 2.7 and 3 are installed, but clang pyth

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

dfaure created this revision. dfaure added a reviewer: cullmann. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY QFile::close() doesn't return a value, but sets an error st

D14912: Bindings: Make generator forward compatible with Python 3

bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY iteritems is no longer an available method for dict in Pyth

D14909: Bindings: Check for libclang without version suffix also

This revision was automatically updated to reflect the committed changes. Closed by commit R240:4b59c7708362: Bindings: Check for libclang without version suffix also (authored by bruns). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14909?vs=3994

D14909: Bindings: Check for libclang without version suffix also

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH find_libclang REVISION DETAIL https://phabricator.kde.org/D14909 To: bruns, #frameworks, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 132 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/132/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 21:41:16 + Build duration: 12 min and counting JUnit Tests N

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/131/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 21:27:36 + Build duration: 13 min and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/130/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 19:15:56 + Build duration: 16 min and counting JUnit Tests

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

graesslin added a comment. Sorry for strange upload, arc decided to no longer like me. I created the patch on Jun 30, 2017. Unfortunately the issue was embargo on freedesktop.org with the idea of a coordinated release. Today the patch for weston landed so I consider the embargo as lifted

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

graesslin created this revision. graesslin added reviewers: KWin, Frameworks, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY To better isolate the clients from each other eachh Key

D14909: Bindings: Check for libclang without version suffix also

bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The canonical name is libclang.so, which seems to be availa

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/86/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Aug 2018 18:52:45 + Build duration: 17 min and counting JUnit Tests Name

D14908: Bindings: Add support for scoped enums

bruns created this revision. bruns added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Keep the enum intact by emitting the class keyword in case

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/129/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 18:52:45 + Build duration: 5 min 59 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 85 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/85/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Aug 2018 16:35:04 + Build duration: 8 min 13 sec and counting JUnit Tests

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 128 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/128/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 16:35:04 + Build duration: 8 min 20 sec and counting JUnit Tests

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

bruns added a comment. In D7423#310509 , @fvogt wrote: > On neon it won't work as the kernel everything is built against (so the minimum API/ABI) is too old. You'll either have to hack around that by messing with include paths or use something mo

D14449: Modify device usage information

shubham abandoned this revision. shubham added a comment. Actually should be implemented using form layout REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14449 To: shubham, ngraham, #frameworks, rkflx Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, b

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 202 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/202/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 13:48:03 + Build duration: 3 min 46 sec and counting JU

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 201 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/201/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 13:44:34 + Build duration: 3 min 28 sec and counting JU

D14531: [Icon Item] Use ItemEnabledHasChanged

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e143f7d457f6: [Icon Item] Use ItemEnabledHasChanged (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14531?vs=38891&id=39923

D14819: Get rid of deprecated QWeakPointer usage

This revision was automatically updated to reflect the committed changes. Closed by commit R242:938cef210c79: Get rid of deprecated QWeakPointer usage (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14819?vs=39670&id=39

D14819: Get rid of deprecated QWeakPointer usage

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14819 To: broulik, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14531: [Icon Item] Use ItemEnabledHasChanged

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14531 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14890: Remove QSaveFile in favor of plain old file saving

cullmann updated this revision to Diff 39921. cullmann added a comment. skip filter dev hanlding in the common case of no compression compress in memory to the buffer for the kauth case this actually leads now to the wanted error message for uncompressed files in disk full situations w

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/84/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Aug 2018 12:38:58 + Build duration: 15 min and counting JUnit Tests Name

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 127 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/127/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 12:38:58 + Build duration: 5 min 2 sec and counting JUnit Tests

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

habacker added a comment. In D14779#310116 , @aacid wrote: > Did you have that problem when you made ecm not create a translator? no, therefore I created D14778 > > >> What is the drawback t

D14897: InlineNote: Pimpl inline note data without allocs

brauch added a comment. Sorry, never mind -- that code I removed yesterday. All should be fine. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14897 To: dhaumann, cullmann Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, de

D14897: InlineNote: Pimpl inline note data without allocs

dhaumann added a comment. Can you annotate the code here that you think is wrong? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14897 To: dhaumann, cullmann Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullman

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 126 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/126/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 11:06:32 + Build duration: 16 min and counting JUnit Tests

D14899: [KUrlComboBox] Fix KIcon porting error

This revision was automatically updated to reflect the committed changes. Closed by commit R241:64ba67d0acc4: [KUrlComboBox] Fix KIcon porting error (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14899?vs=39913&id=39914 REVISION DETAIL ht

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 83 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/83/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Aug 2018 11:06:32 + Build duration: 12 min and counting JUnit Tests Nam

D14899: [KUrlComboBox] Fix KIcon porting error

ngraham accepted this revision. ngraham added a comment. Whoops REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14899 To: broulik, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14899: [KUrlComboBox] Fix KIcon porting error

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14899 To: broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14899: [KUrlComboBox] Fix KIcon porting error

broulik created this revision. broulik added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It should be using `QIcon::fromTheme` TEST PLAN I don't actually know where this ic

D14897: InlineNote: Pimpl inline note data without allocs

brauch added a comment. Looks ok to me, except one thing: the operator== is used to compare a note from the list to the "currently active" note in the view. If this compares also the "under mouse" state, this code might be broken now ...? REPOSITORY R39 KTextEditor REVISION DETAIL https

D14897: InlineNote: Pimpl inline note data without allocs

dhaumann updated this revision to Diff 39911. dhaumann added a comment. - Rename InlineNote::hasFocus() to underMouse() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14897?vs=39910&id=39911 BRANCH inline-note-data (branched from master) REVISION DET

D14897: InlineNote: Pimpl inline note data without allocs

This revision was automatically updated to reflect the committed changes. Closed by commit R39:4e279cd72493: InlineNote: Pimpl inline note data without allocs (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14897?vs=39911&id=39912 RE

D14897: InlineNote: Pimpl inline note data without allocs

dhaumann updated this revision to Diff 39910. dhaumann added a comment. - Remove default constructor, not implemented anyways REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14897?vs=39909&id=39910 BRANCH inline-note-data (branched from master) REVISI

D14897: InlineNote: Pimpl inline note data without allocs

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH inline-note-data (branched from master) REVISION DETAIL https://phabricator.kde.org/D14897 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapav

D14897: InlineNote: Pimpl inline note data without allocs

dhaumann updated this revision to Diff 39909. dhaumann added a comment. - Cleanup InlineNote interface REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14897?vs=39907&id=39909 BRANCH inline-note-data (branched from master) REVISION DETAIL https://pha

D14897: InlineNote: Pimpl inline note data without allocs

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think that is ok, but one should remove column(), isValid() and == (which is no equal anyways ATM). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.o

D14897: InlineNote: Pimpl inline note data without allocs

dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Hide more implementation details and make InlineNote more exten

D14890: Remove QSaveFile in favor of plain old file saving

cullmann added a comment. I think the integration must wait until we resolve the KArchive issue. I have taken a short look but seen no "trivial" fix, opened a new bug for that, https://bugs.kde.org/show_bug.cgi?id=397545 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kd

D14529: Android: Make sure Qm translations get loaded

svuorela added a comment. In D14529#302624 , @aacid wrote: > Ok, second option, we are actually installing these files ourselves, right? It is where androiddeployqt puts things (I guess to avoid conflict with javastuff) REPOSITORY R240

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 200 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/200/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 17 Aug 2018 09:52:02 + Build duration: 3 min 23 sec and counting JU

D14890: Remove QSaveFile in favor of plain old file saving

cullmann requested review of this revision. cullmann added a comment. There is one tiny problem with that change: The compression filter device crashs sometimes, if you have bad luck, e.g. tried like David did show above with a small tmp mount: ASSERT: "d->avail_out > 0" in file /ho

D14890: Remove QSaveFile in favor of plain old file saving

cullmann updated this revision to Diff 39903. cullmann added a comment. - improve the error message, add vim like hint that one might loose data - Merge branch 'master' into nosavefile REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14890?vs=39884&id=39

D14894: [RFC] Fix block mode for multi-cursor branch

brauch added a comment. Thanks for the patch, the approach looks reasonable at a first glance. You might want to unite the up/down functions ... It is too much of a WiP to merge it like this, though. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14894 To: lep

D14896: Fix bzip main page

ltoscano closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14896 To: ltoscano, svuorela Cc: svuorela, kde-frameworks-devel, michaelh, ngraham, bruns

D14896: Fix bzip main page

svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. yesplease. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D14896 To: ltoscano, svuorela Cc: svuorela, kde-frameworks-devel, michaelh, ngraham

D14896: Fix bzip main page

ltoscano created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY The known domain is lost: https://lwn.net/Articles/762264/ https://lwn.net/Articles/762340/ REPOSITORY R243 KAr

D14890: Remove QSaveFile in favor of plain old file saving

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH nosavefile (branched from master) REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, k

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

fvogt requested changes to this revision. fvogt added a comment. This revision now requires changes to proceed. On neon it won't work as the kernel everything is built against (so the minimum API/ABI) is too old. You'll either have to hack around that by messing with include paths or use some