D14631: Adds a new RenameDialog to KIO with more options for batch renaming

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:65 > + rename/batchrenamedialog.cpp > +rename/batchrenamedialogmodel_p.cpp > +rename/batchrenametypes_p.cpp fix indent >

D16421: Improve emblem contrast, legibility and consistency

ngraham added a comment. In D16421#348381 , @ndavis wrote: > Here's how that looks: F6349192: Screenshot_20181024_234540.png Looks good to me! In D16421#348361

D16421: Improve emblem contrast, legibility and consistency

ndavis added a comment. In D16421#348363 , @ngraham wrote: > Yeah I understand. I'm not the hugest fan of the orange either, and now that I think about it, semantically it's not really accurate either since that color is for warning or unusual

D16421: Improve emblem contrast, legibility and consistency

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: ngraham, bcooksley, kde-frameworks-devel, #vdg, michaelh, bruns

D16421: Improve emblem contrast, legibility and consistency

ngraham added a comment. In D16421#348361 , @ndavis wrote: > I agree with you, but I also don't like the look of orange. It's just not a color that I would expect. I would be OK with making `emblem-added` and `emblem-remove` grey like the

D16421: Improve emblem contrast, legibility and consistency

ndavis added a comment. In D16421#348347 , @ngraham wrote: > Wow, these are truly excellent. I think you've done an amazing job! Thanks! > One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red.

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

ngraham added a comment. It makes sense to me to have that in this same patch. Pretty awesome stuff here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14631 To: emateli, #frameworks, dfaure Cc: asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, michaelh,

D16421: Improve emblem contrast, legibility and consistency

ngraham added subscribers: bcooksley, ngraham. ngraham added a comment. Wow, these are truly excellent. I think you've done an amazing job! One thing I'd like to discuss is whether or not we want the `emblem-remove` icon to be red. This color is typically reserved for destructive actions

D16421: Improve emblem contrast, legibility and consistency

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D16421: Improve emblem contrast, legibility and consistency

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Added outlines to 16 and 22 px icons Improved the legibility of 8px icons Added new 8,

D16395: Update the "About KDE" text

ngraham edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, michaelh,

D16395: Update the "About KDE" text

ngraham updated this revision to Diff 44192. ngraham added a comment. Tweak the wording, incorporating @xyquadrat's suggestions REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16395?vs=44135=44192 BRANCH update-about-kde-text (branched from master)

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

emateli updated this revision to Diff 44189. emateli added a comment. - use _p notation. Add BatchRenameDialog to installable headers --- Besides any current review, the last step for this patch would be to actually use the BatchRenameJob already in KIO. Regarding that: Should I put

D16403: Add services and appstream runner debug categories to categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:17a0d34d0e83: Add services and appstream runner debug categories to categories file (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16403: Add services and appstream runner debug categories to categories file

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16403 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16412: Add the possibility to have a keyboard shortcut to create a file

elvisangelaccio added inline comments. INLINE COMMENTS > knewfilemenu.cpp:755 > } else { > +if (m_firstFileEntry == nullptr) { > +m_firstFileEntry = `!m_firstFileEntry` > knewfilemenu.cpp:1263-1299 > +QString text =

D16416: z/OS CLIST file syntax highlighting

phily created this revision. phily added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. phily requested review of this revision. REVISION SUMMARY There was no support for CLIST syntax

D16415: Creating new syntax highlighting file for Job Control Language (JCL)

phily created this revision. phily added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. phily requested review of this revision. REVISION SUMMARY There is currently no support for JCL (Job

D16414: Changes to REXX syntax highlighting

phily created this revision. phily added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. phily requested review of this revision. REVISION SUMMARY The rexx syntax highlighting was incomplete. It

D16412: Add the possibility to have a keyboard shortcut to create a file

thsurrel added a dependent revision: D16413: Add a keyboard shortcut to create file. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16412 To: thsurrel, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16412: Add the possibility to have a keyboard shortcut to create a file

thsurrel created this revision. thsurrel added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY It is already possible to create a directory with a keyboard shortcut (F10 in

D16395: Update the "About KDE" text

xyquadrat added a comment. > KDE is a cooperative enterprise in which no single entity controls the efforts or efforts or products of KDE to the exclusion of others. I think this sentence is too complex. I'd suggest writing something like "KDE is a cooperative enterprise: nobody

D15842: Remove useless "No X-KDE-DBus-ServiceName found" message

This revision was automatically updated to reflect the committed changes. Closed by commit R297:22c5fd9f5a16: Remove useless No X-KDE-DBus-ServiceName found message (authored by bruns). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15842?vs=44172=44173

D15842: Remove useless "No X-KDE-DBus-ServiceName found" message

bruns updated this revision to Diff 44172. bruns retitled this revision from "Lower log level for X-KDE-DBus-ServiceName missing message" to "Remove useless "No X-KDE-DBus-ServiceName found" message". bruns added a comment. Completely remove message REPOSITORY R297 KDED CHANGES SINCE LAST

D16395: Update the "About KDE" text

ngraham added a reviewer: KDE Promo. ngraham added a comment. Agreed, we can wait until after 5.52 is tagged before landing this (assume we even get consensus before then. :) ) In D16395#347814 , @abetts wrote: > > KDE has created the

D15842: Lower log level for X-KDE-DBus-ServiceName missing message

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. If it's not a requirement for it to be set (and it isn't) I agree it's not a useful warning. But it's also not remotely useful debug. It's easy to see when something is

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f7d13812e2c5: [Config] Remove KDE4 config support, stop writing arbitrary config files (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fair enough, that's true. Go for it! REPOSITORY R293 Baloo BRANCH excludes REVISION DETAIL https://phabricator.kde.org/D16392 To: bruns, #baloo, #frameworks, poboiko, ngraham Cc:

D15842: Lower log level for X-KDE-DBus-ServiceName missing message

bruns added a comment. Ping! REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D15842 To: bruns, #frameworks, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16409: [Bookmarks Runner] Open database connection in the query thread

bruns added a dependent revision: D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16409 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D16409: [Bookmarks Runner] Open database connection in the query thread

bruns added a dependency: D16405: Add debug category for bookmarks runner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16409 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D16405: Add debug category for bookmarks runner

bruns added a dependent revision: D16409: [Bookmarks Runner] Open database connection in the query thread. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16405 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

bruns added a dependency: D16409: [Bookmarks Runner] Open database connection in the query thread. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16410 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The favicon and places instances are created in the prepare() call, leaking the instance from the

D16409: [Bookmarks Runner] Open database connection in the query thread

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY QSqlDatabase connection instances are global reference counted objects which can be crated using

D16405: Add debug category for bookmarks runner

bruns added a comment. Only applies cleanly after D16403 . REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16405 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D16405: Add debug category for bookmarks runner

bruns added a dependency: D16403: Add services and appstream runner debug categories to categories file. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16405 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D16403: Add services and appstream runner debug categories to categories file

bruns added a dependent revision: D16405: Add debug category for bookmarks runner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16403 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16405: Add debug category for bookmarks runner

bruns added a comment. Depends on the cleanup in D16404 , as the autogenerated `bookmarks_debug.cpp` is not linked to the tests/testChromeBookmarks binary otherwise. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns added a dependent revision: D16405: Add debug category for bookmarks runner. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D16405: Add debug category for bookmarks runner

bruns added a dependency: D16404: [Bookmarks Runner] Cleanup tests CMakeList. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16405 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16405: Add debug category for bookmarks runner

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16405 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16405: Add debug category for bookmarks runner

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Dependency for followup patches, no functional change TEST PLAN make REPOSITORY R120 Plasma

D16402: Cleanup - remove unnecessary QIcon include

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9945aecaf2eb: Cleanup - remove unnecessary QIcon include (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16402?vs=44159=44163

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Build the test dependencies as static library. Remove duplicate and commented out lines. Use

D16402: Cleanup - remove unnecessary QIcon include

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH db_fix_2 REVISION DETAIL https://phabricator.kde.org/D16402 To: bruns, #frameworks, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16403: Add services and appstream runner debug categories to categories file

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Make the debug categories visible in kdebugsettings REPOSITORY R120 Plasma Workspace BRANCH

D16402: Cleanup - remove unnecessary QIcon include

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY QIcon is only used in the implementation, not in the interface. TEST PLAN compile tested, no

D16387: [sftp] put request chunk debugging into own category

This revision was automatically updated to reflect the committed changes. Closed by commit R320:bf4563e8d291: [sftp] put request chunk debugging into own category (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16387?vs=44112=44153#toc REPOSITORY R320 KIO Extras

D15070: Bindings: Support using sys paths for python install directory

bruns added inline comments. INLINE COMMENTS > FindPythonModuleGeneration.cmake:455 > install(DIRECTORY > ${CMAKE_BINARY_DIR}/py${pyversion}/${GPB_PYTHONNAMESPACE} > -DESTINATION > lib/python${pyversion${pyversion}_maj_min}/site-packages) > install(FILES

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. In D15070#347945 , @cgiboudeaux wrote: > In D15070#347944 , @bruns wrote: > > > So, after another week, no reason has been given not to accept this. > > > > 1. It fixes

D15070: Bindings: Support using sys paths for python install directory

cgiboudeaux added a comment. In D15070#347944 , @bruns wrote: > So, after another week, no reason has been given not to accept this. > > 1. It fixes broken behavior on several platforms > 2. It does not break current setups > 3. It is

D15070: Bindings: Support using sys paths for python install directory

bruns added a comment. So, after another week, no reason has been given not to accept this. 1. It fixes broken behavior on several platforms 2. It does not break current setups 3. It is consistent with other config variables REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D16395: Update the "About KDE" text

ltoscano added a comment. In D16395#347938 , @rizzitello wrote: > Why does this dialog not say anything about the version of KDE. There is *no* version of KDE. KDE is only the community. It's clearly stated in that message. >

D16395: Update the "About KDE" text

rizzitello added a comment. Why does this dialog not say anything about the version of KDE. I think here the KF5 version and maybe the Qt Version should be shown here. I always found it kinda odd that the "About Application" dialog contains this and not the About KDE dialog. REPOSITORY

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:24bdc06747ed: [server] Respect input region of sub-surfaces on pointer surface focus (authored by romangg).

D16266: [Extractor] Make extractor crash resilient

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > poboiko wrote in filecontentindexer.cpp:91 > OK, we can simply count how many times we got `finishedIndexingFile`, and > just go to the corresponding position in the batch. > It's just the binary search here

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 93 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/93/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 24 Oct 2018 11:59:04 + Build duration: 5 min 27 sec and counting JUnit Tests Name: (root)

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg updated this revision to Diff 44149. romangg added a comment. Rebase on master. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7038?vs=42733=44149 BRANCH inputRegionSubSurfaces REVISION DETAIL https://phabricator.kde.org/D7038 AFFECTED

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

romangg edited the summary of this revision. romangg edited the test plan for this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin, davidedmundson Cc: davidedmundson, zzag, kde-frameworks-devel, graesslin,

D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

bruns added a comment. In D16392#347781 , @ngraham wrote: > Looks good, but what's our transition plan? Does this need any special handling for people who already have old config files? Currently, there is some garbage left in a few

D16395: Update the "About KDE" text

ltoscano added a comment. I'd say that the respecting the string freeze this time makes sense, as we need a bit more time to discuss this. Maybe the promo team can help too, as this is an important message. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To:

D16395: Update the "About KDE" text

aspotashev added a comment. FYI, according to an old custom mentioned at https://community.kde.org/Schedules/Frameworks , KF5.52 is already in string freeze, thus this change may only be pushed after 5.52 is released. However you can ask for an exception in the kde-i18n-doc mailing list

D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

This revision was automatically updated to reflect the committed changes. Closed by commit R265:8a9cec559211: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is… (authored by yurchor). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16350?vs=44126=44145#toc

D16385: [sftp] reformat to 4 space indentation

This revision was automatically updated to reflect the committed changes. Closed by commit R320:972b5f5ef074: [sftp] reformat to 4 space indentation (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16385?vs=44109=44144 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 174 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/174/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 24 Oct 2018 08:14:10 + Build duration: 3 min 57 sec and counting JUnit Tests Name:

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileplacesview.cpp:257 > You can make lambda mutable in there you can modify m_freeSpaceInfo without > declare it mutable No ignore it, it does not work. REPOSITORY R241 KIO REVISION DETAIL

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

anthonyfieroni added inline comments. INLINE COMMENTS > kfileplacesview.cpp:256 > +(!info.lastUpdated.isValid() || > info.lastUpdated.secsTo(QDateTime::currentDateTimeUtc()) > 60)) { > +info.job = KIO::fileSystemFreeSpace(url); > +

D16265: [Scheduler] Use flag to track when a runner is going idle

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. The changes look sane to me. Perhaps wait a couple more days until any other objection is raised, then if not, commit away. REPOSITORY R293 Baloo REVISION DETAIL

D16311: RFC: [KFilePlacesView] Use asynchronous KIO::FileSystemFreeSpaceJob

lbeltrame added a comment. +1, but I'd like to hear people more experienced than me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16311 To: broulik, #frameworks, dfaure, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns