D17193: KateViewInternal: Remove unneeded functions

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I would prefer function calls to members, in the most cases, the performance difference is not measurable, even without inline. For non-exported functions that are one

D17220: Use red X in disabled and muted status icons consistently

ndavis added a reviewer: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 347 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/347/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Nov 2018 04:26:48 + Build duration: 6 min 32 sec and counting JUnit Tests Name: (root) Failed: 0

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46444. pranavgade added a comment. Updated diff from prev commit->changes to latest commit->changes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46392=46444 REVISION DETAIL https://phabricator.kde.org/D17210 AFFECTED FILES

D17220: Use red X in disabled and muted status icons consistently

ngraham added a comment. You're the hero KDE needs. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

ndavis added a comment. In D17220#367858 , @ngraham wrote: > In D17220#367849 , @ndavis wrote: > > > Here's what the Breeze Plasma desktop theme uses for the `network-wireless-off` icon: F6445522:

D17220: Use red X in disabled and muted status icons consistently

ngraham added a comment. In D17220#367849 , @ndavis wrote: > Here's what the Breeze Plasma desktop theme uses for the `network-wireless-off` icon: F6445522: Screenshot_20181128_204458.png That fact

D17220: Use red X in disabled and muted status icons consistently

ndavis added a comment. Could a distinction between "off" and "muted" be useful? If that is true, then we should keep the red horizontal dash for muted and use a red slash through the whole icon for off/disabled. In general, I think a red X should mean "error", but we're not consistent

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

This revision was automatically updated to reflect the committed changes. Closed by commit R246:3247994e52a6: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button (authored by loh.tar, committed by ngraham). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar added a comment. Bug302689 - Impossible to delete unwanted dictionaries https://bugs.kde.org/show_bug.cgi?id=302689 Does not quite fit, but relieves the symptoms. Enough to close that? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar added a comment. No, but that's fine. One thing less where I can make mistakes :-) Should your next question be regarding author ship, take a look at edbf2e36c805 Thanks. REPOSITORY R246 Sonnet

D17220: Use red X in disabled and muted status icons consistently

ngraham added a comment. the `status/22/audio-volume-muted` icons are still being replaced with symlinks, so I still can't apply the patch. :( REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

ngraham added a comment. Do you have commit access? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, I see now. A smaller dump. :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar added a comment. Um, no(?) In that case I would have named this patch "Add stretch to ensure Dump button is expanding" Sorry, next time I try to describe the pics more precise. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks,

KDE Privacy Sprint - Find a date

Hey, We volunteered to organize a KDE Privacy Sprint. We wanted to make it happen in March. We think at a sprint of five days. The main goal for the sprint is to locate privacy issues and after locating them hopefully fix them. Let's take the advantage to speak in person with multiple people

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

ngraham added a comment. So this patch makes the Dump button much wider? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17191: Perfect alignment between QML and QWidget KCM titles

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/perfectalignment REVISION DETAIL https://phabricator.kde.org/D17191 To: mart, #plasma, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH phab/heading REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 updated this revision to Diff 46419. trickyricky26 added a comment. - Change symlinks REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17220?vs=46418=46419 BRANCH streamline-muted-off (branched from master) REVISION DETAIL

D17220: Use red X in disabled and muted status icons consistently

ngraham added a comment. If you reverse that such that no existing files are replaced with symlinks, it will certainly make it easier to review this patch. If necessary, after that I can do the symlink switcheroo in a separate commit to keep life sane. REPOSITORY R266 Breeze Icons

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 added a comment. I changed the symlinks to point from the off icons to the muted icons; but I could reverse that. Before, the symlinks pointed from the muted icons to the off icons, except for `audio-{on;off;ready}` icons, which don't exist at `22px` at all. Perhaps I

D17220: Use red X in disabled and muted status icons consistently

ngraham added a comment. Oh jeez, this patch replaces some icons with symlinks which makes Phabricator unable to apply the patch. :/ REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg Cc: ngraham, kde-frameworks-devel, michaelh,

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 271 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/271/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 28 Nov 2018 15:36:21 + Build duration: 3 min 33 sec and counting BUILD ARTIFACTS

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17220 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D17220: Use red X in disabled and muted status icons consistently

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH streamline-muted-off (branched from master) REVISION DETAIL

D17167: Provide a method of assigning custom default icons for non-XDG dirs

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17167 To: ngraham, #frameworks, cfeck, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17193: KateViewInternal: Remove unneeded functions

loh.tar updated this revision to Diff 46411. loh.tar added a comment. I think that's all. Well, it looks less beneficial as previous anticipated by me, but I think it's still the right direction. Just a view questions regarding the mix in the KTextEditor::ViewPrivate code how to

D7446: [Places panel] Revamp the Recently Saved section

davidedmundson added a comment. Note also that Kickoff's "History" with recent files is /yet another/ completely different data source. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks Cc:

D7446: [Places panel] Revamp the Recently Saved section

ngraham added a comment. Using "Recently Used" as the section header label presents the following problems: - One of the items is named "Recently Used" - The other items actually do not display a list of recently used files; they display a list of recently //saved// files. That's

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 270 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/270/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 28 Nov 2018 12:04:39 + Build duration: 23 min and counting BUILD ARTIFACTS

D7446: [Places panel] Revamp the Recently Saved section

trickyricky26 added a comment. I like this change a lot, however I think the Section header should be changed from "Recents" to "Recently Used". I think Recents just sound inelegant and weird REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin,

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham added a comment. Waiting for green flags. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17210: Added proxy and user settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added proxy and user settings according to:

D17205: Build kio_nfs against standalone libtirpc

sitter added a comment. LGTM I do wonder if we should support ntirpc too though. At a glance it's largely the same finder s/tirpc/ntirpc/. Admittedly I do not know why there are two libs and both seem to actively get commits. INLINE COMMENTS > CMakeLists.txt:2 > ## Check for XDR

D17206: Rename NotifyByFlatpak to NotifyByPortal

This revision was automatically updated to reflect the committed changes. Closed by commit R289:bfdcffe5bc5b: Rename NotifyByFlatpak to NotifyByPortal (authored by jgrulich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17206?vs=46379=46382 REVISION

D17206: Rename NotifyByFlatpak to NotifyByPortal

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH snap-support REVISION DETAIL https://phabricator.kde.org/D17206 To: jgrulich, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17190: Add level api from Kirigami.Heading

fabianr edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

jgrulich added a comment. In D17206#367286 , @jgrulich wrote: > Make SNAP to use notification portal I didn't mean to push this change into this review, but I guess it doesn't matter. If you want it separated I can submit it separately.

D17206: Rename NotifyByFlatpak to NotifyByPortal

jgrulich updated this revision to Diff 46379. jgrulich added a comment. Make SNAP to use notification portal REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17206?vs=46377=46379 BRANCH snap-support REVISION DETAIL

D17206: Rename NotifyByFlatpak to NotifyByPortal

jgrulich added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17206 To: jgrulich, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17206: Rename NotifyByFlatpak to NotifyByPortal

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY Portals are now used by Snap too, no reason to be use anything Flatpak specific REPOSITORY R289 KNotifications

D17185: Added ip-tunnel settings

pranavgade updated this revision to Diff 46376. pranavgade removed a subscriber: kde-frameworks-devel. pranavgade added a comment. Made a few minor changes REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17185?vs=46310=46376 REVISION DETAIL

D17185: Added ip-tunnel settings

pranavgade marked 5 inline comments as done. pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in iptunnelsettingtest.cpp:79 > Use NetworkManager defines, do not define your own new defines, there is no > reason for that. I tried to follow the way it is done in ipv6settings.