D17317: match and tc setting

jgrulich added a comment. Can you please rebase your changes on top of the current master? I did some changes there and the patch is not applicable. REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 360 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/360/ Project: kf5-qt5 SUSEQt5.9 Date of build: Tue, 04 Dec 2018 06:22:05 + Build duration: 18 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 511 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/511/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 04 Dec 2018 06:22:05 + Build duration: 5 min 46 sec and counting JUnit Tests Name: (root) Failed:

D17285: Add plugin type for sharing URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R495:74e0e9852637: Add plugin type for sharing URLs (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17285?vs=46635=46821 REVISION

D17285: Add plugin type for sharing URLs

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH shareUrl REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

apol added inline comments. INLINE COMMENTS > kdeconnectsmsplugin.cpp:51 > +QString title = data().value(QStringLiteral("title")).toString(); > +QString message = QStringLiteral("%1 - > %2").arg(title).arg(arrayToList(urlsJson).join(QLatin1Char(' '))); > + i18n?

D17287: Enable sharing URLs via email

apol added a comment. I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17287 To:

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

On 03/12/18 09:46, Ben Cooksley wrote: > Hi all, Hi Ben > > I've been informed by the PIM developers that they would like to bump > the dependency of the Qt version they use, from Qt 5.9 which it's on > currently, to Qt 5.10. > > As a consequence, due to many KDE projects using PIM

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

bruns updated this revision to Diff 46820. bruns added a comment. add missing iterator increment REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17338?vs=46810=46820 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17338 AFFECTED FILES

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

This revision was automatically updated to reflect the committed changes. Closed by commit R293:eacc7ac92ab0: Add image/svg as Type::Image to the BasicIndexingJob (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17337?vs=46808=46819 REVISION

D17332: Minor optimization and cleanup for PositionCodec

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c9281ac74e45: Minor optimization and cleanup for PositionCodec (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17332?vs=46791=46818 REVISION

D17310: Improve Kile icon with LaTeX font

ndavis added a comment. What if instead of using 'a' as a variable in the equation, we used 'k'? REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile Cc: mludwig,

D17309: Add flashlight action icons

trickyricky26 added a comment. Ok, will do when I have some time :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

flherne added a comment. Please no. `File -> Save` is one of the most universal menu entries, found in nearly every program that *has* a set of menus. Print is nearly as common. This breaks a user assumption that's been ingrained across virtually all GUI software for decades, and

D17309: Add flashlight action icons

ngraham added a comment. I also like the horizontal one better. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

ndavis added a comment. In D17309#370774 , @trickyricky26 wrote: > Do you think this style is better (16px versions shown): > F6453093: Alternate Style.png I think so. It's more obvious that it's

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, great! Makes sense then, sorry for being dense. :) REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17337 To: bruns, #baloo, #frameworks,

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

dhaumann added a comment. Hm, is this really a good idea? Right now, the File menu is rather flat, which is a good thing imo. Do we really want to move Save operations into a "Save Variants" sub menu? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To:

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

bruns added a comment. In D17337#370955 , @ngraham wrote: > In D17337#370936 , @bruns wrote: > > > In D17337#370934 , @ngraham wrote: > > > > > > text

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

ngraham added a comment. In D17337#370936 , @bruns wrote: > In D17337#370934 , @ngraham wrote: > > > > text spans (i.e. content) in SVG. > > > > Is indexing any of this actually useful? I worry

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

bruns added a comment. In D17337#370934 , @ngraham wrote: > > text spans (i.e. content) in SVG. > > Is indexing any of this actually useful? I worry that it would be just noise in >99% of cases. Why should this be noise? Can you

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

ngraham added a comment. In D17337#370929 , @bruns wrote: > 1. This is just the document type, so it would be even useful for filename only searches Cool, that seems fine. > text spans (i.e. content) in SVG. Is indexing any of

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

bruns added a comment. In D17337#370926 , @ngraham wrote: > Is indexing the contents of SVG images actually desirable? The fact that these files are internally represented by text rather than binary data is an implementation detail, and their

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

ngraham added a comment. Is indexing the contents of SVG images actually desirable? The fact that these files are internally represented by text rather than binary data is an implementation detail, and their contents are generally not useful since they're not intended to be human-readable.

D17332: Minor optimization and cleanup for PositionCodec

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17332 To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko Cc: kde-frameworks-devel, ashaposhnikov, michaelh,

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 167 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/167/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 03 Dec 2018 18:47:30 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

bruns updated this revision to Diff 46810. bruns added a comment. add missing closing parentheses REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17338?vs=46809=46810 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17338 AFFECTED FILES

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 201 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/201/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Dec 2018 18:47:30 + Build duration: 3 min 17 sec and counting JUnit Tests Name: (root)

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Removes the KFileMetadata include dependency in the

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

bruns added a dependent revision: D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17324 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov,

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 84 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/84/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 03 Dec 2018 18:47:30 + Build duration: 1 min 49 sec and counting

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL

D17315: Avoid potential nullptr access for Document, use reference instead

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4fa98ca84fb3: Avoid potential nullptr access for Document, use reference instead (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17300: add result to baloo namespace

astippich abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17300 To: astippich, #baloo, bruns Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17315: Avoid potential nullptr access for Document, use reference instead

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D17315 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. In D16643#370642 , @bruns wrote: > This should not be accepted as is, it breaks the temporaryInhibition case when a DropArea is child of another Ok, could you write a simple QML file to show that case? REPOSITORY

D16954: Add find module for Google's libphonenumber

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D16954 To: vkrause, #build_system, #frameworks, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

D16954: Add find module for Google's libphonenumber

vkrause updated this revision to Diff 46805. vkrause added a comment. Address review comments. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16954?vs=45643=46805 BRANCH master REVISION DETAIL https://phabricator.kde.org/D16954 AFFECTED

D16643: Correct the accept flag of the event object on DragMove

ngraham added a comment. No competence here, sorry. Perhaps @bruns or a #plasma person can help. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc:

D17310: Improve Kile icon with LaTeX font

ngraham added a comment. Yeah, a stylized "K" on its own might work. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To: trickyricky26, #vdg, ngraham, #kile Cc: mludwig, ndavis, ngraham,

D17310: Improve Kile icon with LaTeX font

mludwig added a comment. In D17310#370758 , @ngraham wrote: > I would not recommend embedding the app name into the icon itself. The text isn't localizable, the icon would become really cramped, and in any event it would look weird since no

D17300: add result to baloo namespace

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Actually, this class **is** different - it is not part of the libraries, but statically linked into the extractor process REPOSITORY R293 Baloo REVISION DETAIL

D17309: Add flashlight action icons

abetts added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

trickyricky26 added a comment. Do you think this style is better (16px versions shown): F6453093: Alternate Style.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17309 To: trickyricky26, #vdg Cc: ndavis, ngraham,

D17334: Export enum into qobject for easier debugging

apol created this revision. apol added reviewers: Frameworks, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D17334

D17310: Improve Kile icon with LaTeX font

ngraham added a comment. I would not recommend embedding the app name into the icon itself. The text isn't localizable, the icon would become really cramped, and in any event it would look weird since no other app does this. For those reasons, our HIG specifically recommends against

D17317: match and tc setting

pranavgade updated this revision to Diff 46792. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46789=46792 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17325: Fix leak in kemoticons

anthonyfieroni added inline comments. INLINE COMMENTS > kemoticonstheme.cpp:57 > d = new KEmoticonsThemeData; > -d->provider = p; > +d->provider.reset(p); > } I've rethink it, this line can be a problem if pointer is not owned by us. Did you know consumer of the KEmoticonsTheme?

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. Thats rather difficult. Adding it to the proposed design looks quite cramped: F6452990: kile-alternative.svg.png The only good way to fit "Kile" into that shape is vertical, which looks weird and is not very

D17317: match and tc setting

jgrulich added a comment. And you submitted only changes on top of your changes. INLINE COMMENTS > tcsettingtest.cpp:92 > +// Here the maps should have same keys so compare > QVariantMaps as we do now > +QCOMPARE(listMap, listMap1); > +

D17331: Extend PositionCodec unit tests, better code coverage

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The test never tested position increments

D17332: Minor optimization and cleanup for PositionCodec

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Both getVarint32Ptr and getVarint32PtrFallback

D17317: match and tc setting

pranavgade updated this revision to Diff 46789. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46786=46789 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17325: Fix leak in kemoticons

kfunk updated this revision to Diff 46787. kfunk added a comment. Use QSharedPointer REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17325?vs=46765=46787 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17325 AFFECTED FILES

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

Hi, Can't you just configure the CI to use Qt 5.10? I think it's not good to hardcode an "overzealous" (for lack of a better word) Qt version in projects that don't require them AND I think that one should support the current LTS release in as many projects as possible as a general rule of

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

On Mon, Dec 3, 2018 at 10:31 PM René J.V. Bertin wrote: > > Hi, > > Can't you just configure the CI to use Qt 5.10? I think it's not good to > hardcode an "overzealous" (for lack of a better word) Qt version in projects > that don't require them AND I think that one should support the current

D17317: match and tc setting

jgrulich added inline comments. INLINE COMMENTS > tcsettingtest.cpp:92 > +if (comparedvals == map.size()) { > +comparedMaps++; > +} You still don't compare the values. > jgrulich wrote in setting.cpp:33 > Same here, should be NM 1.14.0. NM 1.14.0 is

D17317: match and tc setting

pranavgade updated this revision to Diff 46786. pranavgade marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46785=46786 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17317: match and tc setting

pranavgade updated this revision to Diff 46785. pranavgade marked 5 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46761=46785 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

thsurrel added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kurlnavigatorbutton.cpp:414 > Or we could use mimetype detection like we do in > `KUrlNavigator::Private::isCompressedPath()`. What would be the clean way to expose this function ? I wouldn't like to duplicate the

D17317: match and tc setting

jgrulich added inline comments. INLINE COMMENTS > matchsettingtest.cpp:29 > + > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_MATCH_INTERFACE_NAME"interface-name" NM 1.14.0, which is not released yet. > jgrulich wrote in tcsettingtest.cpp:74 > Something like: > >

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 359 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/359/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 03 Dec 2018 12:03:44 + Build duration: 24 min and counting JUnit Tests Name: (root) Failed: 1

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 510 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/510/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Dec 2018 12:03:44 + Build duration: 8 min 7 sec and counting JUnit Tests Name: (root) Failed:

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:518a7496c5c5: Warn user before copy/move job if the file size exceeds the maximum possible… (authored by shubham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16249?vs=46490=46783#toc

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 200 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/200/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Dec 2018 11:55:42 + Build duration: 5 min 46 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 83 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/83/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Mon, 03 Dec 2018 11:55:43 + Build duration: 3 min 16 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 166 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/166/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 03 Dec 2018 11:55:43 + Build duration: 1 min 26 sec and counting CONSOLE OUTPUT [...truncated

D17284: RFC: Add unit test for splitting of numbers in TermGenerator

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1b8904a2f2d7: RFC: Add unit test for splitting of numbers in TermGenerator (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17284?vs=46631=46781#toc REPOSITORY R293 Baloo

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux added a comment. In D17015#363060 , @kossebau wrote: > Good to see you caring for ECM documentation not getting broken with Qt 5.12 :) > > Any idea how we could perhaps deduplicate the FindQHelpGenerator.cmake with the one from

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17015 To: cgiboudeaux, kossebau Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

cgiboudeaux updated this revision to Diff 46780. cgiboudeaux added a comment. Add the reason for looking for the executable REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17015?vs=45806=46780 BRANCH arcpatch-D17015 REVISION DETAIL

D17301: add documentation to result class

bruns added inline comments. INLINE COMMENTS > result.h:58 > +/** > + * Overriden function from KFileMetaData::ExtractionResult. > + */ Qt uses "Reimplemented from KFileMetaData::ExtractionResult::addtype()`, see e.g. http://doc.qt.io/qt-5/qfile.html#fileName Overriden has a typo,

D16643: Correct the accept flag of the event object on DragMove

bruns added a comment. This should not be accepted as is, it breaks the temporaryInhibition case when a DropArea is child of another REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc:

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. I don't know what to do next, can you help me @ngraham ? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/78/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 03 Dec 2018 10:39:57 + Build duration: 4 min 58 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/133/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Dec 2018 10:39:57 + Build duration: 4 min 1 sec and counting JUnit Tests Name: (root)

D16643: Correct the accept flag of the event object on DragMove

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

mart requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel,

D16643: Correct the accept flag of the event object on DragMove

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, davidedmundson Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 509 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/509/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 03 Dec 2018 09:27:37 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1

D17310: Improve Kile icon with LaTeX font

mludwig added a comment. Hey, thanks for working on this. I don't mind the change in font style. However, do you think it's possible to add "Kile" somewhere onto the icon as well, preferably quite largely. With this icon, I always find it hard to locate Kile in the task manager.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 358 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/358/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 03 Dec 2018 09:27:37 + Build duration: 9 min 36 sec and counting JUnit Tests Name: (root) Failed: 1

D17281: Add icon to KBuildSycocaProgressDialog cancel button

GB_2 added a comment. Ok. Email: febe...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17281 To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26,

D17195: Avoid constantly increasing Qt event queue in KIO slaves

This revision was automatically updated to reflect the committed changes. Closed by commit R241:5297704106e8: Avoid constantly increasing Qt event queue in KIO slaves (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R241:77efdfdaa4f0: Port some core Q_PRIVATE_SLOTS to new connect syntax (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17260?vs=46570=46774

Transitioning CI builds of all non-Frameworks from Qt 5.9

Hi all, I've been informed by the PIM developers that they would like to bump the dependency of the Qt version they use, from Qt 5.9 which it's on currently, to Qt 5.10. As a consequence, due to many KDE projects using PIM libraries, their dependency on Qt will also be effectively bumped. To

D17281: Add icon to KBuildSycocaProgressDialog cancel button

bcooksley added a comment. Phabricator has a strong privacy model, meaning your email address is not accessible to anyone except you, so you'll need to post it here in this review so it can be committed to our repositories. Sorry for any confusion around this. REPOSITORY R241 KIO

D17325: Fix leak in kemoticons

anthonyfieroni added inline comments. INLINE COMMENTS > kemoticonstheme.cpp:32 > ~KEmoticonsThemeData(); > KEmoticonsProvider *provider = nullptr; > }; Make it shared pointer, KEmoticonsTheme::KEmoticonsTheme(const KEmoticonsTheme ) initialize provider with raw other pointer,