D16694: Improve visibility for Konsole icon when using Breeze Dark

anishgiri updated this revision to Diff 47242. anishgiri added a comment. Fixed some lines around the corner REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16694?vs=47239=47242 BRANCH utilities-terminal (branched from master) REVISION DETAIL

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > dcbsetting.cpp:31 > +, appFipPriority(-1) > +, appIscsiPriority(-1) > +{ } You can initialize also all the lists here, because they have default values as well. > dcbsetting.cpp:197 > +if (userPriority < 8) { > +if

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/9/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 10 Dec 2018 07:08:43 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 370 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/370/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 10 Dec 2018 07:08:43 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 0

D16694: Improve visibility for Konsole icon when using Breeze Dark

anishgiri updated this revision to Diff 47239. anishgiri added a comment. Changed the border color to #eff0f1 and 50% opacity REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16694?vs=46959=47239 BRANCH utilities-terminal (branched from master)

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann added a comment. A good explanation for the timer stuff can be found here: "Solving a Problem Step by Step" on https://doc.qt.io/archives/qq/qq27-responsive-guis.html That avoids the pitfalls of process events (that is mentioned above in the article, too). REPOSITORY

D17421: Add drive-* icons for YaST Partitioner

This revision was automatically updated to reflect the committed changes. Closed by commit R266:eb16fb872125: Add drive-* icons for YaST Partitioner (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17421?vs=47237=47238 REVISION

D17421: Add drive-* icons for YaST Partitioner

ndavis updated this revision to Diff 47237. ndavis added a comment. Add `drive-multidisk-symbolic` and `drive-multipartition-symbolic` REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17421?vs=47234=47237 BRANCH more-harddisk-types (branched from

D17421: Add drive-* icons for YaST Partitioner

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great now! REPOSITORY R266 Breeze Icons BRANCH more-harddisk-types (branched from master) REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg, ngraham Cc:

D17421: Add drive-* icons for YaST Partitioner

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, #vdg, michaelh, bruns

D17421: Add drive-* icons for YaST Partitioner

ndavis updated this revision to Diff 47232. ndavis added a comment. Change monochrome `drive-multipartition` style and add color version REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17421?vs=47085=47232 BRANCH more-harddisk-types (branched from

D17421: Add drive-* icons for YaST Partitioner

ngraham added a comment. In D17421#374272 , @ndavis wrote: > How is this? Monochrome icons typically don't use multiple shades of gray or transparency, but some do. Going clockwise, 100%, 67%, 33% and 0% opacity. > F6467523:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/8/ Project: kf5-qt5 SUSEQt5.11 Date of build: Mon, 10 Dec 2018 04:48:21 + Build duration: 13 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 369 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/369/ Project: kf5-qt5 SUSEQt5.9 Date of build: Mon, 10 Dec 2018 04:48:21 + Build duration: 7 min 12 sec and counting JUnit Tests Name: (root) Failed: 0

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f28e34306378: [KDirOperator] Dont squeeze Name column when there isnt enough horizontal… (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Cool, landing now. If I can get some assistance, I might try my hand at submitting a Qt patch to add the requested resize mode. REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL

D17466: Fix doxygen markdown rendering

argonel created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. argonel requested review of this revision. REVISION SUMMARY Doxygen's parser appears to have trouble with code blocks delimited by backticks and

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > I would probably not make the button that big There are two reasons why it is so big: 1. It's handy. You do not have to move the mouse, no matter which button was clicked 2. It "covers" both buttons to avoid a re-start of any such action without

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

cfeck accepted this revision. cfeck added a comment. See also bug 394115 (and I blamed Qt ...) REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks, cullmann, cfeck Cc:

D17287: Enable sharing URLs via email

nicolasfella added a comment. In D17287#370993 , @apol wrote: > I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client? The

D17305: Add KDE Connect SMS plugin

nicolasfella updated this revision to Diff 47226. nicolasfella added a comment. - i18n REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17305?vs=46697=47226 BRANCH kdeconnectsms REVISION DETAIL https://phabricator.kde.org/D17305 AFFECTED FILES

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. Yeah, I do too. It's certainly more functional. Do you think I should just commit this now? REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg,

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think the proposed change is already an improvement. REPOSITORY R241 KIO BRANCH kdiroperator-detail-view-name-column (branched from master) REVISION DETAIL

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham added a comment. A slightly nicer solution would appear to be to keep column 0 using `QHeaderView::Stretch` like it already is, but give only that column a minimum size equal to the longest item. That way the name column would dynamically expand as the view was enlarged which keeps

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17461 To: ngraham, #vdg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17461: [KDirOperator] Don't squeeze Name column when there isn't enough horizontal space

ngraham created this revision. ngraham added reviewers: VDG, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY When a `KDirOperator` view is used in Detailed or Detailed Tree view, when

D17460: fixups for `extern` and `pragma`

aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY add "Objective-C" linkage type fix `extern(C++)` and add support for `extern(C++, ...)`

D17459: SearchBar: Add Cancel button to stop long running tasks

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. The idea is good, I only am not sure that we want it with process events. That always leads to evil things, like e.g. what happens if you press the X button of the

D17459: SearchBar: Add Cancel button to stop long running tasks

abetts added a comment. I would probably not make the button that big, but I think it is useful REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg Cc: abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Not well tested but looks so far pretty promising. The only thing what I not really like is these modulo check when to ask for user input. How about a QTimer with 200/300ms? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To:

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch could it happens that Kate run an

D17419: Add view-private icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b849a63cefb3: Add view-private icon (authored by GB_2, committed by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47147=47205 REVISION

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

ngraham added a comment. Oh! Sorry, please ignore me... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, cullmann, sars, dhaumann

D17419: Add view-private icon

drosca added a comment. In D17419#374064 , @ngraham wrote: > Ah yeah, I guess that makes sense. > > #falkon folks, is this acceptable? Yes, looks great! REPOSITORY R266 Breeze Icons

D17419: Add view-private icon

ngraham accepted this revision. ngraham added a comment. Ah yeah, I guess that makes sense. #falkon folks, is this acceptable? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon,

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

gregormi added a comment. In D17442#374054 , @ngraham wrote: > In D17442#373755 , @gregormi wrote: > > > In D17442#373708 , @ngraham wrote: > > > > >

D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate

ngraham added a comment. In D17442#373755 , @gregormi wrote: > In D17442#373708 , @ngraham wrote: > > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and [Ctrl] + [⇧] + [G].

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

This revision was automatically updated to reflect the committed changes. Closed by commit R246:454d4d8be9dc: DictionaryComboBox: Keep user preferred dictionaries on top (authored by loh.tar, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D17421: Add drive-* icons for YaST Partitioner

ndavis added a comment. In D17421#373983 , @ngraham wrote: > In D17421#373052 , @ndavis wrote: > > > In D17421#373045 , @ngraham wrote: > > > > > For

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. The intermediate diff looks strange, but the final diff is IMHO ok. Will apply that, thanks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To:

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar added a comment. Um, I'm bit confused when I now look at the diff 1/2 here??? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham, cullmann Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar updated this revision to Diff 47194. loh.tar added a comment. - Add @since hint to speller.h - Add some blank lines to speller.h to be looking a little bit nicer REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17030?vs=45842=47194 REVISION DETAIL

D17457: use STL were no implicit sharing is required

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY try to move to STL for some parts that don't want any sharing nor detaching TEST PLAN make &&

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

cullmann added a comment. In D17030#373994 , @loh.tar wrote: > In D17030#373912 , @cullmann wrote: > > > Ah, one thing: Could you add some @since 5.xxx to the new function in speller.h? > > >

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar added a comment. In D17030#373912 , @cullmann wrote: > Ah, one thing: Could you add some @since 5.xxx to the new function in speller.h? Only in speller? In settings_p.h are also two new, but there was no docu, so I also wrote

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

ngraham added a comment. In terms of the submenu text, I just noticed that we already have "Find Variants" in the Edit menu, so I'm okay with using "Save Variants" and "Close variants" for consistency. We can decide later whether we want to keep that style. REPOSITORY R39 KTextEditor

D17425: dcb settings

jgrulich added inline comments. INLINE COMMENTS > setting.h:98 > > +enum DcbFlagType { > +// None = 0, This flags should be defined in dcbsetting.h, there is no reason to have them defined here. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc:

D17421: Add drive-* icons for YaST Partitioner

ngraham added a comment. In D17421#373052 , @ndavis wrote: > In D17421#373045 , @ngraham wrote: > > > For `drive-multipartition`, maybe a disk with lines that make it look like it's internally

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 17:04:51 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed:

D17441: tune editing actions for large number of small edits

cullmann added a comment. Fixed my QSet issues, I was just stupid, I shall have guarded the push_back with the bool, not the later use. ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: anthonyfieroni,

D17441: tune editing actions for large number of small edits

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:2138e1d27c83: improve range handling, no allocations for common updates (authored by cullmann). CHANGED PRIOR TO

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/81/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 09 Dec 2018 16:31:56 + Build duration: 6 min 53 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 16:31:56 + Build duration: 5 min 45 sec and counting JUnit Tests Name: (root)

D17446: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R244:1285c4bf5552: cmake macros: Port away from deprecated ECM var in kcoreaddons_add_plugin (authored by mpyne). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D17128: DocumentPrivate: Remove comment mark when joining lines

cullmann added a comment. I think we could do that in two steps: 1. Introduce some "smart wrap" setting and using generic code like the above for that 2. If then still we have too many issues, one could outsource that to a js function (if there, like Dominik proposed). REPOSITORY

D17441: tune editing actions for large number of small edits

cullmann added a comment. In D17441#373939 , @loh.tar wrote: > > Yes, there is now a limit for how many highlightings are done. > > If its too much, we skip that, else the rendering will break everthing down ;=) > > Doing these highliting

D17441: tune editing actions for large number of small edits

loh.tar added a comment. > Yes, there is now a limit for how many highlightings are done. > If its too much, we skip that, else the rendering will break everthing down ;=) Doing these highliting "on the fly" (only what is/became visible) is probably not possible(?) BTW: Thanks a

D17436: BrightScript: Remove unused keyword list 'end'

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d4c10b4533ed: BrightScript: Remove unused keyword list end (authored by dhaumann, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17436: BrightScript: Remove unused keyword list 'end'

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. If not used, I shall go, no need to have the warning around. REPOSITORY R216 Syntax Highlighting BRANCH fix_brightscript REVISION DETAIL https://phabricator.kde.org/D17436 To:

D17437: SearchBar: Avoid malfunction with very large files

cullmann added a comment. Ok, I would prefer then if you retract that and submit the cancel thingy. Btw., thanks for all the nice improvements that are submitted! Such fixes are highly appreciated. If you think a review is not done timely, no issue to e.g. poke me. REPOSITORY

D17437: SearchBar: Avoid malfunction with very large files

loh.tar added a comment. In this state was this patch only a simple attempt to avoid the worst case. With your new improvements is it much less likely to happen, but still possible. I do not like to insist of this patch it's only an offer, which could be improved. BTW I'm working on

D17055: Avoid Q_FOREACH

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I would say it looks reasonable and either only stuff const stuff or fresh things inside the for. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17055 To:

D17028: Loader: Avoid Q_FOREACH

This revision was automatically updated to reflect the committed changes. Closed by commit R246:bf8f3067fd3a: Loader: Avoid Q_FOREACH (authored by loh.tar, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17028?vs=45838=47185 REVISION

D17028: Loader: Avoid Q_FOREACH

cullmann added a comment. We started to accept his patches for other frameworks, I think there is no harm in doing so, here, too. Real name or not. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: cullmann, cfeck, smartins,

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R246:a38e1c04a035: Dialog: Use DictionaryComboBox instead of plain QComboBox (authored by loh.tar, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Like the change in KTextEditor, I think this should go in. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17056 To: loh.tar, #frameworks, cullmann Cc:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/5/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 14:40:25 + Build duration: 8 min 25 sec and counting BUILD ARTIFACTS

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Ah, one thing: Could you add some @since 5.xxx to the new function in speller.h? I assume 5.54 would be the right one. REPOSITORY R246 Sonnet REVISION DETAIL

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

cullmann added a comment. I think this makes sense, it improves the usability of the dictionary selection. I see no API issues, should be BC and docs are there, too. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc:

D17441: tune editing actions for large number of small edits

cullmann added a comment. > The only curiosity I noticed is that no highliting take effect when there are too much hits(?) Search some number like 5 "142926 matches found" no highlight. Char A "10565 matches found" is highlighted Yes, there is now a limit for how many highlightings are

D17437: SearchBar: Avoid malfunction with very large files

cullmann added a comment. I think the current state after the improvements in the other bug is good enough to avoid such a message. Would it be ok for you to abandon this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17437 To: loh.tar, #ktexteditor, #vdg,

D17441: tune editing actions for large number of small edits

loh.tar added a comment. > This needs now some user testing ;=) Done as previous, with that testfile. Seams to work so far. Find is still quick, these TAB S takes around 2min. The only curiosity I noticed is that no highliting take effect when there are too much hits(?) Search some

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9ed6507bce24: KateViewInternal: Rename getMouse/Cursor() = mouse/cursorPosition() to fit… (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

Hi, if somebody has an idea, why this test case doesn't work with Qt 5.11 but works ok with Qt 5.9, any hints would be appreciated :( Greetings Christoph - Am 9. Dez 2018 um 15:22 schrieb CI System nore...@kde.org: > BUILD UNSTABLE > Build URL [ >

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 14:09:15 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed:

D17441: tune editing actions for large number of small edits

cullmann added a comment. Hmpf, I amended my commit message to contain a CHANGELOG... and stuff bug unfortunately arc land ate that again :P REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: anthonyfieroni,

D17441: tune editing actions for large number of small edits

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:85a1c56ed832: tune editing actions for large number of small edits (authored by cullmann). REPOSITORY R39

D17441: tune editing actions for large number of small edits

cullmann added a comment. This needs now some user testing ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: anthonyfieroni, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking,

D17441: tune editing actions for large number of small edits

cullmann added inline comments. INLINE COMMENTS > loh.tar wrote in katetextblock.cpp:290 > Noob question: Would QPointer help? > > if (range && range->isValidityCheckRequired()) { As it is no QObject, no ;=) Actually, I think all workaround might be even more expensive than the QSet.

D17441: tune editing actions for large number of small edits

cullmann added a comment. One issue I have with the auto-tests: With and without any of these changes here locally the vimode_keys test fails. FAIL! : KeysTest::MacroTests() Compared values are not the same Actual (kate_document->text()): "completionMacro

D17441: tune editing actions for large number of small edits

loh.tar added inline comments. INLINE COMMENTS > cullmann wrote in katetextblock.cpp:290 > Ok, doesn't work due to the issue that we might delete the range via notifier > in checkValidity() :P Noob question: Would QPointer help? if (range && range->isValidityCheckRequired()) { REPOSITORY

D17441: tune editing actions for large number of small edits

cullmann marked 6 inline comments as done. cullmann added a comment. Crash fixed again. Updated comments to make more clear what happens. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate, loh.tar Cc: anthonyfieroni,

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47181. cullmann added a comment. go back to QSet for the checkValidity, mark in the comments that ranges might be deleted REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47177=47181 BRANCH

D17441: tune editing actions for large number of small edits

cullmann added a comment. Ok, the optimization with the vector fails due delets inside checkValidity(), need to revert that and update docs. INLINE COMMENTS > cullmann wrote in katetextblock.cpp:290 > This loop now crash in the unit test > > ./bin/bug313759 > > ) > = > > It works again,

D17441: tune editing actions for large number of small edits

cullmann added a comment. :P Crash for the win. INLINE COMMENTS > katetextblock.cpp:290 > +// we might need to invalidate ranges or notify about their changes > +for (TextRange *range : changedRanges) { > +if (range->isValidityCheckRequired()) { This loop now

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47177. cullmann added a comment. save 1% total runtime in addItem REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47174=47177 BRANCH arcpatch-D17441 REVISION DETAIL https://phabricator.kde.org/D17441

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47174. cullmann added a comment. next minor bottleneck: QList with things a bit larger than a pointer in addition, here zero sharing is needed or wanted, we can use a plain vector REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 368 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/368/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 09 Dec 2018 11:04:57 + Build duration: 1 hr 23 min and counting JUnit Tests Name: (root) Failed: 0

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47173. cullmann added a comment. avoid most allocations for the common cases of a few affected ranges REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47172=47173 BRANCH arcpatch-D17441 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 204 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/204/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 09 Dec 2018 11:08:22 + Build duration: 1 hr 9 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/54/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 09 Dec 2018 11:03:08 + Build duration: 1 hr 14 min and counting JUnit Tests Name: (root)

D17441: tune editing actions for large number of small edits

cullmann updated this revision to Diff 47172. cullmann added a comment. improve m_isCheckValidityRequired management REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17441?vs=47160=47172 BRANCH arcpatch-D17441 REVISION DETAIL

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/47/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 09 Dec 2018 11:07:43 + Build duration: 1 hr 4 min and counting JUnit Tests Name: (root)

D17441: tune editing actions for large number of small edits

cullmann added a comment. In D17441#373728 , @loh.tar wrote: > I have tried this one. Yes, works much more better! > Nice to see that my own (unloved) patch wake your interest to dig into that issue :-) :=) Nice that it helps a bit

D17441: tune editing actions for large number of small edits

cullmann added a comment. For the unit test: we have tests for ranges, it makes no sense to test if the bool is set. As long as the range tests still work, the updates are ok. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17441 To: cullmann, dhaumann, #kate,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/80/ Project: kf5-qt5 SUSEQt5.9 Date of build: Sun, 09 Dec 2018 11:02:35 + Build duration: 56 min and counting JUnit Tests Name: (root) Failed:

D17441: tune editing actions for large number of small edits

cullmann added a comment. Will improve further ;=) INLINE COMMENTS > anthonyfieroni wrote in katetextblock.cpp:153 > You can use unordered_set, so you don't need m_isCheckValidityRequired any > more. It can be applied to other places as well. Actually no, that will be again a lot more

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.11/2/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 11:08:23 + Build duration: 41 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/2/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 11:07:29 + Build duration: 34 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/2/ Project: kf5-qt5 SUSEQt5.11 Date of build: Sun, 09 Dec 2018 11:06:10 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed: 0

  1   2   >